Re: [PATCHv2 1/6] omap3: Add external VBUS power switch and overcurrent detect on IGEP v2 board.

[Tony Lindgren <tony@atomide.com>]

* Enric Balletbo i Serra <eballetbo@gmail.com> [101001 12:37]:
> GPIO for various devices are missing from the board initialization.
> This patch adds support for the VBUS and over current gpios.  Without this
> patch, input/outputs from these two sources are ignored.
> 
> Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com>
> ---
>  arch/arm/mach-omap2/board-igep0020.c |   14 ++++++++++++++
>  1 files changed, 14 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c
> index 175f043..1052a63 100644
> --- a/arch/arm/mach-omap2/board-igep0020.c
> +++ b/arch/arm/mach-omap2/board-igep0020.c
> @@ -274,6 +274,20 @@ static int igep2_twl_gpio_setup(struct device *dev,
>  	igep2_vmmc1_supply.dev = mmc[0].dev;
>  	igep2_vmmc2_supply.dev = mmc[1].dev;
>  
> +	/*
> +	 * REVISIT: need ehci-omap hooks for external VBUS
> +	 * power switch and overcurrent detect
> +	 */
> +	gpio_request(gpio + 1, "GPIO_EHCI_NOC");
> +	gpio_direction_input(gpio + 1);
> +
> +	/*
> +	 * TWL4030_GPIO_MAX + 0 == ledA, GPIO_USBH_CPEN
> +	 * (out, active low)
> +	 */
> +	gpio_request(gpio + TWL4030_GPIO_MAX, 0);
> +	gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
> +
>  	return 0;
>  };

Please check the result value.. gpio_request can fail.

Tony