From: Tony Lindgren <tony@atomide.com>
To: Enric Balletbo i Serra <eballetbo@gmail.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCHv2 2/6] omap3: fix and improve the LED handling on IGEP v2 board.
Date: Fri, 1 Oct 2010 13:02:55 -0700 [thread overview]
Message-ID: <20101001200254.GX3117@atomide.com> (raw)
In-Reply-To: <1285962353-9586-3-git-send-email-eballetbo@gmail.com>
* Enric Balletbo i Serra <eballetbo@gmail.com> [101001 12:38]:
> The IGEP v2 board has four leds, this patch allows control all
> of these LEDs using the LED class if CONFIG_LEDS_GPIO is selected
> or using the General Purpose Input/Output (GPIO) interface if
> CONFIG_LEDS_GPIO is not selected.
>
> Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com>
> ---
> arch/arm/mach-omap2/board-igep0020.c | 156 +++++++++++++++++++---------------
> 1 files changed, 87 insertions(+), 69 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c
> index 1052a63..9f25d0d 100644
> --- a/arch/arm/mach-omap2/board-igep0020.c
> +++ b/arch/arm/mach-omap2/board-igep0020.c
> @@ -261,6 +261,77 @@ static struct omap2_hsmmc_info mmc[] = {
> {} /* Terminator */
> };
>
> +#if defined(CONFIG_LEDS_GPIO) || defined(CONFIG_LEDS_GPIO_MODULE)
> +#include <linux/leds.h>
> +
> +static struct gpio_led igep2_gpio_leds[] = {
> + [0] = {
> + .name = "gpio-led:red:d0",
> + .gpio = IGEP2_GPIO_LED0_RED,
> + .default_trigger = "default-off"
> + },
> + [1] = {
> + .name = "gpio-led:green:d0",
> + .gpio = IGEP2_GPIO_LED0_GREEN,
> + .default_trigger = "default-off",
> + },
> + [2] = {
> + .name = "gpio-led:red:d1",
> + .gpio = IGEP2_GPIO_LED1_RED,
> + .default_trigger = "default-off",
> + },
> + [3] = {
> + .name = "gpio-led:green:d1",
> + .default_trigger = "heartbeat",
> + .gpio = -EINVAL, /* gets replaced */
> + },
> +};
Please align the igep2_gpio_leds with tabs like you
do already below.
Regards,
Tony
next prev parent reply other threads:[~2010-10-01 20:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 19:45 [PATCHv2 0/6] omap3: Various fixes and improvements for IGEP v2 board Enric Balletbo i Serra
2010-10-01 19:45 ` [PATCHv2 1/6] omap3: Add external VBUS power switch and overcurrent detect on " Enric Balletbo i Serra
2010-10-01 19:59 ` Tony Lindgren
2010-10-01 19:45 ` [PATCHv2 2/6] omap3: fix and improve the LED handling " Enric Balletbo i Serra
2010-10-01 20:02 ` Tony Lindgren [this message]
2010-10-01 19:45 ` [PATCHv2 3/6] omap3: Introduce function to detect the IGEP v2 hardware revision Enric Balletbo i Serra
2010-10-04 4:49 ` Varadarajan, Charulatha
2010-10-01 19:45 ` [PATCHv2 4/6] omap3: Fix handling some GPIO's for WLAN-BT combo on IGEP v2 Enric Balletbo i Serra
2010-10-01 19:45 ` [PATCHv2 5/6] omap3: Add i2c eeprom driver to read EDID " Enric Balletbo i Serra
2010-10-04 4:51 ` Varadarajan, Charulatha
2010-10-01 19:45 ` [PATCHv2 6/6] omap3: Remove VMMC2 regulator " Enric Balletbo i Serra
2010-10-01 20:07 ` [PATCHv2 0/6] omap3: Various fixes and improvements for IGEP v2 board Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101001200254.GX3117@atomide.com \
--to=tony@atomide.com \
--cc=eballetbo@gmail.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.