From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off
Date: Sun, 3 Oct 2010 08:10:48 -0700 [thread overview]
Message-ID: <20101003081048.5013dd26@jbarnes-x201> (raw)
In-Reply-To: <1286091186-3654-2-git-send-email-keithp@keithp.com>
On Sun, 3 Oct 2010 00:33:06 -0700
Keith Packard <keithp@keithp.com> wrote:
> Instead of waiting for the display line value to settle, we can simply
> wait for the pipe configuration register 'state' bit to turn off.
>
> Contrarywise, disabling the plane will not cause the display line
> value to stop changing, so instead we wait for the vblank interrupt
> bit to get set. And, we only do this when we're not about to wait for
> the pipe to turn off.
>
> Signed-off-by: Keith Packard <keithp@keithp.com>
> ---
Do these fixes help with the DP issues you've been seeing, Keith?
Seems like the first one shouldn't change behavior since we ought to
time out on waiting on vblank in that case, and the timeout is the same
as the msleep we used to use.
The second one looks like a good change, but really the pipe off change
is separate from the plane disable bug fix.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-10-03 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-03 7:33 [PATCH 1/2] drm/i915: vblank status not valid while training display port Keith Packard
2010-10-03 7:33 ` [PATCH 2/2] drm/i915: Use pipe state to tell when pipe is off Keith Packard
2010-10-03 9:34 ` Chris Wilson
2010-10-03 15:10 ` Jesse Barnes [this message]
2010-10-03 19:42 ` Keith Packard
2010-10-03 19:55 ` Jesse Barnes
2010-10-03 20:33 ` Dave Airlie
2010-10-03 21:17 ` Jesse Barnes
2010-10-03 23:13 ` [Intel-gfx] " Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101003081048.5013dd26@jbarnes-x201 \
--to=jbarnes@virtuousgeek.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.