From: Jarkko Nikula <jhnikula@gmail.com>
To: "G, Manjunath Kondaiah" <manjugk@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@nokia.com>,
Tony Lindgren <tony@atomide.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH v3 1/2] omap: dma: Fix buffering disable bit setting for omap24xx
Date: Mon, 4 Oct 2010 08:43:17 +0300 [thread overview]
Message-ID: <20101004084317.725009ef.jhnikula@gmail.com> (raw)
In-Reply-To: <E0D41E29EB0DAC4E9F3FF173962E9E9402DB90C5B8@dbde02.ent.ti.com>
On Sat, 2 Oct 2010 10:12:50 +0530
"G, Manjunath Kondaiah" <manjugk@ti.com> wrote:
> > --- a/arch/arm/plat-omap/dma.c
> > +++ b/arch/arm/plat-omap/dma.c
> > @@ -1000,7 +1000,7 @@ void omap_start_dma(int lch)
> > * This will always fail on ES1.0
> > */
> > if (cpu_is_omap24xx())
> > - l |= OMAP_DMA_CCR_EN;
> > + l |= OMAP_DMA_CCR_BUFFERING_DISABLE;
>
> This issue is applicable only for 2430ES1.0(not sure about 2420)
> and it got fixed with later ES versions.
> cpu check should be replaced with:
>
> if (cpu_is_omap2420() || (cpu_is_omap2430() && (omap_type() == OMAP2430_REV_ES1_0)))
>
Ok, thanks for your info, I'll change this.
How about later versions of 2430? Should they use the workaround in
Patch 2/2? We experimented that also on 2420 and it seemed to help but
since the lockup was unrecovable I went thinking if 2420 has also
another issue what original workaround was trying to fix and buffering
disable was needed there.
--
Jarkko
next prev parent reply other threads:[~2010-10-04 5:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 12:36 [PATCH v3 0/2] OMAP2/3: DMA: FIFO drain errata fixes Peter Ujfalusi
2010-10-01 12:36 ` [PATCH v3 1/2] omap: dma: Fix buffering disable bit setting for omap24xx Peter Ujfalusi
2010-10-02 4:42 ` G, Manjunath Kondaiah
2010-10-04 5:43 ` Jarkko Nikula [this message]
2010-10-04 5:55 ` G, Manjunath Kondaiah
2010-10-04 6:15 ` Peter Ujfalusi
2010-10-04 6:23 ` G, Manjunath Kondaiah
2010-10-04 7:15 ` Peter Ujfalusi
2010-10-04 7:36 ` G, Manjunath Kondaiah
2010-10-04 7:41 ` Peter Ujfalusi
2010-10-01 12:36 ` [PATCH v3 2/2] OMAP3: DMA: Errata: sDMA FIFO draining does not finish Peter Ujfalusi
2010-10-01 15:04 ` Shilimkar, Santosh
2010-10-02 4:43 ` G, Manjunath Kondaiah
2010-10-01 16:55 ` Tony Lindgren
2010-10-01 23:23 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101004084317.725009ef.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=manjugk@ti.com \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.