From: Tony Lindgren <tony@atomide.com>
To: Nicolas Kaiser <nikai@nikai.net>
Cc: Tomi Valkeinen <tomi.valkeinen@nokia.com>,
linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video/omap: remove duplicated include
Date: Mon, 04 Oct 2010 17:54:29 +0000 [thread overview]
Message-ID: <20101004175429.GW3117@atomide.com> (raw)
In-Reply-To: <20101004174344.21577085@absol.kitzblitz>
* Nicolas Kaiser <nikai@nikai.net> [101004 08:35]:
> Remove duplicated include.
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> ---
> drivers/video/omap/lcd_omap3beagle.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/omap/lcd_omap3beagle.c b/drivers/video/omap/lcd_omap3beagle.c
> index ca75cc2..ac715f9 100644
> --- a/drivers/video/omap/lcd_omap3beagle.c
> +++ b/drivers/video/omap/lcd_omap3beagle.c
> @@ -26,7 +26,6 @@
> #include <linux/i2c/twl.h>
>
> #include <plat/mux.h>
> -#include <plat/mux.h>
> #include <asm/mach-types.h>
>
> #include "omapfb.h"
Can you please updated this to remove both mux.h entries?
Including mux.h should no longer be needed for omap2/3/4 SoCs
outside arch/arm/mach-omap2 files. For omap1 machines those are still
needed in some drivers..
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Nicolas Kaiser <nikai@nikai.net>
Cc: Tomi Valkeinen <tomi.valkeinen@nokia.com>,
linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video/omap: remove duplicated include
Date: Mon, 4 Oct 2010 10:54:29 -0700 [thread overview]
Message-ID: <20101004175429.GW3117@atomide.com> (raw)
In-Reply-To: <20101004174344.21577085@absol.kitzblitz>
* Nicolas Kaiser <nikai@nikai.net> [101004 08:35]:
> Remove duplicated include.
>
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
> ---
> drivers/video/omap/lcd_omap3beagle.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/omap/lcd_omap3beagle.c b/drivers/video/omap/lcd_omap3beagle.c
> index ca75cc2..ac715f9 100644
> --- a/drivers/video/omap/lcd_omap3beagle.c
> +++ b/drivers/video/omap/lcd_omap3beagle.c
> @@ -26,7 +26,6 @@
> #include <linux/i2c/twl.h>
>
> #include <plat/mux.h>
> -#include <plat/mux.h>
> #include <asm/mach-types.h>
>
> #include "omapfb.h"
Can you please updated this to remove both mux.h entries?
Including mux.h should no longer be needed for omap2/3/4 SoCs
outside arch/arm/mach-omap2 files. For omap1 machines those are still
needed in some drivers..
Regards,
Tony
next prev parent reply other threads:[~2010-10-04 17:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 15:43 [PATCH] video/omap: remove duplicated include Nicolas Kaiser
2010-10-04 15:43 ` Nicolas Kaiser
2010-10-04 17:54 ` Tony Lindgren [this message]
2010-10-04 17:54 ` Tony Lindgren
2010-10-04 18:38 ` [PATCH] video/omap: remove mux.h include Nicolas Kaiser
2010-10-04 18:38 ` Nicolas Kaiser
2010-10-04 18:47 ` Tony Lindgren
2010-10-04 18:47 ` Tony Lindgren
2010-10-05 10:02 ` Tomi Valkeinen
2010-10-05 10:02 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101004175429.GW3117@atomide.com \
--to=tony@atomide.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nikai@nikai.net \
--cc=tomi.valkeinen@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.