From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: linux-input@vger.kernel.org,
LM Sensors <lm-sensors@lm-sensors.org>,
Takashi Iwai <tiwai@suse.de>, Jonathan Cameron <jic23@cam.ac.uk>
Subject: Re: Accelerometer drivers in drivers/hwmon
Date: Mon, 4 Oct 2010 11:03:33 -0700 [thread overview]
Message-ID: <20101004180333.GD8321@core.coreip.homeip.net> (raw)
In-Reply-To: <20100925132330.4ee5e6a7@endymion.delvare>
Hi Jean,
On Sat, Sep 25, 2010 at 01:23:30PM +0200, Jean Delvare wrote:
> Hi Dmitry,
>
> I would like to kick the following 5 drivers out of drivers/hwmon: ams,
> hdaps, hp_accel, lis3lv02d and applesmc. These are primarily
> accelerometer devices, so the drivers do not belong to hwmon.
>
> ams, hdaps, hp_accel and lis3lv02d don't even register a hwmon device.
> They are pure accelerometer drivers as far as I can see. Would you take
> them in drivers/input/misc?
>
> applesmc is more complex, it's a multifunction device. Maybe it would
> better go to drivers/macintosh, where the other thermal management
> drivers for mac machines live.
>
> If you don't want hdaps and hp_accel, they might also fit under
> drivers/platform/x86. There are quite a few laptop-specific drivers
> living there already.
>
> If nobody wants these drivers, drivers/misc is yet another option. I'm
> open to suggestions. Virtually anything which moves these drivers
> outside of drivers/hwmon will make me happy.
>
I looked over the drivers and none of them (with possible exception of
lis3lv02d) are pure input devices either. I think the best course of
action would be to move ams, applesmc, hdaps and hp_accel into
drivers/*/platform (I'd say drivers/x86/platform except that I think
apple one might not be x86 only).
lis3lv02d could ether go into drivers/misc or stay where it is for the
time being, pending resolution on overall IIO/Input/accelerometers
decision. I'd take it in input/misc but accelerometer guys need to
decide on common sysfs layout for such devices.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: linux-input@vger.kernel.org,
LM Sensors <lm-sensors@lm-sensors.org>,
Takashi Iwai <tiwai@suse.de>, Jonathan Cameron <jic23@cam.ac.uk>
Subject: Re: [lm-sensors] Accelerometer drivers in drivers/hwmon
Date: Mon, 04 Oct 2010 18:03:33 +0000 [thread overview]
Message-ID: <20101004180333.GD8321@core.coreip.homeip.net> (raw)
In-Reply-To: <20100925132330.4ee5e6a7@endymion.delvare>
Hi Jean,
On Sat, Sep 25, 2010 at 01:23:30PM +0200, Jean Delvare wrote:
> Hi Dmitry,
>
> I would like to kick the following 5 drivers out of drivers/hwmon: ams,
> hdaps, hp_accel, lis3lv02d and applesmc. These are primarily
> accelerometer devices, so the drivers do not belong to hwmon.
>
> ams, hdaps, hp_accel and lis3lv02d don't even register a hwmon device.
> They are pure accelerometer drivers as far as I can see. Would you take
> them in drivers/input/misc?
>
> applesmc is more complex, it's a multifunction device. Maybe it would
> better go to drivers/macintosh, where the other thermal management
> drivers for mac machines live.
>
> If you don't want hdaps and hp_accel, they might also fit under
> drivers/platform/x86. There are quite a few laptop-specific drivers
> living there already.
>
> If nobody wants these drivers, drivers/misc is yet another option. I'm
> open to suggestions. Virtually anything which moves these drivers
> outside of drivers/hwmon will make me happy.
>
I looked over the drivers and none of them (with possible exception of
lis3lv02d) are pure input devices either. I think the best course of
action would be to move ams, applesmc, hdaps and hp_accel into
drivers/*/platform (I'd say drivers/x86/platform except that I think
apple one might not be x86 only).
lis3lv02d could ether go into drivers/misc or stay where it is for the
time being, pending resolution on overall IIO/Input/accelerometers
decision. I'd take it in input/misc but accelerometer guys need to
decide on common sysfs layout for such devices.
--
Dmitry
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2010-10-04 18:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-25 11:23 Accelerometer drivers in drivers/hwmon Jean Delvare
2010-09-25 11:23 ` [lm-sensors] " Jean Delvare
2010-10-04 18:03 ` Dmitry Torokhov [this message]
2010-10-04 18:03 ` Dmitry Torokhov
2010-10-05 10:16 ` Jonathan Cameron
2010-10-05 10:16 ` [lm-sensors] " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101004180333.GD8321@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=jic23@cam.ac.uk \
--cc=khali@linux-fr.org \
--cc=linux-input@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.