From: Dan Carpenter <error27@gmail.com>
To: Tracey Dent <tdent48227@gmail.com>
Cc: greg@kroah.com, abbotti@mev.co.uk, fmhess@users.sourceforge.net,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/28] Staging: comedi: kcomedilib: kcomedilib_main.c:
Date: Wed, 06 Oct 2010 04:44:00 +0000 [thread overview]
Message-ID: <20101006044400.GB5409@bicker> (raw)
In-Reply-To: <1286326843-6170-10-git-send-email-tdent48227@gmail.com>
On Tue, Oct 05, 2010 at 09:00:25PM -0400, Tracey Dent wrote:
> @@ -50,7 +50,7 @@ struct comedi_device *comedi_open(const char *filename)
> if (strncmp(filename, "/dev/comedi", 11) != 0)
> return NULL;
>
> - minor = simple_strtoul(filename + 11, NULL, 0);
> + minor = strict_strtoul(filename + 11, NULL, 0);
>
No, this doesn't work. strict_strtoul() only returns zero and -EINVAL.
It doesn't return the number.
GCC even warns about this change:
drivers/staging/comedi/kcomedilib/kcomedilib_main.c: In function ‘comedi_open’:
drivers/staging/comedi/kcomedilib/kcomedilib_main.c:53: warning:
passing argument 2 of ‘strict_strtoul’ makes integer from pointer without a cast
Please at least compile these before sending. :(
> if (minor >= COMEDI_NUM_BOARD_MINORS)
> return NULL;
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Tracey Dent <tdent48227@gmail.com>
Cc: greg@kroah.com, abbotti@mev.co.uk, fmhess@users.sourceforge.net,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/28] Staging: comedi: kcomedilib: kcomedilib_main.c: Edit file so that checkpatch.pl has 0 errors and warnings
Date: Wed, 6 Oct 2010 06:44:00 +0200 [thread overview]
Message-ID: <20101006044400.GB5409@bicker> (raw)
In-Reply-To: <1286326843-6170-10-git-send-email-tdent48227@gmail.com>
On Tue, Oct 05, 2010 at 09:00:25PM -0400, Tracey Dent wrote:
> @@ -50,7 +50,7 @@ struct comedi_device *comedi_open(const char *filename)
> if (strncmp(filename, "/dev/comedi", 11) != 0)
> return NULL;
>
> - minor = simple_strtoul(filename + 11, NULL, 0);
> + minor = strict_strtoul(filename + 11, NULL, 0);
>
No, this doesn't work. strict_strtoul() only returns zero and -EINVAL.
It doesn't return the number.
GCC even warns about this change:
drivers/staging/comedi/kcomedilib/kcomedilib_main.c: In function ‘comedi_open’:
drivers/staging/comedi/kcomedilib/kcomedilib_main.c:53: warning:
passing argument 2 of ‘strict_strtoul’ makes integer from pointer without a cast
Please at least compile these before sending. :(
> if (minor >= COMEDI_NUM_BOARD_MINORS)
> return NULL;
regards,
dan carpenter
next prev parent reply other threads:[~2010-10-06 4:44 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 1:00 [PATCH 01/28] Staging: comedi: comedi.h: Edit file so cleanpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` Tracey Dent
2010-10-06 1:00 ` [PATCH 02/28] Staging: comedi: comedi_compat32.c: Edit file so that checkpatch.pl has 0 errors and w Tracey Dent
2010-10-06 1:00 ` [PATCH 02/28] Staging: comedi: comedi_compat32.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 03/28] Staging: comedi: comedi_compat32.h: Edit file so that checkpatch.pl has 0 errors and w Tracey Dent
2010-10-06 1:00 ` [PATCH 03/28] Staging: comedi: comedi_compat32.h: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 04/28] Staging: comedi: comedidev.h: Edit file so that checkpatch.pl has 0 errors and warning Tracey Dent
2010-10-06 1:00 ` [PATCH 04/28] Staging: comedi: comedidev.h: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 05/28] Staging: comedi: comedi_fops.c: Edit file so that checkpatch.pl has 1 warnings and 0 e Tracey Dent
2010-10-06 1:00 ` [PATCH 05/28] Staging: comedi: comedi_fops.c: Edit file so that checkpatch.pl has 1 warnings and 0 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 06/28] Staging: comedi: comedilib.h: Edit file so that checkpatch.pl has 0 errors and warning Tracey Dent
2010-10-06 1:00 ` [PATCH 06/28] Staging: comedi: comedilib.h: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 07/28] Staging: comedi: drivers.c: Edit file so that checkpatch.pl has 4 warnings and 0 error Tracey Dent
2010-10-06 1:00 ` [PATCH 07/28] Staging: comedi: drivers.c: Edit file so that checkpatch.pl has 4 warnings and 0 errors Tracey Dent
2010-10-06 4:48 ` [PATCH 07/28] Staging: comedi: drivers.c: Edit file so that Dan Carpenter
2010-10-06 4:48 ` [PATCH 07/28] Staging: comedi: drivers.c: Edit file so that checkpatch.pl has 4 warnings and 0 errors Dan Carpenter
2010-10-06 17:54 ` [PATCH 07/28] Staging: comedi: drivers.c: Edit file so that checkpatch.pl David Daney
2010-10-06 17:54 ` [PATCH 07/28] Staging: comedi: drivers.c: Edit file so that checkpatch.pl has 4 warnings and 0 errors David Daney
2010-10-06 1:00 ` [PATCH 08/28] Staging: comedi: proc.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` Tracey Dent
2010-10-06 1:00 ` [PATCH 09/28] Staging: comedi: range.c: " Tracey Dent
2010-10-06 1:00 ` Tracey Dent
2010-10-06 1:00 ` [PATCH 10/28] Staging: comedi: kcomedilib: kcomedilib_main.c: Edit file so that checkpatch.pl has 0 Tracey Dent
2010-10-06 1:00 ` [PATCH 10/28] Staging: comedi: kcomedilib: kcomedilib_main.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 4:44 ` Dan Carpenter [this message]
2010-10-06 4:44 ` Dan Carpenter
2010-10-06 1:00 ` [PATCH 11/28] Staging: comedi: drivers: 8253.h: Edit file so that checkpatch.pl has 0 errors and wa Tracey Dent
2010-10-06 1:00 ` [PATCH 11/28] Staging: comedi: drivers: 8253.h: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 12/28] Staging: comedi: drivers: 8255.c: Edit file so that checkpatch.pl has 0 errors and war Tracey Dent
2010-10-06 1:00 ` [PATCH 12/28] Staging: comedi: drivers: 8255.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 13/28] Staging: comedi: drivers: 8255.h: Edit file so that checkpatch.pl has 0 errors and war Tracey Dent
2010-10-06 1:00 ` [PATCH 13/28] Staging: comedi: drivers: 8255.h: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 14/28] Staging: comedi: drivers: adl_pci2608.c: Edit file so that checkpatch.pl has 0 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 14/28] Staging: comedi: drivers: adl_pci2608.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 15/28] Staging: comedi: drivers: adl_pci7230.c: Edit file so that checkpatch.pl has 0 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 15/28] Staging: comedi: drivers: adl_pci7230.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 16/28] Staging: comedi: drivers: adl_pci7296.c: Edit file so that checkpatch.pl has 0 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 16/28] Staging: comedi: drivers: adl_pci7296.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 17/28] Staging: comedi: drivers: adl_pci7432.c: Edit file so that checkpatch.pl has 0 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 17/28] Staging: comedi: drivers: adl_pci7432.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 18/28] Staging: comedi: drivers: adl_pci8164.c: Edit file so that checkpatch.pl has 0 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 18/28] Staging: comedi: drivers: adl_pci8164.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 19/28] Staging: comedi: drivers: adl_pci9111.c: Edit file so that checkpatch.pl has 30 warnin Tracey Dent
2010-10-06 1:00 ` [PATCH 19/28] Staging: comedi: drivers: adl_pci9111.c: Edit file so that checkpatch.pl has 30 warnings and 3 errors Tracey Dent
2010-10-06 4:34 ` [PATCH 19/28] Staging: comedi: drivers: adl_pci9111.c: Edit Dan Carpenter
2010-10-06 4:34 ` [PATCH 19/28] Staging: comedi: drivers: adl_pci9111.c: Edit file so that checkpatch.pl has 30 warnings and 3 errors Dan Carpenter
2010-10-06 1:00 ` [PATCH 20/28] Staging: comedi: drivers: adl_pci9118.c: Edit file so that checkpatch.pl has 0 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 20/28] Staging: comedi: drivers: adl_pci9118.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 21/28] Staging: comedi: drivers: adq12b.c: Edit file so that checkpatch.pl has 0 errors and 2 Tracey Dent
2010-10-06 1:00 ` [PATCH 21/28] Staging: comedi: drivers: adq12b.c: Edit file so that checkpatch.pl has 0 errors and 2 warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 22/28] Staging: comedi: drivers: adv_pci1710.c: Edit file so that checkpatch.pl complains a l Tracey Dent
2010-10-06 1:00 ` [PATCH 22/28] Staging: comedi: drivers: adv_pci1710.c: Edit file so that checkpatch.pl complains a little less Tracey Dent
2010-10-06 1:00 ` [PATCH 23/28] Staging: comedi: drivers: adv_pci1723.c: Edit file so that checkpatch.pl has 0 warning Tracey Dent
2010-10-06 1:00 ` [PATCH 23/28] Staging: comedi: drivers: adv_pci1723.c: Edit file so that checkpatch.pl has 0 warnings and 0 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 24/28] Staging: comedi: drivers: adv_pci_dio.c: Edit file so that checkpatch.pl has 3 warning Tracey Dent
2010-10-06 1:00 ` [PATCH 24/28] Staging: comedi: drivers: adv_pci_dio.c: Edit file so that checkpatch.pl has 3 warnings and 1 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 25/28] Staging: comedi: drivers: aio_aio12_8.c: Edit file so that checkpatch.pl has 0 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 25/28] Staging: comedi: drivers: aio_aio12_8.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 26/28] Staging: comedi: drivers: aio_iiro_16.c: Edit file so that checkpatch.pl has 0 errors Tracey Dent
2010-10-06 1:00 ` [PATCH 26/28] Staging: comedi: drivers: aio_iiro_16.c: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 27/28] Staging: comedi: drivers: am9513.h: Edit file so that checkpatch.pl has 0 errors and w Tracey Dent
2010-10-06 1:00 ` [PATCH 27/28] Staging: comedi: drivers: am9513.h: Edit file so that checkpatch.pl has 0 errors and warnings Tracey Dent
2010-10-06 1:00 ` [PATCH 28/28] Staging: comedi: drivers: amcc_s5933.h: Edit file so that checkpatch.pl has 2 warning Tracey Dent
2010-10-06 1:00 ` [PATCH 28/28] Staging: comedi: drivers: amcc_s5933.h: Edit file so that checkpatch.pl has 2 warnings and 0 errors Tracey Dent
2010-10-06 1:50 ` [PATCH 01/28] Staging: comedi: comedi.h: Edit file so Greg KH
2010-10-06 1:50 ` [PATCH 01/28] Staging: comedi: comedi.h: Edit file so cleanpatch.pl has 0 errors and warnings Greg KH
2010-10-06 2:01 ` [PATCH 01/28] Staging: comedi: comedi.h: Edit file so T Dent
2010-10-06 2:01 ` [PATCH 01/28] Staging: comedi: comedi.h: Edit file so cleanpatch.pl has 0 errors and warnings T Dent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006044400.GB5409@bicker \
--to=error27@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=fmhess@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tdent48227@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.