[PATCH] mokosuite2: Add `libfakekey` and `vala-native` to DEPENDS.

[PATCH] mokosuite2: Add `libfakekey` and `vala-native` to DEPENDS.

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 1339 bytes --]

Date: Mon, 4 Oct 2010 11:56:14 +0200

During the latest bumps of `SRCREV` I guess it was forgotten to add some dependencies.

`libfakekey` is needed for a successful configure and without `vala-native` `valac` is not found on a clean and minimal build system.

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 recipes/openmoko-3rdparty/mokosuite2_git.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes/openmoko-3rdparty/mokosuite2_git.bb b/recipes/openmoko-3rdparty/mokosuite2_git.bb
index cbdf89d..9812ca6 100644
--- a/recipes/openmoko-3rdparty/mokosuite2_git.bb
+++ b/recipes/openmoko-3rdparty/mokosuite2_git.bb
@@ -2,11 +2,11 @@ DESCRIPTION = "Desktop environment and phone stack GUI for SHR"
 HOMEPAGE = "http://gitorious.org/mokosuite2"
 AUTHOR = "Daniele Ricci"
 LICENSE = "GPLv3"
-DEPENDS = "mokowm elementary libfreesmartphone-glib libphone-utils eggdbus glib-2.0 dbus-glib alsa-lib db sqlite3"
+DEPENDS = "mokowm elementary libfakekey libfreesmartphone-glib libphone-utils eggdbus glib-2.0 dbus-glib alsa-lib db sqlite3 vala-native"
 SECTION = "misc/utils"
 
 PV = "1.0.99+gitr${SRCPV}"
-PR = "r1"
+PR = "r2"
 SRCREV = "e70e928216eea9d07c28327634ea49c87bc0c92f"
 
 SRC_URI = "git://gitorious.org/mokosuite2/appbunch.git;protocol=git"
-- 
1.7.1

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH] mokosuite2: Add `libfakekey` and `vala-native` to DEPENDS.

[Martin Jansa]

On Wed, Oct 06, 2010 at 04:19:34PM +0200, Paul Menzel wrote:
> 
> During the latest bumps of `SRCREV` I guess it was forgotten to add some dependencies.
> 
> `libfakekey` is needed for a successful configure and without `vala-native` `valac` is not found on a clean and minimal build system.
> 
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>

Acked-by: Martin Jansa <Martin.Jansa@gmail.com>

IMHO no need to bump PR as it won't change resulting packages, but won't
harm as it builds quickly.

Thanks for spotting it.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[PATCH v2] mokosuite2: Add `libfakekey` and `vala-native` to `DEPENDS`.

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 2118 bytes --]

Am Mittwoch, den 06.10.2010, 16:25 +0200 schrieb Martin Jansa:
> On Wed, Oct 06, 2010 at 04:19:34PM +0200, Paul Menzel wrote:
> > 
> > During the latest bumps of `SRCREV` I guess it was forgotten to add some dependencies.
> > 
> > `libfakekey` is needed for a successful configure and without `vala-native` `valac` is not found on a clean and minimal build system.
> > 
> > Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> 
> Acked-by: Martin Jansa <Martin.Jansa@gmail.com>
> 
> IMHO no need to bump PR as it won't change resulting packages, but won't
> harm as it builds quickly.

Ok, I updated the patch.

Could someone please commit this, since I do not have commit rights.

> Thanks for spotting it.

No problem. Do you have an idea on how to avoid that in the future?

8<-------------------------------------------------------------------->8
Date: Mon, 4 Oct 2010 11:56:14 +0200

During the latest bumps of `SRCREV` I guess it was forgotten to add some dependencies.

`libfakekey` is needed for a successful configure and without `vala-native` `valac` is not found on a clean and minimal build system.

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Acked-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 recipes/openmoko-3rdparty/mokosuite2_git.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/recipes/openmoko-3rdparty/mokosuite2_git.bb b/recipes/openmoko-3rdparty/mokosuite2_git.bb
index cbdf89d..d17f100 100644
--- a/recipes/openmoko-3rdparty/mokosuite2_git.bb
+++ b/recipes/openmoko-3rdparty/mokosuite2_git.bb
@@ -2,7 +2,7 @@ DESCRIPTION = "Desktop environment and phone stack GUI for SHR"
 HOMEPAGE = "http://gitorious.org/mokosuite2"
 AUTHOR = "Daniele Ricci"
 LICENSE = "GPLv3"
-DEPENDS = "mokowm elementary libfreesmartphone-glib libphone-utils eggdbus glib-2.0 dbus-glib alsa-lib db sqlite3"
+DEPENDS = "mokowm elementary libfakekey libfreesmartphone-glib libphone-utils eggdbus glib-2.0 dbus-glib alsa-lib db sqlite3 vala-native"
 SECTION = "misc/utils"
 
 PV = "1.0.99+gitr${SRCPV}"
-- 
1.7.1

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v2] mokosuite2: Add `libfakekey` and `vala-native` to `DEPENDS`.

[Martin Jansa]

On Wed, Oct 06, 2010 at 04:56:55PM +0200, Paul Menzel wrote:
> Am Mittwoch, den 06.10.2010, 16:25 +0200 schrieb Martin Jansa:
> > On Wed, Oct 06, 2010 at 04:19:34PM +0200, Paul Menzel wrote:
> > > 
> > > During the latest bumps of `SRCREV` I guess it was forgotten to add some dependencies.
> > > 
> > > `libfakekey` is needed for a successful configure and without `vala-native` `valac` is not found on a clean and minimal build system.
> > > 
> > > Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> > 
> > Acked-by: Martin Jansa <Martin.Jansa@gmail.com>
> > 
> > IMHO no need to bump PR as it won't change resulting packages, but won't
> > harm as it builds quickly.
> 
> Ok, I updated the patch.
> Could someone please commit this, since I do not have commit rights.

Both pushed.
 
> > Thanks for spotting it.
> 
> No problem. Do you have an idea on how to avoid that in the future?

not really, from what I understand packaged staging makes it
easier/faster to rebuild after prunning sysroots, but ie if I use
shr-image as target, then it's quite likely that ie libfakekey gets
staged (because of some other recipe) before building mokosuite2.

Regards,
-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com