From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jens Axboe <jaxboe@fusionio.com>, Christoph Hellwig <hch@lst.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] one writeback regression fix for .36
Date: Wed, 6 Oct 2010 19:31:24 +0100 [thread overview]
Message-ID: <20101006183124.GR19804@ZenIV.linux.org.uk> (raw)
In-Reply-To: <AANLkTi=NkzSWR0voR9xLs2f7Rxfc4A_n7qi+t9fbB2iz@mail.gmail.com>
On Wed, Oct 06, 2010 at 11:17:54AM -0700, Linus Torvalds wrote:
> > Christoph Hellwig (1):
> > ? ? ?writeback: always use sb->s_bdi for writeback purposes
>
> This is a f*cking disgrace. It's now the second patch I see during
> this release window that works by parsing random strings in the block
> device layer.
>
> This needs to stop. There's something seriously wrong in the whole
> subsystem. This kind of hackery is a disease, and it seems to be
> endemic.
Eh... I'm no fonder of that than you are (and strcmp is fucking stupid),
but... that thing is really sb_is_blkdev_sb() trying to make a comeback
in fs/fs-writeback.c. IOW, it's sick, but not for the reasons you are
mentioning; strcmp() use is trivially removable.
next prev parent reply other threads:[~2010-10-06 18:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 16:54 [GIT PULL] one writeback regression fix for .36 Jens Axboe
2010-10-06 18:17 ` Linus Torvalds
2010-10-06 18:31 ` Al Viro [this message]
2010-10-06 18:43 ` Christoph Hellwig
2010-10-06 18:38 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006183124.GR19804@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@lst.de \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.