From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Jens Axboe <jaxboe@fusionio.com>, Christoph Hellwig <hch@lst.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] one writeback regression fix for .36
Date: Wed, 6 Oct 2010 20:43:53 +0200 [thread overview]
Message-ID: <20101006184353.GA30673@lst.de> (raw)
In-Reply-To: <20101006183124.GR19804@ZenIV.linux.org.uk>
On Wed, Oct 06, 2010 at 07:31:24PM +0100, Al Viro wrote:
> Eh... I'm no fonder of that than you are (and strcmp is fucking stupid),
> but... that thing is really sb_is_blkdev_sb() trying to make a comeback
> in fs/fs-writeback.c. IOW, it's sick, but not for the reasons you are
> mentioning; strcmp() use is trivially removable.
The alternative basically is exporting bd_type so that it can be used
here and comparing ->s_type. The real problem is that right now the
internal block device filesystem is the only one having more than one
backing device per filesystem. I have patches to generalize that, which
is something we'll need for writeback performance on large filesystem
sooner or later. I was planning to get this ready for 2.6.37, but if
you prefer no big chance in this area I can calm down and move other
things up on my TODO list.
next prev parent reply other threads:[~2010-10-06 18:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 16:54 [GIT PULL] one writeback regression fix for .36 Jens Axboe
2010-10-06 18:17 ` Linus Torvalds
2010-10-06 18:31 ` Al Viro
2010-10-06 18:43 ` Christoph Hellwig [this message]
2010-10-06 18:38 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006184353.GA30673@lst.de \
--to=hch@lst.de \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.