From: John W. Linville <linville@tuxdriver.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Michael Büsch" <mb@bu3sch.de>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: [PATCH 3/3] b43: N-PHY: don't duplicate setting channel in shared memory
Date: Wed, 6 Oct 2010 16:18:51 -0400 [thread overview]
Message-ID: <20101006201850.GK2472@tuxdriver.com> (raw)
In-Reply-To: <AANLkTinsWTCmTjYZ=SgY0-ArTOVgG50V0r9USHnuvQfb@mail.gmail.com>
On Wed, Oct 06, 2010 at 06:07:44PM +0200, Rafa? Mi?ecki wrote:
> W dniu 6 pa?dziernika 2010 17:30 u?ytkownik Michael B?sch
> <mb@bu3sch.de> napisa?:
> > On Wed, 2010-10-06 at 07:50 +0200, Rafa? Mi?ecki wrote:
> >> + ? ? /* Don't follow specs, B43_SHM_SH_CHAN is set by b43_switch_channel */
> >
> > Looks great. I dunno if a comment is really needed and whether it is
> > correct, though. We _do_ follow the specs. We just do it elsewhere.
>
> I got "Don't strictly follow specs here" earlier, but made it shorter
> to match 80 chars ;) Maybe it wasn't too good idea. Should left it
> longer or don't put at all.
>
> John: could you drop this comment line when applying? Or would you
> like me to resend this fixed?
Got it...
--
John W. Linville Someday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Michael Büsch" <mb@bu3sch.de>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org
Subject: Re: [PATCH 3/3] b43: N-PHY: don't duplicate setting channel in shared memory
Date: Wed, 6 Oct 2010 16:18:51 -0400 [thread overview]
Message-ID: <20101006201850.GK2472@tuxdriver.com> (raw)
In-Reply-To: <AANLkTinsWTCmTjYZ=SgY0-ArTOVgG50V0r9USHnuvQfb@mail.gmail.com>
On Wed, Oct 06, 2010 at 06:07:44PM +0200, Rafał Miłecki wrote:
> W dniu 6 października 2010 17:30 użytkownik Michael Büsch
> <mb@bu3sch.de> napisał:
> > On Wed, 2010-10-06 at 07:50 +0200, Rafał Miłecki wrote:
> >> + /* Don't follow specs, B43_SHM_SH_CHAN is set by b43_switch_channel */
> >
> > Looks great. I dunno if a comment is really needed and whether it is
> > correct, though. We _do_ follow the specs. We just do it elsewhere.
>
> I got "Don't strictly follow specs here" earlier, but made it shorter
> to match 80 chars ;) Maybe it wasn't too good idea. Should left it
> longer or don't put at all.
>
> John: could you drop this comment line when applying? Or would you
> like me to resend this fixed?
Got it...
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-10-06 20:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 5:50 [PATCH 0/3] b43: channel switching little cleaning Rafał Miłecki
2010-10-06 5:50 ` Rafał Miłecki
2010-10-06 5:50 ` [PATCH 1/3] b43: N-PHY: simplify channel switching Rafał Miłecki
2010-10-06 5:50 ` Rafał Miłecki
2010-10-06 5:50 ` [PATCH 2/3] b43: define B43_SHM_SH_CHAN_40MHZ Rafał Miłecki
2010-10-06 5:50 ` Rafał Miłecki
2010-10-06 5:50 ` [PATCH 3/3] b43: N-PHY: don't duplicate setting channel in shared memory Rafał Miłecki
2010-10-06 5:50 ` Rafał Miłecki
2010-10-06 15:30 ` Michael Büsch
2010-10-06 15:30 ` Michael Büsch
2010-10-06 16:07 ` Rafał Miłecki
2010-10-06 16:07 ` Rafał Miłecki
2010-10-06 20:18 ` John W. Linville [this message]
2010-10-06 20:18 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006201850.GK2472@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.