From: Andi Kleen <andi@firstfloor.org>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, fengguang.wu@intel.com,
linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/4] HWPOISON: Report correct address granuality for AO huge page errors
Date: Thu, 7 Oct 2010 09:38:48 +0200 [thread overview]
Message-ID: <20101007073848.GG5010@basil.fritz.box> (raw)
In-Reply-To: <20101007003120.GB9891@spritzera.linux.bs1.fc.nec.co.jp>
On Thu, Oct 07, 2010 at 09:31:20AM +0900, Naoya Horiguchi wrote:
> > @@ -198,7 +199,8 @@ static int kill_proc_ao(struct task_struct *t, unsigned long addr, int trapno,
> > #ifdef __ARCH_SI_TRAPNO
> > si.si_trapno = trapno;
> > #endif
> > - si.si_addr_lsb = PAGE_SHIFT;
> > + order = PageCompound(page) ? huge_page_order(page) : PAGE_SHIFT;
> ^^^^
> huge_page_order(page_hstate(page)) ?
Ok.
> > printk(KERN_ERR
> > "MCE %#lx: forcibly killing %s:%d because of failure to unmap corrupted page\n",
> > - pfn, tk->tsk->comm, tk->tsk->pid);
> > + pfn,
> > + tk->tsk->comm, tk->tsk->pid);
>
> What's the point of this change?
Probably left over from an earlier version; I will drop that hunk thanks.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, fengguang.wu@intel.com,
linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/4] HWPOISON: Report correct address granuality for AO huge page errors
Date: Thu, 7 Oct 2010 09:38:48 +0200 [thread overview]
Message-ID: <20101007073848.GG5010@basil.fritz.box> (raw)
In-Reply-To: <20101007003120.GB9891@spritzera.linux.bs1.fc.nec.co.jp>
On Thu, Oct 07, 2010 at 09:31:20AM +0900, Naoya Horiguchi wrote:
> > @@ -198,7 +199,8 @@ static int kill_proc_ao(struct task_struct *t, unsigned long addr, int trapno,
> > #ifdef __ARCH_SI_TRAPNO
> > si.si_trapno = trapno;
> > #endif
> > - si.si_addr_lsb = PAGE_SHIFT;
> > + order = PageCompound(page) ? huge_page_order(page) : PAGE_SHIFT;
> ^^^^
> huge_page_order(page_hstate(page)) ?
Ok.
> > printk(KERN_ERR
> > "MCE %#lx: forcibly killing %s:%d because of failure to unmap corrupted page\n",
> > - pfn, tk->tsk->comm, tk->tsk->pid);
> > + pfn,
> > + tk->tsk->comm, tk->tsk->pid);
>
> What's the point of this change?
Probably left over from an earlier version; I will drop that hunk thanks.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-07 7:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 20:48 HWPoison fixes for 2.6.36 Andi Kleen
2010-10-06 20:48 ` Andi Kleen
2010-10-06 20:48 ` [PATCH 1/4] page-types.c: fix name of unpoison interface Andi Kleen
2010-10-06 20:48 ` Andi Kleen
2010-10-06 20:48 ` [PATCH 2/4] HWPOISON: Copy si_addr_lsb to user Andi Kleen
2010-10-06 20:48 ` Andi Kleen
2010-10-07 0:27 ` Naoya Horiguchi
2010-10-07 0:27 ` Naoya Horiguchi
2010-10-07 6:31 ` Hidetoshi Seto
2010-10-07 6:31 ` Hidetoshi Seto
2010-10-07 7:36 ` Andi Kleen
2010-10-07 7:36 ` Andi Kleen
2010-10-08 17:09 ` Ralf Baechle
2010-10-08 17:09 ` Ralf Baechle
2010-10-08 17:32 ` Andi Kleen
2010-10-08 17:32 ` Andi Kleen
2010-10-06 20:49 ` [PATCH 3/4] HWPOISON: Report correct address granuality for AO huge page errors Andi Kleen
2010-10-06 20:49 ` Andi Kleen
2010-10-07 0:31 ` Naoya Horiguchi
2010-10-07 0:31 ` Naoya Horiguchi
2010-10-07 7:38 ` Andi Kleen [this message]
2010-10-07 7:38 ` Andi Kleen
2010-10-07 8:41 ` Naoya Horiguchi
2010-10-07 8:41 ` Naoya Horiguchi
2010-10-07 8:45 ` Andi Kleen
2010-10-07 8:45 ` Andi Kleen
2010-10-07 8:48 ` Naoya Horiguchi
2010-10-07 8:48 ` Naoya Horiguchi
2010-10-07 8:58 ` Andi Kleen
2010-10-07 8:58 ` Andi Kleen
2010-10-07 1:50 ` Wu Fengguang
2010-10-07 1:50 ` Wu Fengguang
2010-10-06 20:49 ` [PATCH 4/4] HWPOISON: Stop shrinking at right page count Andi Kleen
2010-10-06 20:49 ` Andi Kleen
2010-10-07 1:53 ` Wu Fengguang
2010-10-07 1:53 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101007073848.GG5010@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.