From: Ingo Molnar <mingo@elte.hu>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: H Peter Anvin <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Guenter Roeck <guenter.roeck@ericsson.com>,
Jean Delvare <khali@linux-fr.org>,
Jin Dongming <jin.dongming@np.css.fujitsu.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
lm-sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH v2] x86/therm_throt.c: Fix error handling
Date: Fri, 08 Oct 2010 08:26:31 +0000 [thread overview]
Message-ID: <20101008082631.GE13754@elte.hu> (raw)
In-Reply-To: <1283905550-18571-1-git-send-email-fenghua.yu@intel.com>
* Fenghua Yu <fenghua.yu@intel.com> wrote:
> #ifdef CONFIG_HOTPLUG_CPU
> mutex_unlock(&therm_cpu_lock);
> #endif
> +#ifdef CONFIG_HOTPLUG_CPU
> + mutex_unlock(&therm_cpu_lock);
> +#endif
That's all very ugly.
Thanks,
Ingo
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: H Peter Anvin <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Guenter Roeck <guenter.roeck@ericsson.com>,
Jean Delvare <khali@linux-fr.org>,
Jin Dongming <jin.dongming@np.css.fujitsu.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
lm-sensors <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH v2] x86/therm_throt.c: Fix error handling in thermal_throttle_add_dev
Date: Fri, 8 Oct 2010 10:26:31 +0200 [thread overview]
Message-ID: <20101008082631.GE13754@elte.hu> (raw)
In-Reply-To: <1283905550-18571-1-git-send-email-fenghua.yu@intel.com>
* Fenghua Yu <fenghua.yu@intel.com> wrote:
> #ifdef CONFIG_HOTPLUG_CPU
> mutex_unlock(&therm_cpu_lock);
> #endif
> +#ifdef CONFIG_HOTPLUG_CPU
> + mutex_unlock(&therm_cpu_lock);
> +#endif
That's all very ugly.
Thanks,
Ingo
next prev parent reply other threads:[~2010-10-08 8:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 0:25 [lm-sensors] [PATCH v2] x86/therm_throt.c: Fix error handling in Fenghua Yu
2010-09-08 0:25 ` [PATCH v2] x86/therm_throt.c: Fix error handling in thermal_throttle_add_dev Fenghua Yu
2010-09-10 8:19 ` [lm-sensors] [PATCH v2] x86/therm_throt.c: Fix error handling Jean Delvare
2010-09-10 8:19 ` [PATCH v2] x86/therm_throt.c: Fix error handling in thermal_throttle_add_dev Jean Delvare
2010-09-10 13:56 ` [lm-sensors] [PATCH v2] x86/therm_throt.c: Fix error handling Guenter Roeck
2010-09-10 13:56 ` [PATCH v2] x86/therm_throt.c: Fix error handling in thermal_throttle_add_dev Guenter Roeck
2010-09-13 7:55 ` [lm-sensors] [PATCH v2] x86/therm_throt.c: Fix error handling Jean Delvare
2010-09-13 7:55 ` [PATCH v2] x86/therm_throt.c: Fix error handling in thermal_throttle_add_dev Jean Delvare
2010-10-08 8:10 ` [lm-sensors] [PATCH v2] x86/therm_throt.c: Fix error handling Jean Delvare
2010-10-08 8:10 ` [PATCH v2] x86/therm_throt.c: Fix error handling in thermal_throttle_add_dev Jean Delvare
2010-10-08 8:26 ` Ingo Molnar [this message]
2010-10-08 8:26 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101008082631.GE13754@elte.hu \
--to=mingo@elte.hu \
--cc=fenghua.yu@intel.com \
--cc=guenter.roeck@ericsson.com \
--cc=hpa@zytor.com \
--cc=jin.dongming@np.css.fujitsu.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.