All of lore.kernel.org
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: allow, but warn, when issuing ioremap() on RAM
Date: Fri, 8 Oct 2010 12:58:03 -0700	[thread overview]
Message-ID: <20101008125803.e5bc7306.akpm@linux-foundation.org> (raw)
In-Reply-To: <20101007192245.GC26435@n2100.arm.linux.org.uk>

On Thu, 7 Oct 2010 20:22:45 +0100
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:

> On Thu, Oct 07, 2010 at 12:44:22PM +0300, Felipe Contreras wrote:
> > Many drivers are broken, and there's no alternative in sight. Such a big
> > change should stay as a warning for now, and only later should it
> > actually fail.
> > 
> > The drivers are not doing something correct, we get it, but for now it's
> > better to allow them to work (they do 99% of the time anyway) rather
> > than to force everyone to revert this patch in their internal trees
> > until there's a solution. A slightly broken functionality is better than
> > no functionality at all.
> > 
> > A warning lets people know that what they are doing is not right, and
> > they should fix it.
> 
> So what are _you_ going to do to fix these drivers?  Continue reverting
> this patch?  Or are you just going to ignore the issue entirely?
> 
> Unless people can come up with a plan to fix their drivers using ioremap
> on system RAM thereby violating the architecture specification, I'm
> _not_ going to apply this patch.

We *do* have a plan: as of 2.6.36, the kernel will emit a WARN_ON trace
when a driver does this.  Offending code will be discovered, developers
will get bug reports from worried users, etc.  This is usually pretty
effective.

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
	linux-main <linux-kernel@vger.kernel.org>,
	linux-arm <linux-arm-kernel@lists.infradead.org>,
	"Arnd Hannemann" <arnd@arndnet.de>,
	"Han Jonghun" <jonghun79.han@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Hemant Pedanekar" <hemantp@ti.com>
Subject: Re: [PATCH] ARM: allow, but warn, when issuing ioremap() on RAM
Date: Fri, 8 Oct 2010 12:58:03 -0700	[thread overview]
Message-ID: <20101008125803.e5bc7306.akpm@linux-foundation.org> (raw)
In-Reply-To: <20101007192245.GC26435@n2100.arm.linux.org.uk>

On Thu, 7 Oct 2010 20:22:45 +0100
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:

> On Thu, Oct 07, 2010 at 12:44:22PM +0300, Felipe Contreras wrote:
> > Many drivers are broken, and there's no alternative in sight. Such a big
> > change should stay as a warning for now, and only later should it
> > actually fail.
> > 
> > The drivers are not doing something correct, we get it, but for now it's
> > better to allow them to work (they do 99% of the time anyway) rather
> > than to force everyone to revert this patch in their internal trees
> > until there's a solution. A slightly broken functionality is better than
> > no functionality at all.
> > 
> > A warning lets people know that what they are doing is not right, and
> > they should fix it.
> 
> So what are _you_ going to do to fix these drivers?  Continue reverting
> this patch?  Or are you just going to ignore the issue entirely?
> 
> Unless people can come up with a plan to fix their drivers using ioremap
> on system RAM thereby violating the architecture specification, I'm
> _not_ going to apply this patch.

We *do* have a plan: as of 2.6.36, the kernel will emit a WARN_ON trace
when a driver does this.  Offending code will be discovered, developers
will get bug reports from worried users, etc.  This is usually pretty
effective.


  parent reply	other threads:[~2010-10-08 19:58 UTC|newest]

Thread overview: 209+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-07  9:44 [PATCH] ARM: allow, but warn, when issuing ioremap() on RAM Felipe Contreras
2010-10-07  9:44 ` Felipe Contreras
2010-10-07 11:51 ` Baruch Siach
2010-10-07 11:51   ` Baruch Siach
2010-10-07 12:29   ` [PATCH v2] " Felipe Contreras
2010-10-07 12:29     ` Felipe Contreras
2010-10-07 18:00     ` Uwe Kleine-König
2010-10-07 18:00       ` Uwe Kleine-König
2010-10-07 19:22 ` [PATCH] " Russell King - ARM Linux
2010-10-07 19:22   ` Russell King - ARM Linux
2010-10-08  9:32   ` Felipe Contreras
2010-10-08  9:32     ` Felipe Contreras
2010-10-08 17:53     ` Russell King - ARM Linux
2010-10-08 17:53       ` Russell King - ARM Linux
2010-10-08 19:37       ` Felipe Contreras
2010-10-08 19:37         ` Felipe Contreras
2010-10-08 23:04         ` Russell King - ARM Linux
2010-10-08 23:04           ` Russell King - ARM Linux
2010-10-08 23:25           ` Greg KH
2010-10-08 23:25             ` Greg KH
2010-10-08 23:44             ` Russell King - ARM Linux
2010-10-08 23:44               ` Russell King - ARM Linux
2010-10-09  0:00               ` Greg KH
2010-10-09  0:00                 ` Greg KH
2010-10-09  0:25                 ` Russell King - ARM Linux
2010-10-09  0:25                   ` Russell King - ARM Linux
2010-10-09  0:54                   ` Greg KH
2010-10-09  0:54                     ` Greg KH
2010-10-09  2:41                   ` Nicolas Pitre
2010-10-09  2:41                     ` Nicolas Pitre
2010-10-09  3:04                     ` Greg KH
2010-10-09  3:04                       ` Greg KH
2010-10-09  9:32                       ` Felipe Contreras
2010-10-09  9:32                         ` Felipe Contreras
2010-10-11 10:05                     ` Catalin Marinas
2010-10-11 10:05                       ` Catalin Marinas
2010-10-11 10:39                       ` Felipe Contreras
2010-10-11 10:39                         ` Felipe Contreras
2010-10-11 10:52                         ` Russell King - ARM Linux
2010-10-11 10:52                           ` Russell King - ARM Linux
2010-10-11 11:23                         ` Catalin Marinas
2010-10-11 11:23                           ` Catalin Marinas
2010-10-11 12:03                           ` Felipe Contreras
2010-10-11 12:03                             ` Felipe Contreras
2010-10-11 12:30                             ` Catalin Marinas
2010-10-11 12:30                               ` Catalin Marinas
2010-10-11 22:53                               ` Nicolas Pitre
2010-10-11 22:53                                 ` Nicolas Pitre
2010-10-14 15:02                               ` Felipe Contreras
2010-10-14 15:02                                 ` Felipe Contreras
2010-10-14 17:18                                 ` Catalin Marinas
2010-10-14 17:18                                   ` Catalin Marinas
2010-10-14 17:44                                   ` Felipe Contreras
2010-10-14 17:44                                     ` Felipe Contreras
2010-10-11 11:01                       ` Pawel Moll
2010-10-11 11:01                         ` Pawel Moll
2010-10-11 11:03                         ` Catalin Marinas
2010-10-11 11:03                           ` Catalin Marinas
2010-10-16  2:39                 ` Benjamin Herrenschmidt
2010-10-16  2:39                   ` Benjamin Herrenschmidt
2010-10-16  9:43                   ` Felipe Contreras
2010-10-16  9:43                     ` Felipe Contreras
2010-10-09  0:10               ` Russell King - ARM Linux
2010-10-09  0:10                 ` Russell King - ARM Linux
2010-10-09  0:56               ` Felipe Contreras
2010-10-09  0:56                 ` Felipe Contreras
2010-10-09  9:21                 ` Russell King - ARM Linux
2010-10-09  9:21                   ` Russell King - ARM Linux
2010-10-09 10:28                   ` Felipe Contreras
2010-10-09 10:28                     ` Felipe Contreras
2010-10-09 11:11                     ` Arnd Bergmann
2010-10-09 11:11                       ` Arnd Bergmann
2010-10-09 11:43                       ` Dave Airlie
2010-10-09 11:43                         ` Dave Airlie
2010-10-09 11:55                         ` Christoph Hellwig
2010-10-09 11:55                           ` Christoph Hellwig
2010-10-09 12:17                           ` Felipe Contreras
2010-10-09 12:17                             ` Felipe Contreras
2010-10-09 12:10                         ` Felipe Contreras
2010-10-09 12:10                           ` Felipe Contreras
2010-10-09 14:37                           ` Russell King - ARM Linux
2010-10-09 14:37                             ` Russell King - ARM Linux
2010-10-09 16:18                             ` Felipe Contreras
2010-10-09 16:18                               ` Felipe Contreras
2010-10-09 11:44                       ` Uwe Kleine-König
2010-10-09 11:44                         ` Uwe Kleine-König
2010-10-09 12:05                         ` Russell King - ARM Linux
2010-10-09 12:05                           ` Russell King - ARM Linux
2010-10-09 11:59                       ` Felipe Contreras
2010-10-09 11:59                         ` Felipe Contreras
2010-10-09 14:43                         ` Arnd Bergmann
2010-10-09 14:43                           ` Arnd Bergmann
2010-10-09 18:59                           ` Guennadi Liakhovetski
2010-10-09 18:59                             ` Guennadi Liakhovetski
2010-10-10  1:52                   ` Felipe Contreras
2010-10-10  1:52                     ` Felipe Contreras
2010-10-11  8:35                     ` Uwe Kleine-König
2010-10-11  8:35                       ` Uwe Kleine-König
2010-10-11  9:02                       ` Russell King - ARM Linux
2010-10-11  9:02                         ` Russell King - ARM Linux
2010-10-11  9:24                         ` Uwe Kleine-König
2010-10-11  9:24                           ` Uwe Kleine-König
2010-10-11 10:08                           ` Felipe Contreras
2010-10-11 10:08                             ` Felipe Contreras
2010-10-11 10:15                             ` Russell King - ARM Linux
2010-10-11 10:15                               ` Russell King - ARM Linux
2010-10-11 15:25                     ` Russell King - ARM Linux
2010-10-11 15:25                       ` Russell King - ARM Linux
2010-10-14 14:47                       ` Felipe Contreras
2010-10-14 14:47                         ` Felipe Contreras
2010-10-19  8:13                       ` Colin Cross
2010-10-19  8:13                         ` Colin Cross
2010-10-19 18:12                         ` Russell King - ARM Linux
2010-10-19 18:12                           ` Russell King - ARM Linux
2010-10-19 19:21                         ` Russell King - ARM Linux
2010-10-19 19:21                           ` Russell King - ARM Linux
2010-11-23  9:43                       ` [PATCH] ARM: mx3/pcm037: properly allocate memory for mx3-camera Uwe Kleine-König
2010-11-23 10:12                         ` Russell King - ARM Linux
2010-11-23 10:26                           ` Uwe Kleine-König
2010-11-23 14:08                             ` Alberto Panizzo
2010-11-23 14:17                               ` Uwe Kleine-König
2010-11-24  8:02                                 ` Uwe Kleine-König
2010-12-06  8:33                                   ` Uwe Kleine-König
2010-12-06 10:14                                     ` Alberto Panizzo
2010-12-06 10:26                                       ` Russell King - ARM Linux
2010-12-06 11:37                                         ` Alberto Panizzo
2010-12-06 11:46                                           ` Russell King - ARM Linux
2010-12-06 14:09                                             ` Alberto Panizzo
2010-12-06 14:34                                               ` Russell King - ARM Linux
2010-12-06 14:54                                                 ` Alberto Panizzo
2010-12-06 16:54                                                   ` Alberto Panizzo
2010-11-23 10:39                           ` About multi-line printk and the need (not) to repeat loglevel markers [Was: Re: [PATCH] ARM: mx3/pcm037: properly allocate memory for mx3-camera] Uwe Kleine-König
2010-11-23 10:39                             ` Uwe Kleine-König
2010-11-23 10:58                             ` Uwe Kleine-König
2010-11-23 10:58                               ` Uwe Kleine-König
2010-11-23 22:16                               ` Linus Torvalds
2010-11-23 22:16                                 ` Linus Torvalds
2010-11-23 22:33                                 ` Russell King - ARM Linux
2010-11-23 22:33                                   ` Russell King - ARM Linux
2010-11-23 23:23                                   ` Joe Perches
2010-11-23 23:23                                     ` Joe Perches
2010-11-24  0:57                                   ` [PATCH] md: Fix single printks with multiple KERN_<level>s Joe Perches
2010-11-24  5:16                                     ` Neil Brown
2010-11-24  8:17                                 ` About multi-line printk and the need (not) to repeat loglevel markers [Was: Re: [PATCH] ARM: mx3/pcm037: properly allocate memory for mx3-camera] Uwe Kleine-König
2010-11-24  8:17                                   ` Uwe Kleine-König
2010-11-24  8:56                                   ` [PATCH 0/6] add some KERN_CONT markers to continuation lines Uwe Kleine-König
2010-11-24  8:57                                     ` [PATCH 1/6] ARM: " Uwe Kleine-König
2010-11-24  8:57                                       ` Uwe Kleine-König
2010-11-24  8:57                                     ` [PATCH 2/6] block: " Uwe Kleine-König
2010-11-24  8:57                                     ` [PATCH 3/6] net: " Uwe Kleine-König
2010-11-28 18:48                                       ` David Miller
2010-11-24  8:57                                     ` [PATCH 4/6] init: " Uwe Kleine-König
2010-11-24  8:57                                     ` [PATCH 5/6] mm: " Uwe Kleine-König
2010-11-24  8:57                                       ` Uwe Kleine-König
2011-02-28 15:17                                       ` Uwe Kleine-König
2011-02-28 15:17                                         ` Uwe Kleine-König
2011-03-01 21:46                                         ` Linus Torvalds
2011-03-01 21:46                                           ` Linus Torvalds
2011-03-02  5:28                                           ` Joe Perches
2011-03-02  5:28                                             ` Joe Perches
2010-11-24  8:57                                     ` [PATCH 6/6] tty/vt: " Uwe Kleine-König
2011-02-28 15:16                                       ` Uwe Kleine-König
2011-02-28 15:39                                         ` Greg KH
2011-02-28 15:50                                           ` Uwe Kleine-König
2011-02-28 16:04                                             ` Greg KH
2011-03-01  3:18                                       ` Greg KH
2010-11-24  9:09                                   ` About multi-line printk and the need (not) to repeat loglevel markers [Was: Re: [PATCH] ARM: mx3/pcm037: properly allocate memory for mx3-camera] Michał Mirosław
2010-11-24  9:09                                     ` Michał Mirosław
2010-11-23 22:54                         ` [PATCH] ARM: mx3/pcm037: properly allocate memory for mx3-camera Guennadi Liakhovetski
2010-10-09  0:45             ` [PATCH] ARM: allow, but warn, when issuing ioremap() on RAM Felipe Contreras
2010-10-09  0:45               ` Felipe Contreras
2010-10-09  8:56               ` Russell King - ARM Linux
2010-10-09  8:56                 ` Russell King - ARM Linux
2010-10-08 23:19       ` Greg KH
2010-10-08 23:19         ` Greg KH
2010-10-09  3:36         ` Nicolas Pitre
2010-10-09  3:36           ` Nicolas Pitre
2010-10-09 10:00           ` Felipe Contreras
2010-10-09 10:00             ` Felipe Contreras
2010-10-09 17:38             ` Nicolas Pitre
2010-10-09 17:38               ` Nicolas Pitre
2010-10-09 20:16               ` Felipe Contreras
2010-10-09 20:16                 ` Felipe Contreras
2010-10-13 16:17             ` Woodruff, Richard
2010-10-13 16:17               ` Woodruff, Richard
2010-10-14 13:48               ` Felipe Contreras
2010-10-14 13:48                 ` Felipe Contreras
2010-10-14 15:29                 ` Woodruff, Richard
2010-10-14 15:29                   ` Woodruff, Richard
2010-10-16  2:36       ` Benjamin Herrenschmidt
2010-10-16  2:36         ` Benjamin Herrenschmidt
2010-10-17 13:05         ` Woodruff, Richard
2010-10-17 13:05           ` Woodruff, Richard
2010-10-17 23:17           ` Benjamin Herrenschmidt
2010-10-17 23:17             ` Benjamin Herrenschmidt
2010-10-08 19:58   ` Andrew Morton [this message]
2010-10-08 19:58     ` Andrew Morton
2010-10-09 13:52 ` Russell King - ARM Linux
2010-10-09 13:52   ` Russell King - ARM Linux
2010-10-09 16:07   ` Felipe Contreras
2010-10-09 16:07     ` Felipe Contreras
2010-10-09 16:45     ` Russell King - ARM Linux
2010-10-09 16:45       ` Russell King - ARM Linux
2010-10-09 19:25       ` Felipe Contreras
2010-10-09 19:25         ` Felipe Contreras
2010-10-10 14:23       ` Pedanekar, Hemant
2010-10-10 14:23         ` Pedanekar, Hemant
2010-10-11  9:26       ` Catalin Marinas
2010-10-11  9:26         ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101008125803.e5bc7306.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.