All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: matt mooney <mfmooney@gmail.com>
Cc: T Dent <tdent48227@gmail.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	sam@ravnborg.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 00/33] Staging: Fixed <module-objs> to <module>-y
Date: Fri, 08 Oct 2010 13:46:54 +0000	[thread overview]
Message-ID: <20101008134654.GA6600@kroah.com> (raw)
In-Reply-To: <AANLkTinynZj9bYFAyfRTF2uopmLe6Ls4YGdZPqCAJTpR@mail.gmail.com>

On Fri, Oct 08, 2010 at 12:16:35AM -0700, matt mooney wrote:
> On Thu, Oct 7, 2010 at 6:35 PM, T Dent <tdent48227@gmail.com> wrote:
> > I patch against the next-20101006 tree.
> >
> > The patch series replace use of <module>-objs with <module>-y in the
> > staging directory.
> 
> Commit messages are written in the present tense. You happen to be
> using two different tenses within the commit message, which is truly
> odd.  And why did you not split apart those atrocious statements with
> the infinite column width?

As Dan said, we understand what is happening here, and we do not have
grammer police for changelog comments, thank goodness.

> This patch series adds little benefit.  As Sam has suggested, a more
> general cleanup would be a better goal, and staging is an area that
> needs extra attention some of which has already been pointed out in
> other emails.

But these patches are all good to have, so I will be applying them,
please don't think they are unwanted at all.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: matt mooney <mfmooney@gmail.com>
Cc: T Dent <tdent48227@gmail.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	sam@ravnborg.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 00/33] Staging: Fixed <module-objs> to <module>-y
Date: Fri, 8 Oct 2010 06:46:54 -0700	[thread overview]
Message-ID: <20101008134654.GA6600@kroah.com> (raw)
In-Reply-To: <AANLkTinynZj9bYFAyfRTF2uopmLe6Ls4YGdZPqCAJTpR@mail.gmail.com>

On Fri, Oct 08, 2010 at 12:16:35AM -0700, matt mooney wrote:
> On Thu, Oct 7, 2010 at 6:35 PM, T Dent <tdent48227@gmail.com> wrote:
> > I patch against the next-20101006 tree.
> >
> > The patch series replace use of <module>-objs with <module>-y in the
> > staging directory.
> 
> Commit messages are written in the present tense. You happen to be
> using two different tenses within the commit message, which is truly
> odd.  And why did you not split apart those atrocious statements with
> the infinite column width?

As Dan said, we understand what is happening here, and we do not have
grammer police for changelog comments, thank goodness.

> This patch series adds little benefit.  As Sam has suggested, a more
> general cleanup would be a better goal, and staging is an area that
> needs extra attention some of which has already been pointed out in
> other emails.

But these patches are all good to have, so I will be applying them,
please don't think they are unwanted at all.

thanks,

greg k-h

  parent reply	other threads:[~2010-10-08 13:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08  1:35 [PATCH 00/33] Staging: Fixed <module-objs> to <module>-y T Dent
2010-10-08  1:35 ` T Dent
2010-10-08  7:16 ` matt mooney
2010-10-08  7:16   ` matt mooney
2010-10-08  8:39   ` T Dent
2010-10-08  8:39     ` T Dent
2010-10-08  8:55   ` Dan Carpenter
2010-10-08  8:55     ` Dan Carpenter
2010-10-08 18:05     ` matt mooney
2010-10-08 18:05       ` matt mooney
2010-10-08 13:46   ` Greg KH [this message]
2010-10-08 13:46     ` Greg KH
2010-10-08 18:09     ` matt mooney
2010-10-08 18:09       ` matt mooney
2010-10-08 18:33       ` Greg KH
2010-10-08 18:33         ` Greg KH
2010-10-08 20:02       ` Sam Ravnborg
2010-10-08 20:02         ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101008134654.GA6600@kroah.com \
    --to=greg@kroah.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfmooney@gmail.com \
    --cc=sam@ravnborg.org \
    --cc=tdent48227@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.