From: Matthew Wilcox <willy@linux.intel.com>
To: Brokhman Tatyana <tlinder@codeaurora.org>
Cc: Greg KH <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH v3] usb: usb3.0 ch9 definitions
Date: Fri, 8 Oct 2010 11:09:54 -0400 [thread overview]
Message-ID: <20101008150954.GA18531@linux.intel.com> (raw)
In-Reply-To: <d1949f2ff70c005def81a7dd6d12f2ca.squirrel@www.codeaurora.org>
On Fri, Oct 08, 2010 at 05:35:40AM -0700, Brokhman Tatyana wrote:
> >> + */
> >> +#define USB_DEVICE_U1_ENABLE 48 /* dev may initiate U1 transition */
> >> +#define USB_DEVICE_U2_ENABLE 49 /* dev may initiate U2 transition*/
> >> +#define USB_DEVICE_LTM_ENABLE 50 /* dev may send LTM*/
> >> +#define USB_INTRF_FUNC_SUSPEND 0 /* function suspend*/
Missing space before the '*/' on these three lines.
> > __le16? I'm guessing these fields haven't actually been used for
> > anything?
>
> Actually __bU2DevExitLat is not bitwise field so it can remain __u16. And
> no, their values have been used for nothing but testing the descriptor.
The __le16 isn't about bitfields. It's about the fact that the bytes
are stored in little-endian form.
next prev parent reply other threads:[~2010-10-08 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 18:34 [RFC/PATCH v3] usb: usb3.0 ch9 definitions Brokhman Tatyana
2010-10-07 21:09 ` Greg KH
2010-10-08 12:35 ` Brokhman Tatyana
2010-10-08 15:09 ` Matthew Wilcox [this message]
2010-10-07 22:47 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101008150954.GA18531@linux.intel.com \
--to=willy@linux.intel.com \
--cc=gregkh@suse.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=tlinder@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.