From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: "G, Manjunath Kondaiah" <manjugk@ti.com>,
"Shilimkar, Santosh" <santosh.shilimkar@ti.com>,
"Poddar, Sourav" <sourav.poddar@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Varadarajan, Charulatha" <charu@ti.com>
Subject: Re: [PATCH v4] ARM: Fix sparse warnings due to variables conflicts.
Date: Fri, 8 Oct 2010 10:36:15 -0700 [thread overview]
Message-ID: <20101008173615.GJ7558@atomide.com> (raw)
In-Reply-To: <4CAF014D.7000909@ti.com>
* Nishanth Menon <nm@ti.com> [101008 04:24]:
> Poddar, Sourav had written, on 10/08/2010 12:53 AM, the following:
> >Fix the sparse warnings generated due to conflicts in variables used in readl/writel.
> >
> >
> >drivers/net/smc91x.c:312:8: warning: symbol '__v' shadows an earlier one
> >drivers/net/smc91x.c:312:8: originally declared here
> >
> >With this change, about 200 sparse warnings are fixed.
> The commit message could be a little more detailed.
> see http://marc.info/?l=linux-omap&m=128648102511076&w=2
>
> also should $subject say ARM: io: fix namespace conflict
> to better reflect the fix? sparse warnings are just an indication IMHO
BTW, also dropping the "OMAP: Convert write/read functions to raw read/write".
That patch does not compute, and also ends up leaving files with
__raw_readw followed by writew..
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] ARM: Fix sparse warnings due to variables conflicts.
Date: Fri, 8 Oct 2010 10:36:15 -0700 [thread overview]
Message-ID: <20101008173615.GJ7558@atomide.com> (raw)
In-Reply-To: <4CAF014D.7000909@ti.com>
* Nishanth Menon <nm@ti.com> [101008 04:24]:
> Poddar, Sourav had written, on 10/08/2010 12:53 AM, the following:
> >Fix the sparse warnings generated due to conflicts in variables used in readl/writel.
> >
> >
> >drivers/net/smc91x.c:312:8: warning: symbol '__v' shadows an earlier one
> >drivers/net/smc91x.c:312:8: originally declared here
> >
> >With this change, about 200 sparse warnings are fixed.
> The commit message could be a little more detailed.
> see http://marc.info/?l=linux-omap&m=128648102511076&w=2
>
> also should $subject say ARM: io: fix namespace conflict
> to better reflect the fix? sparse warnings are just an indication IMHO
BTW, also dropping the "OMAP: Convert write/read functions to raw read/write".
That patch does not compute, and also ends up leaving files with
__raw_readw followed by writew..
Regards,
Tony
next prev parent reply other threads:[~2010-10-08 17:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1286517186-29934-1-git-send-email-sourav.poddar@ti.com>
2010-10-08 11:32 ` [PATCH v4] ARM: Fix sparse warnings due to variables conflicts Nishanth Menon
2010-10-08 11:32 ` Nishanth Menon
2010-10-08 17:36 ` Tony Lindgren [this message]
2010-10-08 17:36 ` Tony Lindgren
2010-10-11 3:44 ` G, Manjunath Kondaiah
2010-10-11 3:44 ` G, Manjunath Kondaiah
2010-10-08 23:22 ` Russell King - ARM Linux
2010-10-08 23:22 ` Russell King - ARM Linux
2010-10-11 5:45 ` Varadarajan, Charulatha
2010-10-11 5:45 ` Varadarajan, Charulatha
2010-10-14 4:36 ` Sourav Poddar
2010-10-14 4:36 ` Sourav Poddar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101008173615.GJ7558@atomide.com \
--to=tony@atomide.com \
--cc=charu@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=nm@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.