From: Valerie Aurora <vaurora@redhat.com>
To: Frank Mayhar <fmayhar@google.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, mrubin@google.com
Subject: Re: Results of my VFS scaling evaluation.
Date: Fri, 8 Oct 2010 20:38:42 -0400 [thread overview]
Message-ID: <20101009003842.GH30846@shell> (raw)
In-Reply-To: <1286580739.3153.57.camel@bobble.smo.corp.google.com>
On Fri, Oct 08, 2010 at 04:32:19PM -0700, Frank Mayhar wrote:
>
> Before going into details of the test results, however, I must say that
> the most striking thing about Nick's work how stable it is. In all of
:D
> the work I've been doing, all the kernels I've built and run and all the
> tests I've run, I've run into no hangs and only one crash, that in an
> area that we happen to stress very heavily, for which I posted a patch,
> available at
> http://www.kerneltrap.org/mailarchive/linux-fsdevel/2010/9/27/6886943
> The crash involved the fact that we use cgroups very heavily, and there
> was an oversight in the new d_set_d_op() routine that failed to clear
> flags before it set them.
I honestly can't stand the d_set_d_op() patch (testing flags instead
of d_op->op) because it obfuscates the code in such a way that leads
directly to this kind of bug. I don't suppose you could test the
performance effect of that specific patch and see how big of a
difference it makes?
-VAL
WARNING: multiple messages have this Message-ID (diff)
From: Valerie Aurora <vaurora@redhat.com>
To: Frank Mayhar <fmayhar@google.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, mrubin@google.com
Subject: Re: Results of my VFS scaling evaluation.
Date: Fri, 8 Oct 2010 20:38:42 -0400 [thread overview]
Message-ID: <20101009003842.GH30846@shell> (raw)
In-Reply-To: <1286580739.3153.57.camel@bobble.smo.corp.google.com>
On Fri, Oct 08, 2010 at 04:32:19PM -0700, Frank Mayhar wrote:
>
> Before going into details of the test results, however, I must say that
> the most striking thing about Nick's work how stable it is. In all of
:D
> the work I've been doing, all the kernels I've built and run and all the
> tests I've run, I've run into no hangs and only one crash, that in an
> area that we happen to stress very heavily, for which I posted a patch,
> available at
> http://www.kerneltrap.org/mailarchive/linux-fsdevel/2010/9/27/6886943
> The crash involved the fact that we use cgroups very heavily, and there
> was an oversight in the new d_set_d_op() routine that failed to clear
> flags before it set them.
I honestly can't stand the d_set_d_op() patch (testing flags instead
of d_op->op) because it obfuscates the code in such a way that leads
directly to this kind of bug. I don't suppose you could test the
performance effect of that specific patch and see how big of a
difference it makes?
-VAL
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-09 0:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 23:32 Results of my VFS scaling evaluation Frank Mayhar
2010-10-08 23:32 ` Frank Mayhar
2010-10-09 0:33 ` Frank Mayhar
2010-10-09 0:38 ` Valerie Aurora [this message]
2010-10-09 0:38 ` Valerie Aurora
2010-10-11 18:47 ` Frank Mayhar
2010-10-11 18:47 ` Frank Mayhar
2011-01-13 11:13 ` Nick Piggin
2011-01-13 11:13 ` Nick Piggin
2010-10-09 3:16 ` Dave Chinner
2010-10-09 3:16 ` Dave Chinner
2010-10-10 6:54 ` Andi Kleen
2010-10-10 6:54 ` Andi Kleen
2010-10-10 7:37 ` Christoph Hellwig
2010-10-10 7:37 ` Christoph Hellwig
2010-10-10 8:20 ` Andi Kleen
2010-10-10 8:37 ` Christoph Hellwig
2010-10-10 8:37 ` Christoph Hellwig
2010-10-10 12:03 ` Andi Kleen
2010-10-10 12:03 ` Andi Kleen
2010-10-10 23:50 ` Dave Chinner
2010-10-10 23:31 ` Dave Chinner
2010-10-10 6:50 ` Andi Kleen
2010-10-10 6:50 ` Andi Kleen
2010-10-19 21:59 ` Results of my VFS scaling evaluation, redux Frank Mayhar
2010-10-19 21:59 ` Frank Mayhar
2010-10-19 22:03 ` Frank Mayhar
2010-10-19 22:03 ` Frank Mayhar
2010-10-22 19:03 ` VFS scaling evaluation results, redux Frank Mayhar
2010-10-22 19:03 ` Frank Mayhar
2010-10-23 0:00 ` Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101009003842.GH30846@shell \
--to=vaurora@redhat.com \
--cc=fmayhar@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mrubin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.