All of lore.kernel.org
 help / color / mirror / Atom feed
From: pacman@kosh.dhis.org
To: linuxppc-dev@lists.ozlabs.org
Subject: Pegasos i8042 broken again
Date: Sat, 9 Oct 2010 20:37:55 -0500 (GMT+5)	[thread overview]
Message-ID: <20101010013755.1697.qmail@kosh.dhis.org> (raw)

Pegasos has no keyboard again. I blame commit
540c6c392f01887dcc96bef0a41e63e6c1334f01, which tries to find i8042 IRQs in
the device-tree but doesn't fall back to the old hardcoded 1 and 12 in all
failure cases.

Specifically, the case where the device-tree contains nothing matching
pnpPNP,303 or pnpPNP,f03 doesn't seem to be handled well. It sort of falls
through to the old code, but leaves the IRQs set to 0.

The last time something like this happened, I submitted a patch:
http://lists.ozlabs.org/pipermail/linuxppc-dev/2007-July/039988.html
which got committed, but afterward I was scolded for working around a bug
instead of fixing it in nvramrc.

This time I just won't send my workaround patch, at least until it's decided
that the kernel should be made to understand the device-tree as is.

If it's decided instead that the firmware should be patched... well I just
don't feel comfortable inventing my own patch for nvramrc, since it's written
in a language I don't know and presumably could brick the machine if I get it
wrong. Also I'm not even sure what the kernel is expecting to find there.

-- 
Alan Curry

             reply	other threads:[~2010-10-10  1:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-10  1:37 pacman [this message]
2010-10-10  7:35 ` Pegasos i8042 broken again Benjamin Herrenschmidt
2010-10-10 12:26   ` Gerhard Pircher
2010-10-10 17:32   ` pacman
2011-04-04 22:26   ` Gabriel Paubert
2011-04-04 22:28     ` Benjamin Herrenschmidt
2011-04-04 22:49       ` Gabriel Paubert
2011-04-04 23:02     ` pacman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101010013755.1697.qmail@kosh.dhis.org \
    --to=pacman@kosh.dhis.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.