From: Dan Carpenter <error27@gmail.com>
To: Geoff Levand <geoff@infradead.org>
Cc: cbe-oss-dev@lists.ozlabs.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jens Axboe <jaxboe@fusionio.com>,
kernel-janitors@vger.kernel.org,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linuxppc-dev@lists.ozlabs.org
Subject: [patch] ps3disk: passing wrong variable to bvec_kunmap_irq()
Date: Mon, 11 Oct 2010 19:13:35 +0000 [thread overview]
Message-ID: <20101011191335.GH5851@bicker> (raw)
This should pass "buf" to bvec_kunmap_irq() instead of "bv". The api is
like kmap_atomic() instead of kmap().
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/block/ps3disk.c b/drivers/block/ps3disk.c
index e9da874..03688c2 100644
--- a/drivers/block/ps3disk.c
+++ b/drivers/block/ps3disk.c
@@ -113,7 +113,7 @@ static void ps3disk_scatter_gather(struct ps3_storage_device *dev,
memcpy(buf, dev->bounce_buf+offset, size);
offset += size;
flush_kernel_dcache_page(bvec->bv_page);
- bvec_kunmap_irq(bvec, &flags);
+ bvec_kunmap_irq(buf, &flags);
i++;
}
}
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Geoff Levand <geoff@infradead.org>
Cc: cbe-oss-dev@lists.ozlabs.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jens Axboe <jaxboe@fusionio.com>,
kernel-janitors@vger.kernel.org,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linuxppc-dev@lists.ozlabs.org
Subject: [patch] ps3disk: passing wrong variable to bvec_kunmap_irq()
Date: Mon, 11 Oct 2010 21:13:35 +0200 [thread overview]
Message-ID: <20101011191335.GH5851@bicker> (raw)
This should pass "buf" to bvec_kunmap_irq() instead of "bv". The api is
like kmap_atomic() instead of kmap().
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/block/ps3disk.c b/drivers/block/ps3disk.c
index e9da874..03688c2 100644
--- a/drivers/block/ps3disk.c
+++ b/drivers/block/ps3disk.c
@@ -113,7 +113,7 @@ static void ps3disk_scatter_gather(struct ps3_storage_device *dev,
memcpy(buf, dev->bounce_buf+offset, size);
offset += size;
flush_kernel_dcache_page(bvec->bv_page);
- bvec_kunmap_irq(bvec, &flags);
+ bvec_kunmap_irq(buf, &flags);
i++;
}
}
next reply other threads:[~2010-10-11 19:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 19:13 Dan Carpenter [this message]
2010-10-11 19:13 ` [patch] ps3disk: passing wrong variable to bvec_kunmap_irq() Dan Carpenter
2010-10-11 19:42 ` Jens Axboe
2010-10-11 19:42 ` Jens Axboe
2010-10-16 19:39 ` Geert Uytterhoeven
2010-10-16 19:39 ` Geert Uytterhoeven
2010-10-17 6:49 ` Jens Axboe
2010-10-17 6:49 ` Jens Axboe
2010-10-17 11:36 ` Geert Uytterhoeven
2010-10-17 11:36 ` Geert Uytterhoeven
2010-10-12 16:01 ` Geoff Levand
2010-10-12 16:01 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011191335.GH5851@bicker \
--to=error27@gmail.com \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=geoff@infradead.org \
--cc=jaxboe@fusionio.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.