From: Chris Ball <cjb@laptop.org>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: "Eric Bénard" <eric@eukrea.com>, linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc_rescan: reduce verbosity
Date: Tue, 12 Oct 2010 03:12:36 +0100 [thread overview]
Message-ID: <20101012021236.GA8179@void.printf.net> (raw)
In-Reply-To: <alpine.LFD.2.00.1010112007250.2764@xanadu.home>
Hi,
On Mon, Oct 11, 2010 at 09:50:46PM -0400, Nicolas Pitre wrote:
> On Mon, 11 Oct 2010, Eric Bénard wrote:
> > since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan
> > includes a pr_info which prints 4 lines each second for hosts configured
> > with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc.
> > This patch increase log level to debug (but maybe the right solution
> > would be to remove this log).
>
> Indeed. Flooding the log with debug messages is not much better.
Other options include:
(a) Turn the message into a DBG(). (CONFIG_MMC_DEBUG=y)
(b) Turn the message into a DBG(), predicated on !MMC_CAP_NEEDS_POLL.
(c) Remove the message.
Any thoughts? I'll go with (c) unless we agree on a better idea.
Thanks,
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-10-12 2:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 21:48 [PATCH] mmc_rescan: reduce verbosity Eric Bénard
2010-10-12 1:50 ` Nicolas Pitre
2010-10-12 2:12 ` Chris Ball [this message]
2010-10-12 3:00 ` Nicolas Pitre
2010-10-12 6:00 ` Wolfram Sang
2010-10-12 7:29 ` [PATCH v2] " Eric Bénard
2010-10-12 8:41 ` Wolfram Sang
2010-10-12 15:08 ` Chris Ball
2010-10-12 20:51 ` Hein_Tibosch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101012021236.GA8179@void.printf.net \
--to=cjb@laptop.org \
--cc=eric@eukrea.com \
--cc=linux-mmc@vger.kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.