From: Chris Ball <cjb@laptop.org>
To: "Eric Bénard" <eric@eukrea.com>
Cc: linux-mmc@vger.kernel.org, Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: [PATCH v2] mmc_rescan: reduce verbosity
Date: Tue, 12 Oct 2010 16:08:50 +0100 [thread overview]
Message-ID: <20101012150850.GA18009@void.printf.net> (raw)
In-Reply-To: <1286868577-7729-1-git-send-email-eric@eukrea.com>
Hi Eric,
On Tue, Oct 12, 2010 at 09:29:37AM +0200, Eric Bénard wrote:
> since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan
> includes a pr_info which prints 4 lines each second for hosts configured
> with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc.
> This patch enable the log only if CONFIG_MMC_DEBUG is selected.
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
> v2 : enable log only if CONFIG_MMC_DEBUG is selected
> v1 : use pr_debug instead of pr_info
> drivers/mmc/core/core.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index c94565d..cda9d29 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -1482,9 +1482,10 @@ void mmc_rescan(struct work_struct *work)
> mmc_release_host(host);
> goto out;
> }
> +#ifdef CONFIG_MMC_DEBUG
> pr_info("%s: %s: trying to init card at %u Hz\n",
> mmc_hostname(host), __func__, host->f_init);
> -
> +#endif
> mmc_power_up(host);
> sdio_reset(host);
> mmc_go_idle(host);
> --
Thanks, applied to mmc-next.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-10-12 15:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 21:48 [PATCH] mmc_rescan: reduce verbosity Eric Bénard
2010-10-12 1:50 ` Nicolas Pitre
2010-10-12 2:12 ` Chris Ball
2010-10-12 3:00 ` Nicolas Pitre
2010-10-12 6:00 ` Wolfram Sang
2010-10-12 7:29 ` [PATCH v2] " Eric Bénard
2010-10-12 8:41 ` Wolfram Sang
2010-10-12 15:08 ` Chris Ball [this message]
2010-10-12 20:51 ` Hein_Tibosch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101012150850.GA18009@void.printf.net \
--to=cjb@laptop.org \
--cc=eric@eukrea.com \
--cc=linux-mmc@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.