From: Andi Kleen <andi@firstfloor.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
fengguang.wu@intel.com, akpm@linux-foundation.org
Subject: Re: RFC: Implement hwpoison on free for soft offlining
Date: Tue, 12 Oct 2010 15:14:14 +0200 [thread overview]
Message-ID: <20101012131414.GC20436@basil.fritz.box> (raw)
In-Reply-To: <20101012181439.ADA9.A69D9226@jp.fujitsu.com>
> To me, it's no problem if this keep 64bit only. IOW, I only dislike to
> add 32bit page flags.
>
> Yeah, memory corruption is very crap and i think your effort has a lot
> of worth :)
Thanks.
>
>
> offtopic, I don't think CONFIG_MEMORY_FAILURE and CONFIG_HWPOISON_ON_FREE
> are symmetric nor easy understandable. can you please consider naming change?
> (example, CONFIG_HWPOISON/CONFIG_HWPOISON_ON_FREE,
> CONFIG_MEMORY_FAILURE/CONFIG_MEMORY_FAILURE_SOFT_OFFLINE)
memory-failure was the old name before hwpoison as a term was invented
by Andrew.
In theory it would make sense to rename everything to "hwpoison" now.
But I decided so far the disadvantages from breaking user configurations
and the impact from renaming files far outweight the small benefits
in clarity.
So right now I prefer to keep the status quo, but name everything
new hwpoison.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
fengguang.wu@intel.com, akpm@linux-foundation.org
Subject: Re: RFC: Implement hwpoison on free for soft offlining
Date: Tue, 12 Oct 2010 15:14:14 +0200 [thread overview]
Message-ID: <20101012131414.GC20436@basil.fritz.box> (raw)
In-Reply-To: <20101012181439.ADA9.A69D9226@jp.fujitsu.com>
> To me, it's no problem if this keep 64bit only. IOW, I only dislike to
> add 32bit page flags.
>
> Yeah, memory corruption is very crap and i think your effort has a lot
> of worth :)
Thanks.
>
>
> offtopic, I don't think CONFIG_MEMORY_FAILURE and CONFIG_HWPOISON_ON_FREE
> are symmetric nor easy understandable. can you please consider naming change?
> (example, CONFIG_HWPOISON/CONFIG_HWPOISON_ON_FREE,
> CONFIG_MEMORY_FAILURE/CONFIG_MEMORY_FAILURE_SOFT_OFFLINE)
memory-failure was the old name before hwpoison as a term was invented
by Andrew.
In theory it would make sense to rename everything to "hwpoison" now.
But I decided so far the disadvantages from breaking user configurations
and the impact from renaming files far outweight the small benefits
in clarity.
So right now I prefer to keep the status quo, but name everything
new hwpoison.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-10-12 13:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 22:09 RFC: Implement hwpoison on free for soft offlining Andi Kleen
2010-10-06 22:09 ` Andi Kleen
2010-10-06 22:09 ` [PATCH] HWPOISON: Implement hwpoison-on-free " Andi Kleen
2010-10-06 22:09 ` Andi Kleen
2010-10-12 12:26 ` Wu Fengguang
2010-10-12 12:26 ` Wu Fengguang
2010-10-12 12:37 ` Andi Kleen
2010-10-12 12:37 ` Andi Kleen
2010-10-12 12:41 ` Wu Fengguang
2010-10-12 12:41 ` Wu Fengguang
2010-10-12 8:11 ` RFC: Implement hwpoison on free " Andi Kleen
2010-10-12 8:11 ` Andi Kleen
2010-10-12 9:20 ` KOSAKI Motohiro
2010-10-12 9:20 ` KOSAKI Motohiro
2010-10-12 13:14 ` Andi Kleen [this message]
2010-10-12 13:14 ` Andi Kleen
2010-10-13 0:15 ` KOSAKI Motohiro
2010-10-13 0:15 ` KOSAKI Motohiro
2010-10-15 8:50 ` Andi Kleen
2010-10-15 8:50 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101012131414.GC20436@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.