All of lore.kernel.org
 help / color / mirror / Atom feed
From: "M. Mohan Kumar" <mohan@in.ibm.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>,
	Markus Armbruster <armbru@redhat.com>,
	Adam Litke <agl@us.ibm.com>
Subject: Re: [Qemu-devel] virtio_cleanup() missing in virtio-{blk, balloon, 9p}-pci
Date: Tue, 12 Oct 2010 17:29:55 +0530	[thread overview]
Message-ID: <201010121729.55760.mohan@in.ibm.com> (raw)
In-Reply-To: <m3lj65122k.fsf@blackfin.pond.sub.org>

> Pattern:
> 
> FOO's PCIDeviceInfo method exit is virtio_FOO_exit_pci(), which calls
> virtio_FOO_exit() and virtio_exit_pci().
> 
> virtio_{net,serial}_exit() call virtio_cleanup().
> 
> virtio_blk_exit() doesn't.  Why?
> 
> virtio-balloon-pci uses virtio_exit_pci() as exit method.  No
> virtio_cleanup()?
> 
> virtio-9p-pci doesn't have an exit method.  Doesn't feel right.

9p does not support hot-plug now. We will implement virtio_9p_exit when we are 
adding support for hot-plug

  parent reply	other threads:[~2010-10-12 12:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-11 10:00 [Qemu-devel] virtio_cleanup() missing in virtio-{blk, balloon, 9p}-pci Markus Armbruster
2010-10-11 10:19 ` [Qemu-devel] " Kevin Wolf
2010-10-12 11:59 ` M. Mohan Kumar [this message]
2010-10-12 12:18   ` [Qemu-devel] " Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201010121729.55760.mohan@in.ibm.com \
    --to=mohan@in.ibm.com \
    --cc=agl@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=jvrao@linux.vnet.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.