[PATCH] distutils-common-base.bbclass: Prepend STAGING_LIBDIR to linker library search path.

[PATCH] distutils-common-base.bbclass: Prepend STAGING_LIBDIR to linker library search path.

[Khem Raj]

* This was done generically in bitbake.conf this should be done on
  demand and distutils based recipes seem to need it. So we define it
  here.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 classes/distutils-common-base.bbclass |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/classes/distutils-common-base.bbclass b/classes/distutils-common-base.bbclass
index f66a5cd..b6caf24 100644
--- a/classes/distutils-common-base.bbclass
+++ b/classes/distutils-common-base.bbclass
@@ -4,6 +4,8 @@ EXTRA_OEMAKE = ""
 
 export STAGING_INCDIR
 export STAGING_LIBDIR
+# libtool 2.4 does not export with LDFLAGS but distutils need it
+LDFLAGS_prepend = "-L${STAGING_LIBDIR} "
 
 PACKAGES = "${PN}-dev ${PN}-dbg ${PN}-doc ${PN}"
 
-- 
1.7.1

Re: [PATCH] distutils-common-base.bbclass: Prepend STAGING_LIBDIR to linker library search path.

[Frans Meulenbroeks]

2010/10/13 Khem Raj <raj.khem@gmail.com>:
> * This was done generically in bitbake.conf this should be done on
>  demand and distutils based recipes seem to need it. So we define it
>  here.

Based on your commit message I expected a change in bitbake.conf too.
Am I mssing something here?

Frans

>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  classes/distutils-common-base.bbclass |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/classes/distutils-common-base.bbclass b/classes/distutils-common-base.bbclass
> index f66a5cd..b6caf24 100644
> --- a/classes/distutils-common-base.bbclass
> +++ b/classes/distutils-common-base.bbclass
> @@ -4,6 +4,8 @@ EXTRA_OEMAKE = ""
>
>  export STAGING_INCDIR
>  export STAGING_LIBDIR
> +# libtool 2.4 does not export with LDFLAGS but distutils need it
> +LDFLAGS_prepend = "-L${STAGING_LIBDIR} "
>
>  PACKAGES = "${PN}-dev ${PN}-dbg ${PN}-doc ${PN}"
>
> --
> 1.7.1
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH] distutils-common-base.bbclass: Prepend STAGING_LIBDIR to linker library search path.

[Martin Jansa]

On Wed, Oct 13, 2010 at 08:59:40AM +0200, Frans Meulenbroeks wrote:
> 2010/10/13 Khem Raj <raj.khem@gmail.com>:
> > * This was done generically in bitbake.conf this should be done on
> >  demand and distutils based recipes seem to need it. So we define it
> >  here.
> 
> Based on your commit message I expected a change in bitbake.conf too.
> Am I mssing something here?

That changes was already commited and it's used only for
LIBTOOL_HAS_SYSROOT.

This is fixing build of all python recipes using distutils.

Acked-by: Martin Jansa <Martin.Jansa@gmail.com>

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

Re: [PATCH] distutils-common-base.bbclass: Prepend STAGING_LIBDIR to linker library search path.

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 13-10-10 09:12, Martin Jansa wrote:
> On Wed, Oct 13, 2010 at 08:59:40AM +0200, Frans Meulenbroeks wrote:
>> 2010/10/13 Khem Raj <raj.khem@gmail.com>:
>>> * This was done generically in bitbake.conf this should be done on
>>>  demand and distutils based recipes seem to need it. So we define it
>>>  here.
>>
>> Based on your commit message I expected a change in bitbake.conf too.
>> Am I mssing something here?
> 
> That changes was already commited and it's used only for
> LIBTOOL_HAS_SYSROOT.
> 
> This is fixing build of all python recipes using distutils.

Like python-pycairo :)

> Acked-by: Martin Jansa <Martin.Jansa@gmail.com>

Acked-by: Koen Kooi <k-kooi@ti.com>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMtV7VMkyGM64RGpERAskFAJsGk14QZJ3gKvF31B/RGuj+m+mfmwCgkwXv
XIgRylC4P5QyccgD+SdY/Do=
=vkru
-----END PGP SIGNATURE-----

Re: [PATCH] distutils-common-base.bbclass: Prepend STAGING_LIBDIR to linker library search path.

[Frans Meulenbroeks]

2010/10/13 Martin Jansa <martin.jansa@gmail.com>:
> On Wed, Oct 13, 2010 at 08:59:40AM +0200, Frans Meulenbroeks wrote:
>> 2010/10/13 Khem Raj <raj.khem@gmail.com>:
>> > * This was done generically in bitbake.conf this should be done on
>> >  demand and distutils based recipes seem to need it. So we define it
>> >  here.
>>
>> Based on your commit message I expected a change in bitbake.conf too.
>> Am I mssing something here?
>
> That changes was already commited and it's used only for
> LIBTOOL_HAS_SYSROOT.
>
> This is fixing build of all python recipes using distutils.
>
> Acked-by: Martin Jansa <Martin.Jansa@gmail.com>

Ah ok, thanks for the info.
guess the commit message could have been a teeny weeny bit clearer.
it now to me suggested a code/functionality move from bitbake.conf to
dustutils-common-base.bbclass.

Frans.