* [PATCH] staging: intel_sst: use signed int for error codes
@ 2010-10-10 17:28 ` Vasiliy Kulikov
0 siblings, 0 replies; 4+ messages in thread
From: Vasiliy Kulikov @ 2010-10-10 17:28 UTC (permalink / raw)
To: kernel-janitors
Cc: Greg Kroah-Hartman, Harsha Priya, Vinod Koul, Alan Cox, devel,
linux-kernel
As retval stores error code, it should be signed int.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
Compile tested.
.../staging/intel_sst/intel_sst_app_interface.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/intel_sst/intel_sst_app_interface.c b/drivers/staging/intel_sst/intel_sst_app_interface.c
index 9f31dc5..baf0ddc 100644
--- a/drivers/staging/intel_sst/intel_sst_app_interface.c
+++ b/drivers/staging/intel_sst/intel_sst_app_interface.c
@@ -98,7 +98,7 @@ static int intel_sst_check_device(void)
*/
int intel_sst_open(struct inode *i_node, struct file *file_ptr)
{
- unsigned int retval = intel_sst_check_device();
+ int retval = intel_sst_check_device();
if (retval)
return retval;
@@ -137,7 +137,7 @@ int intel_sst_open(struct inode *i_node, struct file *file_ptr)
*/
int intel_sst_open_cntrl(struct inode *i_node, struct file *file_ptr)
{
- unsigned int retval = intel_sst_check_device();
+ int retval = intel_sst_check_device();
if (retval)
return retval;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] staging: intel_sst: use signed int for error codes
@ 2010-10-10 17:28 ` Vasiliy Kulikov
0 siblings, 0 replies; 4+ messages in thread
From: Vasiliy Kulikov @ 2010-10-10 17:28 UTC (permalink / raw)
To: kernel-janitors
Cc: Greg Kroah-Hartman, Harsha Priya, Vinod Koul, Alan Cox, devel,
linux-kernel
As retval stores error code, it should be signed int.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
Compile tested.
.../staging/intel_sst/intel_sst_app_interface.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/intel_sst/intel_sst_app_interface.c b/drivers/staging/intel_sst/intel_sst_app_interface.c
index 9f31dc5..baf0ddc 100644
--- a/drivers/staging/intel_sst/intel_sst_app_interface.c
+++ b/drivers/staging/intel_sst/intel_sst_app_interface.c
@@ -98,7 +98,7 @@ static int intel_sst_check_device(void)
*/
int intel_sst_open(struct inode *i_node, struct file *file_ptr)
{
- unsigned int retval = intel_sst_check_device();
+ int retval = intel_sst_check_device();
if (retval)
return retval;
@@ -137,7 +137,7 @@ int intel_sst_open(struct inode *i_node, struct file *file_ptr)
*/
int intel_sst_open_cntrl(struct inode *i_node, struct file *file_ptr)
{
- unsigned int retval = intel_sst_check_device();
+ int retval = intel_sst_check_device();
if (retval)
return retval;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: intel_sst: use signed int for error codes
2010-10-10 17:28 ` Vasiliy Kulikov
@ 2010-10-13 9:20 ` Alan Cox
-1 siblings, 0 replies; 4+ messages in thread
From: Alan Cox @ 2010-10-13 9:20 UTC (permalink / raw)
To: Vasiliy Kulikov
Cc: kernel-janitors, Greg Kroah-Hartman, Harsha Priya, Vinod Koul,
devel, linux-kernel
On Sun, 10 Oct 2010 21:28:43 +0400
Vasiliy Kulikov <segooon@gmail.com> wrote:
> As retval stores error code, it should be signed int.
>
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-13 10:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-10 17:28 [PATCH] staging: intel_sst: use signed int for error codes Vasiliy Kulikov
2010-10-10 17:28 ` Vasiliy Kulikov
2010-10-13 9:20 ` Alan Cox
2010-10-13 9:20 ` Alan Cox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.