* [patch] gianfar: fix double lock typo
@ 2010-10-13 19:19 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-10-13 19:19 UTC (permalink / raw)
To: Sandeep Gopalpet; +Cc: David S. Miller, netdev, kernel-janitors
This should be a _restore() instead of a _save().
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/gianfar_ethtool.c b/drivers/net/gianfar_ethtool.c
index ae8e5d3..5c566eb 100644
--- a/drivers/net/gianfar_ethtool.c
+++ b/drivers/net/gianfar_ethtool.c
@@ -538,7 +538,7 @@ static int gfar_set_rx_csum(struct net_device *dev, uint32_t data)
unlock_tx_qs(priv);
unlock_rx_qs(priv);
- local_irq_save(flags);
+ local_irq_restore(flags);
for (i = 0; i < priv->num_rx_queues; i++)
gfar_clean_rx_ring(priv->rx_queue[i],
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] gianfar: fix double lock typo
@ 2010-10-13 19:19 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-10-13 19:19 UTC (permalink / raw)
To: Sandeep Gopalpet; +Cc: David S. Miller, netdev, kernel-janitors
This should be a _restore() instead of a _save().
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/gianfar_ethtool.c b/drivers/net/gianfar_ethtool.c
index ae8e5d3..5c566eb 100644
--- a/drivers/net/gianfar_ethtool.c
+++ b/drivers/net/gianfar_ethtool.c
@@ -538,7 +538,7 @@ static int gfar_set_rx_csum(struct net_device *dev, uint32_t data)
unlock_tx_qs(priv);
unlock_rx_qs(priv);
- local_irq_save(flags);
+ local_irq_restore(flags);
for (i = 0; i < priv->num_rx_queues; i++)
gfar_clean_rx_ring(priv->rx_queue[i],
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] gianfar: fix double lock typo
2010-10-13 19:19 ` Dan Carpenter
@ 2010-10-18 8:55 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-10-18 8:55 UTC (permalink / raw)
To: error27; +Cc: Sandeep.Kumar, netdev, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Wed, 13 Oct 2010 21:19:55 +0200
> This should be a _restore() instead of a _save().
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Good find, applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-18 8:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-13 19:19 [patch] gianfar: fix double lock typo Dan Carpenter
2010-10-13 19:19 ` Dan Carpenter
2010-10-18 8:55 ` David Miller
2010-10-18 8:55 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.