Re: [PATCH -next] tifm: fix kconfig dependencies

[Chris Ball <cjb@laptop.org>]

Hi,

On Wed, Oct 13, 2010 at 06:07:29PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix kconfig dependency warning to satisfy dependencies:
> 
> warning: (MMC_TIFM_SD && MMC && EXPERIMENTAL && PCI || MEMSTICK_TIFM_MS && MEMSTICK && EXPERIMENTAL && PCI) selects TIFM_CORE which has unmet direct dependencies (MISC_DEVICES && EXPERIMENTAL && PCI)
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  drivers/memstick/host/Kconfig |    1 +
>  drivers/mmc/host/Kconfig      |    1 +
>  2 files changed, 2 insertions(+)
> 
> --- linux-next-20101013.orig/drivers/memstick/host/Kconfig
> +++ linux-next-20101013/drivers/memstick/host/Kconfig
> @@ -7,6 +7,7 @@ comment "MemoryStick Host Controller Dri
>  config MEMSTICK_TIFM_MS
>  	tristate "TI Flash Media MemoryStick Interface support  (EXPERIMENTAL)"
>  	depends on EXPERIMENTAL && PCI
> +	select MISC_DEVICES
>  	select TIFM_CORE
>  	help
>  	  Say Y here if you want to be able to access MemoryStick cards with
> --- linux-next-20101013.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20101013/drivers/mmc/host/Kconfig
> @@ -277,6 +277,7 @@ config MMC_MXC
>  config MMC_TIFM_SD
>  	tristate "TI Flash Media MMC/SD Interface support  (EXPERIMENTAL)"
>  	depends on EXPERIMENTAL && PCI
> +	select MISC_DEVICES
>  	select TIFM_CORE
>  	help
>  	  Say Y here if you want to be able to access MMC/SD cards with

Acked-by: Chris Ball <cjb@laptop.org>
for the mmc hunk.

Andrew, perhaps you should take this to keep the mmc/memstick trees
from modifying files outside of their namespace? (Or we could just
ask Randy to split up the patch; whatever is preferred.)

Thanks,

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child