* [PATCH -next] tifm: fix kconfig dependencies
@ 2010-10-14 1:07 Randy Dunlap
2010-10-14 4:35 ` Chris Ball
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2010-10-14 1:07 UTC (permalink / raw)
To: lkml; +Cc: Chris Ball, Alex Dubov, akpm
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix kconfig dependency warning to satisfy dependencies:
warning: (MMC_TIFM_SD && MMC && EXPERIMENTAL && PCI || MEMSTICK_TIFM_MS && MEMSTICK && EXPERIMENTAL && PCI) selects TIFM_CORE which has unmet direct dependencies (MISC_DEVICES && EXPERIMENTAL && PCI)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/memstick/host/Kconfig | 1 +
drivers/mmc/host/Kconfig | 1 +
2 files changed, 2 insertions(+)
--- linux-next-20101013.orig/drivers/memstick/host/Kconfig
+++ linux-next-20101013/drivers/memstick/host/Kconfig
@@ -7,6 +7,7 @@ comment "MemoryStick Host Controller Dri
config MEMSTICK_TIFM_MS
tristate "TI Flash Media MemoryStick Interface support (EXPERIMENTAL)"
depends on EXPERIMENTAL && PCI
+ select MISC_DEVICES
select TIFM_CORE
help
Say Y here if you want to be able to access MemoryStick cards with
--- linux-next-20101013.orig/drivers/mmc/host/Kconfig
+++ linux-next-20101013/drivers/mmc/host/Kconfig
@@ -277,6 +277,7 @@ config MMC_MXC
config MMC_TIFM_SD
tristate "TI Flash Media MMC/SD Interface support (EXPERIMENTAL)"
depends on EXPERIMENTAL && PCI
+ select MISC_DEVICES
select TIFM_CORE
help
Say Y here if you want to be able to access MMC/SD cards with
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] tifm: fix kconfig dependencies
2010-10-14 1:07 [PATCH -next] tifm: fix kconfig dependencies Randy Dunlap
@ 2010-10-14 4:35 ` Chris Ball
0 siblings, 0 replies; 2+ messages in thread
From: Chris Ball @ 2010-10-14 4:35 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, Alex Dubov, akpm
Hi,
On Wed, Oct 13, 2010 at 06:07:29PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix kconfig dependency warning to satisfy dependencies:
>
> warning: (MMC_TIFM_SD && MMC && EXPERIMENTAL && PCI || MEMSTICK_TIFM_MS && MEMSTICK && EXPERIMENTAL && PCI) selects TIFM_CORE which has unmet direct dependencies (MISC_DEVICES && EXPERIMENTAL && PCI)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/memstick/host/Kconfig | 1 +
> drivers/mmc/host/Kconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> --- linux-next-20101013.orig/drivers/memstick/host/Kconfig
> +++ linux-next-20101013/drivers/memstick/host/Kconfig
> @@ -7,6 +7,7 @@ comment "MemoryStick Host Controller Dri
> config MEMSTICK_TIFM_MS
> tristate "TI Flash Media MemoryStick Interface support (EXPERIMENTAL)"
> depends on EXPERIMENTAL && PCI
> + select MISC_DEVICES
> select TIFM_CORE
> help
> Say Y here if you want to be able to access MemoryStick cards with
> --- linux-next-20101013.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20101013/drivers/mmc/host/Kconfig
> @@ -277,6 +277,7 @@ config MMC_MXC
> config MMC_TIFM_SD
> tristate "TI Flash Media MMC/SD Interface support (EXPERIMENTAL)"
> depends on EXPERIMENTAL && PCI
> + select MISC_DEVICES
> select TIFM_CORE
> help
> Say Y here if you want to be able to access MMC/SD cards with
Acked-by: Chris Ball <cjb@laptop.org>
for the mmc hunk.
Andrew, perhaps you should take this to keep the mmc/memstick trees
from modifying files outside of their namespace? (Or we could just
ask Randy to split up the patch; whatever is preferred.)
Thanks,
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-14 4:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-14 1:07 [PATCH -next] tifm: fix kconfig dependencies Randy Dunlap
2010-10-14 4:35 ` Chris Ball
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.