* [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board
@ 2010-10-01 4:23 ` Chanwoo Choi
0 siblings, 0 replies; 14+ messages in thread
From: Chanwoo Choi @ 2010-10-01 4:23 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-samsung-soc, Kyungmin Park, Myungjoo Ham, Joonyoung Shim,
Ben Dooks, Kukjin Kim, Mark Brown, Liam Girdwood
This patch add initializtion code of audio and I2S platform drivers
to Goni and Aquila board.
Signed-off-by : Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by : Joonyoung Shim <jy0922.shim@samsung.com>
Signed-off-by : Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/mach-s5pv210/mach-aquila.c | 24 ++++++++++++++++++++++++
arch/arm/mach-s5pv210/mach-goni.c | 11 +++++++++++
2 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s5pv210/mach-aquila.c b/arch/arm/mach-s5pv210/mach-aquila.c
index 0663ec4..92dad41 100644
--- a/arch/arm/mach-s5pv210/mach-aquila.c
+++ b/arch/arm/mach-s5pv210/mach-aquila.c
@@ -507,8 +507,31 @@ static struct platform_device *aquila_devices[] __initdata = {
&s5p_device_fimc0,
&s5p_device_fimc1,
&s5p_device_fimc2,
+ &s5pv210_device_iis0,
};
+static void __init aquila_sound_init(void)
+{
+ unsigned int gpio;
+
+ /* CODEC_XTAL_EN
+ *
+ * The Aquila board have a oscillator which provide main clock
+ * to WM8994 codec. The oscillator provide 24MHz clock to WM8994
+ * clock. Set gpio setting of "CODEC_XTAL_EN" to enable a oscillator.
+ * */
+ gpio = S5PV210_GPH3(2); /* XEINT_26 */
+ gpio_request(gpio, "CODEC_XTAL_EN");
+ s3c_gpio_cfgpin(gpio, S3C_GPIO_OUTPUT);
+ s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
+
+ /* Ths main clock of WM8994 codec uses the output of CLKOUT pin.
+ * The CLKOUT[9:8] set to 0x3(XUSBXTI) of 0xE010E000(OTHERS)
+ * because it needs 24MHz clock to operate WM8994 codec.
+ */
+ writel(readl(S5P_OTHERS) | (0x3 << 8), S5P_OTHERS);
+}
+
static void __init aquila_map_io(void)
{
s5p_init_io(NULL, 0, S5P_VA_CHIPID);
@@ -530,6 +553,7 @@ static void __init aquila_machine_init(void)
s3c_fimc_setname(2, "s5p-fimc");
/* SOUND */
+ aquila_sound_init();
i2c_register_board_info(AP_I2C_GPIO_BUS_5, i2c_gpio5_devs,
ARRAY_SIZE(i2c_gpio5_devs));
diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c
index df5c2d1..d3bab85 100644
--- a/arch/arm/mach-s5pv210/mach-goni.c
+++ b/arch/arm/mach-s5pv210/mach-goni.c
@@ -488,8 +488,18 @@ static struct platform_device *goni_devices[] __initdata = {
&s3c_device_hsmmc0,
&s3c_device_hsmmc1,
&s3c_device_hsmmc2,
+ &s5pv210_device_iis0,
};
+static void __init goni_sound_init(void)
+{
+ /* Ths main clock of WM8994 codec uses the output of CLKOUT pin.
+ * The CLKOUT[9:8] set to 0x3(XUSBXTI) of 0xE010E000(OTHERS)
+ * because it needs 24MHz clock to operate WM8994 codec.
+ */
+ writel(readl(S5P_OTHERS) | (0x3 << 8), S5P_OTHERS);
+}
+
static void __init goni_map_io(void)
{
s5p_init_io(NULL, 0, S5P_VA_CHIPID);
@@ -507,6 +517,7 @@ static void __init goni_machine_init(void)
goni_setup_sdhci();
/* SOUND */
+ goni_sound_init();
i2c_register_board_info(AP_I2C_GPIO_BUS_5, i2c_gpio5_devs,
ARRAY_SIZE(i2c_gpio5_devs));
--
1.7.0.4
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board
@ 2010-10-01 4:23 ` Chanwoo Choi
0 siblings, 0 replies; 14+ messages in thread
From: Chanwoo Choi @ 2010-10-01 4:23 UTC (permalink / raw)
To: linux-arm-kernel
This patch add initializtion code of audio and I2S platform drivers
to Goni and Aquila board.
Signed-off-by : Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by : Joonyoung Shim <jy0922.shim@samsung.com>
Signed-off-by : Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/mach-s5pv210/mach-aquila.c | 24 ++++++++++++++++++++++++
arch/arm/mach-s5pv210/mach-goni.c | 11 +++++++++++
2 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s5pv210/mach-aquila.c b/arch/arm/mach-s5pv210/mach-aquila.c
index 0663ec4..92dad41 100644
--- a/arch/arm/mach-s5pv210/mach-aquila.c
+++ b/arch/arm/mach-s5pv210/mach-aquila.c
@@ -507,8 +507,31 @@ static struct platform_device *aquila_devices[] __initdata = {
&s5p_device_fimc0,
&s5p_device_fimc1,
&s5p_device_fimc2,
+ &s5pv210_device_iis0,
};
+static void __init aquila_sound_init(void)
+{
+ unsigned int gpio;
+
+ /* CODEC_XTAL_EN
+ *
+ * The Aquila board have a oscillator which provide main clock
+ * to WM8994 codec. The oscillator provide 24MHz clock to WM8994
+ * clock. Set gpio setting of "CODEC_XTAL_EN" to enable a oscillator.
+ * */
+ gpio = S5PV210_GPH3(2); /* XEINT_26 */
+ gpio_request(gpio, "CODEC_XTAL_EN");
+ s3c_gpio_cfgpin(gpio, S3C_GPIO_OUTPUT);
+ s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
+
+ /* Ths main clock of WM8994 codec uses the output of CLKOUT pin.
+ * The CLKOUT[9:8] set to 0x3(XUSBXTI) of 0xE010E000(OTHERS)
+ * because it needs 24MHz clock to operate WM8994 codec.
+ */
+ writel(readl(S5P_OTHERS) | (0x3 << 8), S5P_OTHERS);
+}
+
static void __init aquila_map_io(void)
{
s5p_init_io(NULL, 0, S5P_VA_CHIPID);
@@ -530,6 +553,7 @@ static void __init aquila_machine_init(void)
s3c_fimc_setname(2, "s5p-fimc");
/* SOUND */
+ aquila_sound_init();
i2c_register_board_info(AP_I2C_GPIO_BUS_5, i2c_gpio5_devs,
ARRAY_SIZE(i2c_gpio5_devs));
diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-goni.c
index df5c2d1..d3bab85 100644
--- a/arch/arm/mach-s5pv210/mach-goni.c
+++ b/arch/arm/mach-s5pv210/mach-goni.c
@@ -488,8 +488,18 @@ static struct platform_device *goni_devices[] __initdata = {
&s3c_device_hsmmc0,
&s3c_device_hsmmc1,
&s3c_device_hsmmc2,
+ &s5pv210_device_iis0,
};
+static void __init goni_sound_init(void)
+{
+ /* Ths main clock of WM8994 codec uses the output of CLKOUT pin.
+ * The CLKOUT[9:8] set to 0x3(XUSBXTI) of 0xE010E000(OTHERS)
+ * because it needs 24MHz clock to operate WM8994 codec.
+ */
+ writel(readl(S5P_OTHERS) | (0x3 << 8), S5P_OTHERS);
+}
+
static void __init goni_map_io(void)
{
s5p_init_io(NULL, 0, S5P_VA_CHIPID);
@@ -507,6 +517,7 @@ static void __init goni_machine_init(void)
goni_setup_sdhci();
/* SOUND */
+ goni_sound_init();
i2c_register_board_info(AP_I2C_GPIO_BUS_5, i2c_gpio5_devs,
ARRAY_SIZE(i2c_gpio5_devs));
--
1.7.0.4
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board
2010-10-01 4:23 ` Chanwoo Choi
@ 2010-10-01 5:28 ` Mark Brown
-1 siblings, 0 replies; 14+ messages in thread
From: Mark Brown @ 2010-10-01 5:28 UTC (permalink / raw)
To: Chanwoo Choi
Cc: linux-arm-kernel, Kukjin Kim, Joonyoung Shim, Kyungmin Park,
linux-samsung-soc, Myungjoo Ham, Ben Dooks, Liam Girdwood
On Fri, Oct 01, 2010 at 01:23:23PM +0900, Chanwoo Choi wrote:
> This patch add initializtion code of audio and I2S platform drivers
> to Goni and Aquila board.
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> +static void __init aquila_sound_init(void)
> +{
> + unsigned int gpio;
> +
> + /* CODEC_XTAL_EN
> + *
> + * The Aquila board have a oscillator which provide main clock
> + * to WM8994 codec. The oscillator provide 24MHz clock to WM8994
> + * clock. Set gpio setting of "CODEC_XTAL_EN" to enable a oscillator.
> + * */
In future we should be able to arrange for this clock to be disabled
when the CODEC is totally idle, giving a marginal power saving.
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board
@ 2010-10-01 5:28 ` Mark Brown
0 siblings, 0 replies; 14+ messages in thread
From: Mark Brown @ 2010-10-01 5:28 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Oct 01, 2010 at 01:23:23PM +0900, Chanwoo Choi wrote:
> This patch add initializtion code of audio and I2S platform drivers
> to Goni and Aquila board.
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> +static void __init aquila_sound_init(void)
> +{
> + unsigned int gpio;
> +
> + /* CODEC_XTAL_EN
> + *
> + * The Aquila board have a oscillator which provide main clock
> + * to WM8994 codec. The oscillator provide 24MHz clock to WM8994
> + * clock. Set gpio setting of "CODEC_XTAL_EN" to enable a oscillator.
> + * */
In future we should be able to arrange for this clock to be disabled
when the CODEC is totally idle, giving a marginal power saving.
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board
2010-10-01 4:23 ` Chanwoo Choi
@ 2010-10-14 0:32 ` Kukjin Kim
-1 siblings, 0 replies; 14+ messages in thread
From: Kukjin Kim @ 2010-10-14 0:32 UTC (permalink / raw)
To: 'Chanwoo Choi', 'linux-arm-kernel'
Cc: 'linux-samsung-soc', 'Kyungmin Park',
'Myungjoo Ham', 'Joonyoung Shim',
'Ben Dooks', 'Mark Brown',
'Liam Girdwood'
Chanwoo Choi wrote:
>
> This patch add initializtion code of audio and I2S platform drivers
> to Goni and Aquila board.
>
> Signed-off-by : Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by : Joonyoung Shim <jy0922.shim@samsung.com>
> Signed-off-by : Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/mach-s5pv210/mach-aquila.c | 24 ++++++++++++++++++++++++
> arch/arm/mach-s5pv210/mach-goni.c | 11 +++++++++++
> 2 files changed, 35 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s5pv210/mach-aquila.c b/arch/arm/mach-s5pv210/mach-
> aquila.c
> index 0663ec4..92dad41 100644
> --- a/arch/arm/mach-s5pv210/mach-aquila.c
> +++ b/arch/arm/mach-s5pv210/mach-aquila.c
> @@ -507,8 +507,31 @@ static struct platform_device *aquila_devices[] __initdata
> = {
> &s5p_device_fimc0,
> &s5p_device_fimc1,
> &s5p_device_fimc2,
> + &s5pv210_device_iis0,
> };
>
> +static void __init aquila_sound_init(void)
> +{
> + unsigned int gpio;
> +
> + /* CODEC_XTAL_EN
> + *
> + * The Aquila board have a oscillator which provide main clock
> + * to WM8994 codec. The oscillator provide 24MHz clock to WM8994
> + * clock. Set gpio setting of "CODEC_XTAL_EN" to enable a oscillator.
> + * */
> + gpio = S5PV210_GPH3(2); /* XEINT_26 */
> + gpio_request(gpio, "CODEC_XTAL_EN");
> + s3c_gpio_cfgpin(gpio, S3C_GPIO_OUTPUT);
> + s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
> +
> + /* Ths main clock of WM8994 codec uses the output of CLKOUT pin.
> + * The CLKOUT[9:8] set to 0x3(XUSBXTI) of 0xE010E000(OTHERS)
> + * because it needs 24MHz clock to operate WM8994 codec.
> + */
> + writel(readl(S5P_OTHERS) | (0x3 << 8), S5P_OTHERS);
> +}
> +
> static void __init aquila_map_io(void)
> {
> s5p_init_io(NULL, 0, S5P_VA_CHIPID);
> @@ -530,6 +553,7 @@ static void __init aquila_machine_init(void)
> s3c_fimc_setname(2, "s5p-fimc");
>
> /* SOUND */
> + aquila_sound_init();
> i2c_register_board_info(AP_I2C_GPIO_BUS_5, i2c_gpio5_devs,
> ARRAY_SIZE(i2c_gpio5_devs));
>
> diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-
> goni.c
> index df5c2d1..d3bab85 100644
> --- a/arch/arm/mach-s5pv210/mach-goni.c
> +++ b/arch/arm/mach-s5pv210/mach-goni.c
> @@ -488,8 +488,18 @@ static struct platform_device *goni_devices[] __initdata =
> {
> &s3c_device_hsmmc0,
> &s3c_device_hsmmc1,
> &s3c_device_hsmmc2,
> + &s5pv210_device_iis0,
> };
>
> +static void __init goni_sound_init(void)
> +{
> + /* Ths main clock of WM8994 codec uses the output of CLKOUT pin.
> + * The CLKOUT[9:8] set to 0x3(XUSBXTI) of 0xE010E000(OTHERS)
> + * because it needs 24MHz clock to operate WM8994 codec.
> + */
> + writel(readl(S5P_OTHERS) | (0x3 << 8), S5P_OTHERS);
> +}
> +
> static void __init goni_map_io(void)
> {
> s5p_init_io(NULL, 0, S5P_VA_CHIPID);
> @@ -507,6 +517,7 @@ static void __init goni_machine_init(void)
> goni_setup_sdhci();
>
> /* SOUND */
> + goni_sound_init();
> i2c_register_board_info(AP_I2C_GPIO_BUS_5, i2c_gpio5_devs,
> ARRAY_SIZE(i2c_gpio5_devs));
>
> --
Hi Chanwoo,
I missed your first patch "[PATCH 1/3] ARM: S5P210: Add i2c information to Goni and Aquila board" in my mailbox. Could you please re-send it?
And I prefer __raw_writel() than writel() here, because according to page table setting, the memory type of the area you want to access is shared device. No need memory barrier when you are accessing shared device type of memory.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board
@ 2010-10-14 0:32 ` Kukjin Kim
0 siblings, 0 replies; 14+ messages in thread
From: Kukjin Kim @ 2010-10-14 0:32 UTC (permalink / raw)
To: linux-arm-kernel
Chanwoo Choi wrote:
>
> This patch add initializtion code of audio and I2S platform drivers
> to Goni and Aquila board.
>
> Signed-off-by : Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by : Joonyoung Shim <jy0922.shim@samsung.com>
> Signed-off-by : Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/mach-s5pv210/mach-aquila.c | 24 ++++++++++++++++++++++++
> arch/arm/mach-s5pv210/mach-goni.c | 11 +++++++++++
> 2 files changed, 35 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s5pv210/mach-aquila.c b/arch/arm/mach-s5pv210/mach-
> aquila.c
> index 0663ec4..92dad41 100644
> --- a/arch/arm/mach-s5pv210/mach-aquila.c
> +++ b/arch/arm/mach-s5pv210/mach-aquila.c
> @@ -507,8 +507,31 @@ static struct platform_device *aquila_devices[] __initdata
> = {
> &s5p_device_fimc0,
> &s5p_device_fimc1,
> &s5p_device_fimc2,
> + &s5pv210_device_iis0,
> };
>
> +static void __init aquila_sound_init(void)
> +{
> + unsigned int gpio;
> +
> + /* CODEC_XTAL_EN
> + *
> + * The Aquila board have a oscillator which provide main clock
> + * to WM8994 codec. The oscillator provide 24MHz clock to WM8994
> + * clock. Set gpio setting of "CODEC_XTAL_EN" to enable a oscillator.
> + * */
> + gpio = S5PV210_GPH3(2); /* XEINT_26 */
> + gpio_request(gpio, "CODEC_XTAL_EN");
> + s3c_gpio_cfgpin(gpio, S3C_GPIO_OUTPUT);
> + s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
> +
> + /* Ths main clock of WM8994 codec uses the output of CLKOUT pin.
> + * The CLKOUT[9:8] set to 0x3(XUSBXTI) of 0xE010E000(OTHERS)
> + * because it needs 24MHz clock to operate WM8994 codec.
> + */
> + writel(readl(S5P_OTHERS) | (0x3 << 8), S5P_OTHERS);
> +}
> +
> static void __init aquila_map_io(void)
> {
> s5p_init_io(NULL, 0, S5P_VA_CHIPID);
> @@ -530,6 +553,7 @@ static void __init aquila_machine_init(void)
> s3c_fimc_setname(2, "s5p-fimc");
>
> /* SOUND */
> + aquila_sound_init();
> i2c_register_board_info(AP_I2C_GPIO_BUS_5, i2c_gpio5_devs,
> ARRAY_SIZE(i2c_gpio5_devs));
>
> diff --git a/arch/arm/mach-s5pv210/mach-goni.c b/arch/arm/mach-s5pv210/mach-
> goni.c
> index df5c2d1..d3bab85 100644
> --- a/arch/arm/mach-s5pv210/mach-goni.c
> +++ b/arch/arm/mach-s5pv210/mach-goni.c
> @@ -488,8 +488,18 @@ static struct platform_device *goni_devices[] __initdata =
> {
> &s3c_device_hsmmc0,
> &s3c_device_hsmmc1,
> &s3c_device_hsmmc2,
> + &s5pv210_device_iis0,
> };
>
> +static void __init goni_sound_init(void)
> +{
> + /* Ths main clock of WM8994 codec uses the output of CLKOUT pin.
> + * The CLKOUT[9:8] set to 0x3(XUSBXTI) of 0xE010E000(OTHERS)
> + * because it needs 24MHz clock to operate WM8994 codec.
> + */
> + writel(readl(S5P_OTHERS) | (0x3 << 8), S5P_OTHERS);
> +}
> +
> static void __init goni_map_io(void)
> {
> s5p_init_io(NULL, 0, S5P_VA_CHIPID);
> @@ -507,6 +517,7 @@ static void __init goni_machine_init(void)
> goni_setup_sdhci();
>
> /* SOUND */
> + goni_sound_init();
> i2c_register_board_info(AP_I2C_GPIO_BUS_5, i2c_gpio5_devs,
> ARRAY_SIZE(i2c_gpio5_devs));
>
> --
Hi Chanwoo,
I missed your first patch "[PATCH 1/3] ARM: S5P210: Add i2c information to Goni and Aquila board" in my mailbox. Could you please re-send it?
And I prefer __raw_writel() than writel() here, because according to page table setting, the memory type of the area you want to access is shared device. No need memory barrier when you are accessing shared device type of memory.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board
2010-10-14 0:32 ` Kukjin Kim
@ 2010-10-14 1:07 ` Jassi Brar
-1 siblings, 0 replies; 14+ messages in thread
From: Jassi Brar @ 2010-10-14 1:07 UTC (permalink / raw)
To: Kukjin Kim
Cc: linux-samsung-soc, Joonyoung Shim, Mark Brown, Chanwoo Choi,
Kyungmin Park, Myungjoo Ham, Ben Dooks, linux-arm-kernel,
Liam Girdwood
On Thu, Oct 14, 2010 at 9:32 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Chanwoo Choi wrote:
>>
>> This patch add initializtion code of audio and I2S platform drivers
>> to Goni and Aquila board.
GONI and AQUILA are mostly similar devices with different CPUs.
I have already merged the ASoC machine drivers for them into one.
Maybe you could compress code for other susystems as well ?
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board
@ 2010-10-14 1:07 ` Jassi Brar
0 siblings, 0 replies; 14+ messages in thread
From: Jassi Brar @ 2010-10-14 1:07 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 14, 2010 at 9:32 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Chanwoo Choi wrote:
>>
>> This patch add initializtion code of audio and I2S platform drivers
>> to Goni and Aquila board.
GONI and AQUILA are mostly similar devices with different CPUs.
I have already merged the ASoC machine drivers for them into one.
Maybe you could compress code for other susystems as well ?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board
2010-10-14 1:07 ` Jassi Brar
@ 2010-10-14 1:13 ` Kyungmin Park
-1 siblings, 0 replies; 14+ messages in thread
From: Kyungmin Park @ 2010-10-14 1:13 UTC (permalink / raw)
To: Jassi Brar
Cc: Kukjin Kim, linux-samsung-soc, Joonyoung Shim, Mark Brown,
Chanwoo Choi, Myungjoo Ham, Ben Dooks, linux-arm-kernel,
Liam Girdwood
On Thu, Oct 14, 2010 at 10:07 AM, Jassi Brar <jassisinghbrar@gmail.com> wrote:
> On Thu, Oct 14, 2010 at 9:32 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>> Chanwoo Choi wrote:
>>>
>>> This patch add initializtion code of audio and I2S platform drivers
>>> to Goni and Aquila board.
>
> GONI and AQUILA are mostly similar devices with different CPUs.
> I have already merged the ASoC machine drivers for them into one.
> Maybe you could compress code for other susystems as well ?
It's not exactly. GPIO pins are different.
Thank you,
Kyungmin Park
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board
@ 2010-10-14 1:13 ` Kyungmin Park
0 siblings, 0 replies; 14+ messages in thread
From: Kyungmin Park @ 2010-10-14 1:13 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 14, 2010 at 10:07 AM, Jassi Brar <jassisinghbrar@gmail.com> wrote:
> On Thu, Oct 14, 2010 at 9:32 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>> Chanwoo Choi wrote:
>>>
>>> This patch add initializtion code of audio and I2S platform drivers
>>> to Goni and Aquila board.
>
> GONI and AQUILA are mostly similar devices with different CPUs.
> I have already merged the ASoC machine drivers for them into one.
> Maybe you could compress code for other susystems as well ?
It's not exactly. GPIO pins are different.
Thank you,
Kyungmin Park
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board
2010-10-14 1:13 ` Kyungmin Park
@ 2010-10-14 1:17 ` Jassi Brar
-1 siblings, 0 replies; 14+ messages in thread
From: Jassi Brar @ 2010-10-14 1:17 UTC (permalink / raw)
To: Kyungmin Park
Cc: linux-samsung-soc, Joonyoung Shim, Mark Brown, Chanwoo Choi,
Myungjoo Ham, Ben Dooks, Kukjin Kim, linux-arm-kernel,
Liam Girdwood
On Thu, Oct 14, 2010 at 10:13 AM, Kyungmin Park
<kyungmin.park@samsung.com> wrote:
> On Thu, Oct 14, 2010 at 10:07 AM, Jassi Brar <jassisinghbrar@gmail.com> wrote:
>> On Thu, Oct 14, 2010 at 9:32 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>>> Chanwoo Choi wrote:
>>>>
>>>> This patch add initializtion code of audio and I2S platform drivers
>>>> to Goni and Aquila board.
>>
>> GONI and AQUILA are mostly similar devices with different CPUs.
>> I have already merged the ASoC machine drivers for them into one.
>> Maybe you could compress code for other susystems as well ?
> It's not exactly. GPIO pins are different.
Maybe the GPIO differences could be handled at one place and other codes
compressed ?
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board
@ 2010-10-14 1:17 ` Jassi Brar
0 siblings, 0 replies; 14+ messages in thread
From: Jassi Brar @ 2010-10-14 1:17 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 14, 2010 at 10:13 AM, Kyungmin Park
<kyungmin.park@samsung.com> wrote:
> On Thu, Oct 14, 2010 at 10:07 AM, Jassi Brar <jassisinghbrar@gmail.com> wrote:
>> On Thu, Oct 14, 2010 at 9:32 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>>> Chanwoo Choi wrote:
>>>>
>>>> This patch add initializtion code of audio and I2S platform drivers
>>>> to Goni and Aquila board.
>>
>> GONI and AQUILA are mostly similar devices with different CPUs.
>> I have already merged the ASoC machine drivers for them into one.
>> Maybe you could compress code for other susystems as well ?
> It's not exactly. GPIO pins are different.
Maybe the GPIO differences could be handled at one place and other codes
compressed ?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board
2010-10-14 1:17 ` Jassi Brar
@ 2010-10-14 14:17 ` Mark Brown
-1 siblings, 0 replies; 14+ messages in thread
From: Mark Brown @ 2010-10-14 14:17 UTC (permalink / raw)
To: Jassi Brar
Cc: Kyungmin Park, Kukjin Kim, linux-samsung-soc, Joonyoung Shim,
Chanwoo Choi, Myungjoo Ham, Ben Dooks, linux-arm-kernel,
Liam Girdwood
On Thu, Oct 14, 2010 at 10:17:11AM +0900, Jassi Brar wrote:
> > It's not exactly. GPIO pins are different.
> Maybe the GPIO differences could be handled at one place and other codes
> compressed ?
Platform data for the audio driver, perhaps? That's being used by some
other systems, and should be much easier now with multi-component.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board
@ 2010-10-14 14:17 ` Mark Brown
0 siblings, 0 replies; 14+ messages in thread
From: Mark Brown @ 2010-10-14 14:17 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 14, 2010 at 10:17:11AM +0900, Jassi Brar wrote:
> > It's not exactly. GPIO pins are different.
> Maybe the GPIO differences could be handled at one place and other codes
> compressed ?
Platform data for the audio driver, perhaps? That's being used by some
other systems, and should be much easier now with multi-component.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2010-10-14 14:17 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-01 4:23 [PATCH 2/3] ARM: S5PV210: Add init code of audio to Goni and Aquila board Chanwoo Choi
2010-10-01 4:23 ` Chanwoo Choi
2010-10-01 5:28 ` Mark Brown
2010-10-01 5:28 ` Mark Brown
2010-10-14 0:32 ` Kukjin Kim
2010-10-14 0:32 ` Kukjin Kim
2010-10-14 1:07 ` Jassi Brar
2010-10-14 1:07 ` Jassi Brar
2010-10-14 1:13 ` Kyungmin Park
2010-10-14 1:13 ` Kyungmin Park
2010-10-14 1:17 ` Jassi Brar
2010-10-14 1:17 ` Jassi Brar
2010-10-14 14:17 ` Mark Brown
2010-10-14 14:17 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.