From: Dan Carpenter <error27@gmail.com>
To: "James E.J. Bottomley" <James.Bottomley@suse.de>
Cc: James Smart <james.smart@emulex.com>,
Christof Schmitt <christof.schmitt@de.ibm.com>,
Hannes Reinecke <hare@suse.de>,
Mike Christie <michaelc@cs.wisc.edu>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch -next] scsi_transport_fc: remove unneeded check
Date: Thu, 14 Oct 2010 18:23:30 +0000 [thread overview]
Message-ID: <20101014182330.GD6614@bicker> (raw)
"val" can never be less than zero here. It's unsigned and
simple_strtoul() always returns positive values.
I also cleaned up the check. "*cp != '\0'" is more explicit than "*cp"
and I removed some parenthesis that weren't needed.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
I sent this patch some months back but didn't recieve any feedback.
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index 0681378..b108a9b 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
@@ -844,7 +844,7 @@ store_fc_rport_dev_loss_tmo(struct device *dev, struct device_attribute *attr,
(rport->port_state = FC_PORTSTATE_NOTPRESENT))
return -EBUSY;
val = simple_strtoul(buf, &cp, 0);
- if ((*cp && (*cp != '\n')) || (val < 0))
+ if (*cp != '\0' && *cp != '\n')
return -EINVAL;
/*
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: "James E.J. Bottomley" <James.Bottomley@suse.de>
Cc: James Smart <james.smart@emulex.com>,
Christof Schmitt <christof.schmitt@de.ibm.com>,
Hannes Reinecke <hare@suse.de>,
Mike Christie <michaelc@cs.wisc.edu>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch -next] scsi_transport_fc: remove unneeded check
Date: Thu, 14 Oct 2010 20:23:30 +0200 [thread overview]
Message-ID: <20101014182330.GD6614@bicker> (raw)
"val" can never be less than zero here. It's unsigned and
simple_strtoul() always returns positive values.
I also cleaned up the check. "*cp != '\0'" is more explicit than "*cp"
and I removed some parenthesis that weren't needed.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
I sent this patch some months back but didn't recieve any feedback.
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index 0681378..b108a9b 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
@@ -844,7 +844,7 @@ store_fc_rport_dev_loss_tmo(struct device *dev, struct device_attribute *attr,
(rport->port_state == FC_PORTSTATE_NOTPRESENT))
return -EBUSY;
val = simple_strtoul(buf, &cp, 0);
- if ((*cp && (*cp != '\n')) || (val < 0))
+ if (*cp != '\0' && *cp != '\n')
return -EINVAL;
/*
next reply other threads:[~2010-10-14 18:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 18:23 Dan Carpenter [this message]
2010-10-14 18:23 ` [patch -next] scsi_transport_fc: remove unneeded check Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101014182330.GD6614@bicker \
--to=error27@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=christof.schmitt@de.ibm.com \
--cc=hare@suse.de \
--cc=james.smart@emulex.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.