From: Arnd Bergmann <arnd@arndb.de>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux390@de.ibm.com, linux-s390@vger.kernel.org
Subject: Re: [PATCH 03/22] s390: introduce little endian bitops
Date: Fri, 15 Oct 2010 13:12:30 +0200 [thread overview]
Message-ID: <201010151312.30843.arnd@arndb.de> (raw)
In-Reply-To: <1287135981-17604-4-git-send-email-akinobu.mita@gmail.com>
On Friday 15 October 2010, Akinobu Mita wrote:
> +#define __set_le_bit(nr, addr) \
> + __set_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr))
> +#define __clear_le_bit(nr, addr) \
> + __clear_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr))
> +#define __test_and_set_le_bit(nr, addr) \
> + __test_and_set_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr))
> +#define test_and_set_le_bit(lock, nr, addr) \
> + test_and_set_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr))
> +#define __test_and_clear_le_bit(nr, addr) \
> + __test_and_clear_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr))
> +#define test_and_clear_le_bit(lock, nr, addr) \
> + test_and_clear_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr))
> +#define test_le_bit(nr, addr) \
> + test_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr))
The test_and_clear_le_bit and test_and_set_le_bit calling conventions
are a little surprising here. I would not pass the lock argument
here but leave that to the ext2 wrapper:
#define test_and_set_le_bit(nr, addr) \
test_and_set_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr))
#define test_and_clear_le_bit(nr, addr) \
test_and_clear_bit((nr)^(__BITOPS_WORDSIZE - 8), (addr))
#define ext2_set_bit_atomic(lock, nr, addr) \
test_and_set_le_bit((nr), (unsigned long *)(addr))
#define ext2_clear_bit_atomic(lock, nr, addr) \
test_and_clear_le_bit((nr), (unsigned long *)(addr))
Same thing on arm and m68k.
Arnd
next prev parent reply other threads:[~2010-10-15 11:11 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 9:45 [PATCH 00/22] Introduce little endian bitops Akinobu Mita
2010-10-15 9:44 ` [Ocfs2-devel] [PATCH 13/22] ocfs2: use " Akinobu Mita
2010-10-15 9:46 ` Akinobu Mita
2010-10-18 20:19 ` Joel Becker
2010-10-18 20:19 ` [Ocfs2-devel] " Joel Becker
2010-10-18 20:19 ` Joel Becker
2010-10-15 9:46 ` [PATCH 01/22] bitops: merge little and big endian definisions in asm-generic/bitops/le.h Akinobu Mita
2010-10-15 9:46 ` [PATCH 02/22] bitops: rename generic le bitops functions Akinobu Mita
2010-10-15 9:46 ` [PATCH 03/22] s390: introduce little endian bitops Akinobu Mita
2010-10-15 11:12 ` Arnd Bergmann [this message]
2010-10-18 4:51 ` Akinobu Mita
2010-10-15 9:46 ` [PATCH 04/22] arm: " Akinobu Mita
2010-10-15 9:46 ` Akinobu Mita
2010-10-18 9:26 ` Russell King - ARM Linux
2010-10-18 9:26 ` Russell King - ARM Linux
2010-10-18 13:22 ` Akinobu Mita
2010-10-18 13:22 ` Akinobu Mita
2010-10-18 13:56 ` Russell King - ARM Linux
2010-10-18 13:56 ` Russell King - ARM Linux
2010-10-18 14:45 ` Arnd Bergmann
2010-10-18 14:45 ` Arnd Bergmann
2010-10-18 15:07 ` Russell King - ARM Linux
2010-10-18 15:07 ` Russell King - ARM Linux
2010-10-18 13:58 ` Russell King - ARM Linux
2010-10-18 13:58 ` Russell King - ARM Linux
2010-10-15 9:46 ` [PATCH 05/22] m68k: introduce le bitops Akinobu Mita
2010-10-15 9:46 ` [PATCH 06/22] m68knommu: introduce little endian bitops Akinobu Mita
2010-10-15 9:46 ` [PATCH 07/22] bitops: introduce little endian bitops for most architectures Akinobu Mita
2010-10-15 9:46 ` [PATCH 08/22] rds: stop including asm-generic/bitops/le.h Akinobu Mita
2010-10-15 9:46 ` [PATCH 09/22] kvm: " Akinobu Mita
2010-10-15 9:46 ` [PATCH 10/22] asm-generic: use little endian bitops Akinobu Mita
2010-10-15 11:06 ` Arnd Bergmann
2010-10-15 9:46 ` [PATCH 11/22] ext3: " Akinobu Mita
2010-10-15 9:46 ` Akinobu Mita
2010-10-15 9:46 ` Akinobu Mita
2010-10-18 10:31 ` Jan Kara
2010-10-15 9:46 ` [PATCH 12/22] ext4: " Akinobu Mita
2010-10-15 9:46 ` [PATCH 14/22] nilfs2: " Akinobu Mita
2010-10-15 9:46 ` [PATCH 15/22] reiserfs: " Akinobu Mita
2010-10-15 9:46 ` [PATCH 16/22] udf: " Akinobu Mita
2010-10-18 10:46 ` Jan Kara
2010-10-15 9:46 ` [PATCH 17/22] ufs: " Akinobu Mita
2010-10-15 9:46 ` [PATCH 18/22] md: use little endian bit operations Akinobu Mita
2010-10-18 2:41 ` Neil Brown
2010-10-15 9:46 ` [PATCH 19/22] dm: " Akinobu Mita
2010-10-15 9:46 ` Akinobu Mita
2010-10-15 9:46 ` [PATCH 20/22] bitops: remove ext2 non-atomic bitops from asm/bitops.h Akinobu Mita
2010-10-15 9:46 ` [PATCH 21/22] m68k: convert minix bitops to use little endian bitops Akinobu Mita
2010-10-18 8:58 ` Andreas Schwab
2010-10-15 9:46 ` [PATCH 22/22] bitops: remove minix bitops from asm/bitops.h Akinobu Mita
2010-10-15 10:53 ` Arnd Bergmann
2010-10-15 18:53 ` Mike Frysinger
2010-10-15 20:15 ` Arnd Bergmann
2010-10-16 7:59 ` Geert Uytterhoeven
2010-10-16 8:50 ` Andreas Schwab
2010-10-16 8:50 ` Andreas Schwab
2010-10-16 11:35 ` Geert Uytterhoeven
2010-10-16 12:40 ` Akinobu Mita
2010-10-16 12:57 ` Andreas Schwab
2010-10-16 12:57 ` Andreas Schwab
2010-10-16 13:47 ` Akinobu Mita
2010-10-16 15:58 ` Andreas Schwab
2010-10-16 15:58 ` Andreas Schwab
2010-10-19 15:05 ` Akinobu Mita
2010-10-15 11:14 ` [PATCH 00/22] Introduce little endian bitops Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010151312.30843.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.