From: Ralf Baechle <ralf@linux-mips.org>
To: Julia Lawall <julia@diku.dk>
Cc: Pat Gefre <pfg@sgi.com>,
kernel-janitors@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] drivers/serial/ioc3_serial.c: Return -ENOMEM on
Date: Fri, 15 Oct 2010 14:08:19 +0000 [thread overview]
Message-ID: <20101015140819.GA3163@linux-mips.org> (raw)
In-Reply-To: <1287147610-8041-6-git-send-email-julia@diku.dk>
On Fri, Oct 15, 2010 at 03:00:09PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> In this code, 0 is returned on memory allocation failure, even though other
> failures return -ENOMEM or other similar values.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
Dunno why linux-mips rsp. myself keep receiving patches for the ioc3 serial
driver - it's only being used on SGI IA64 machines.
Either way, I'm willing to funnel this patch upstream - I'm building a
pull rq for tonight anyway.
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Julia Lawall <julia@diku.dk>
Cc: Pat Gefre <pfg@sgi.com>,
kernel-janitors@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] drivers/serial/ioc3_serial.c: Return -ENOMEM on memory allocation failure
Date: Fri, 15 Oct 2010 15:08:19 +0100 [thread overview]
Message-ID: <20101015140819.GA3163@linux-mips.org> (raw)
In-Reply-To: <1287147610-8041-6-git-send-email-julia@diku.dk>
On Fri, Oct 15, 2010 at 03:00:09PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> In this code, 0 is returned on memory allocation failure, even though other
> failures return -ENOMEM or other similar values.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
Dunno why linux-mips rsp. myself keep receiving patches for the ioc3 serial
driver - it's only being used on SGI IA64 machines.
Either way, I'm willing to funnel this patch upstream - I'm building a
pull rq for tonight anyway.
Ralf
next prev parent reply other threads:[~2010-10-15 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 12:54 [PATCH 6/7] drivers/serial/ioc3_serial.c: Return -ENOMEM on memory allocation failure Julia Lawall
2010-10-15 13:00 ` Julia Lawall
2010-10-15 12:55 ` Julia Lawall
2010-10-15 14:08 ` Ralf Baechle [this message]
2010-10-15 14:08 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015140819.GA3163@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=pfg@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.