All of lore.kernel.org
 help / color / mirror / Atom feed
From: John W. Linville <linville@tuxdriver.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	Henry Ptasinski <henryp@broadcom.com>,
	Brett Rudley <brudley@broadcom.com>,
	Nohee Ko <noheek@broadcom.com>
Subject: [PATCH 2/3 V2] b43: N-PHY: define registers names for 2056 radio
Date: Mon, 18 Oct 2010 16:34:06 -0400	[thread overview]
Message-ID: <20101018203405.GB2443@tuxdriver.com> (raw)
In-Reply-To: <1287322732-13306-3-git-send-email-zajec5@gmail.com>

On Sun, Oct 17, 2010 at 03:38:51PM +0200, Rafa? Mi?ecki wrote:
> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> Cc: Henry Ptasinski <henryp@broadcom.com>
> Cc: Brett Rudley <brudley@broadcom.com>
> Cc: Nohee Ko <noheek@broadcom.com>
> ---
> V2: changed defines prefix from RADIO_ to B as correctly suggested by Stefanik.
> 
> John: in case you got lost the correct order of patches is following:
> 
> [PATCH 1/4 resend] b43: N-PHY: replace N-specific radio_chanspec with common code
> [PATCH 2/4 resend] b43: N-PHY: fix typo: read table when caching IQ LO calibration (do not write)
> [PATCH 3/4] b43: N-PHY: put radio-specific code in separated file
> [PATCH 4/4] b43: N-PHY: put 2056-radio's specific code in separated file
> 
> [PATCH 1/3] b43: N-PHY: define channel table struct for rev3+ devices
> [PATCH 2/3 V2] b43: N-PHY: define registers names for 2056 radio
> [PATCH 3/3] b43: N-PHY: add 2056 radio channels tables
> 
> PATCH 1/3 got some discussion but we decided it's OK.

Thanks for the update.  In the future, please also try to post
replacement patches as a reply to the patch they are replacing.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville at tuxdriver.com			might be all we have.  Be ready.

WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	Henry Ptasinski <henryp@broadcom.com>,
	Brett Rudley <brudley@broadcom.com>,
	Nohee Ko <noheek@broadcom.com>
Subject: Re: [PATCH 2/3 V2] b43: N-PHY: define registers names for 2056 radio
Date: Mon, 18 Oct 2010 16:34:06 -0400	[thread overview]
Message-ID: <20101018203405.GB2443@tuxdriver.com> (raw)
In-Reply-To: <1287322732-13306-3-git-send-email-zajec5@gmail.com>

On Sun, Oct 17, 2010 at 03:38:51PM +0200, Rafał Miłecki wrote:
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> Cc: Henry Ptasinski <henryp@broadcom.com>
> Cc: Brett Rudley <brudley@broadcom.com>
> Cc: Nohee Ko <noheek@broadcom.com>
> ---
> V2: changed defines prefix from RADIO_ to B as correctly suggested by Stefanik.
> 
> John: in case you got lost the correct order of patches is following:
> 
> [PATCH 1/4 resend] b43: N-PHY: replace N-specific radio_chanspec with common code
> [PATCH 2/4 resend] b43: N-PHY: fix typo: read table when caching IQ LO calibration (do not write)
> [PATCH 3/4] b43: N-PHY: put radio-specific code in separated file
> [PATCH 4/4] b43: N-PHY: put 2056-radio's specific code in separated file
> 
> [PATCH 1/3] b43: N-PHY: define channel table struct for rev3+ devices
> [PATCH 2/3 V2] b43: N-PHY: define registers names for 2056 radio
> [PATCH 3/3] b43: N-PHY: add 2056 radio channels tables
> 
> PATCH 1/3 got some discussion but we decided it's OK.

Thanks for the update.  In the future, please also try to post
replacement patches as a reply to the patch they are replacing.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2010-10-18 20:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-17 13:38 [PATCH 2/3 V2] b43: N-PHY: define registers names for 2056 radio Rafał Miłecki
2010-10-17 13:38 ` Rafał Miłecki
2010-10-18 20:34 ` John W. Linville [this message]
2010-10-18 20:34   ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101018203405.GB2443@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=brudley@broadcom.com \
    --cc=henryp@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=noheek@broadcom.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.