From: Tony Lindgren <tony@atomide.com>
To: Evgeny Kuznetsov <EXT-Eugeny.Kuznetsov@nokia.com>
Cc: "ext Varadarajan, Charulatha" <charu@ti.com>,
linux-omap@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Balbi, Felipe" <balbi@ti.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"khilman@deeprootsystems.com" <khilman@deeprootsystems.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"tero.kristo@nokia.com" <tero.kristo@nokia.com>
Subject: Re: [PATCHv2 1/1] omap: Ptr "isr_reg" tracked as NULL was dereferenced
Date: Mon, 18 Oct 2010 16:11:47 -0700 [thread overview]
Message-ID: <20101018231147.GK13341@atomide.com> (raw)
In-Reply-To: <1287123378.12782.49.camel@ekuznets-lx-nokia>
* Evgeny Kuznetsov <EXT-Eugeny.Kuznetsov@nokia.com> [101014 23:11]:
> On Wed, 2010-10-13 at 16:09 +0400, Evgeny Kuznetsov wrote:
> > On Wed, 2010-10-13 at 17:20 +0530, ext Varadarajan, Charulatha wrote:
> Hi Tony,
>
> It is not a bug fix, it is just check to prevent potential issues. Used
> to warn in case of bug and prevent kernel oops. Check added only here
> (not all gpio code cleanup) since here it could cause kernel opps.
>
> Would you apply patch if I will leave only if condition section in
> patch?
>
> if (WARN_ON(!isr_reg))
> goto exit;
>
> If yes, I'll resend v3 patch.
Sounds like a valid check to me.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/1] omap: Ptr "isr_reg" tracked as NULL was dereferenced
Date: Mon, 18 Oct 2010 16:11:47 -0700 [thread overview]
Message-ID: <20101018231147.GK13341@atomide.com> (raw)
In-Reply-To: <1287123378.12782.49.camel@ekuznets-lx-nokia>
* Evgeny Kuznetsov <EXT-Eugeny.Kuznetsov@nokia.com> [101014 23:11]:
> On Wed, 2010-10-13 at 16:09 +0400, Evgeny Kuznetsov wrote:
> > On Wed, 2010-10-13 at 17:20 +0530, ext Varadarajan, Charulatha wrote:
> Hi Tony,
>
> It is not a bug fix, it is just check to prevent potential issues. Used
> to warn in case of bug and prevent kernel oops. Check added only here
> (not all gpio code cleanup) since here it could cause kernel opps.
>
> Would you apply patch if I will leave only if condition section in
> patch?
>
> if (WARN_ON(!isr_reg))
> goto exit;
>
> If yes, I'll resend v3 patch.
Sounds like a valid check to me.
Tony
next prev parent reply other threads:[~2010-10-18 23:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 10:04 [PATCHv2 0/1] omap: Ptr "isr_reg" tracked as NULL was dereferenced Evgeny Kuznetsov
2010-10-13 10:04 ` Evgeny Kuznetsov
2010-10-13 10:04 ` Evgeny Kuznetsov
2010-10-13 10:04 ` [PATCHv2 1/1] " Evgeny Kuznetsov
2010-10-13 10:04 ` Evgeny Kuznetsov
2010-10-13 10:55 ` Varadarajan, Charulatha
2010-10-13 10:55 ` Varadarajan, Charulatha
2010-10-13 11:43 ` Evgeny Kuznetsov
2010-10-13 11:43 ` Evgeny Kuznetsov
2010-10-13 11:50 ` Varadarajan, Charulatha
2010-10-13 11:50 ` Varadarajan, Charulatha
2010-10-13 12:09 ` Evgeny Kuznetsov
2010-10-13 12:09 ` Evgeny Kuznetsov
2010-10-15 6:16 ` Evgeny Kuznetsov
2010-10-15 6:16 ` Evgeny Kuznetsov
2010-10-18 23:11 ` Tony Lindgren [this message]
2010-10-18 23:11 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101018231147.GK13341@atomide.com \
--to=tony@atomide.com \
--cc=EXT-Eugeny.Kuznetsov@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=balbi@ti.com \
--cc=charu@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tero.kristo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.