From: Chris Ball <cjb@laptop.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Zhu Richard-R65037 <r65037@freescale.com>
Subject: Re: [PATCH 5/6] mmc: sdhci-of-esdhc: factor out common stuff
Date: Tue, 19 Oct 2010 03:36:42 +0100 [thread overview]
Message-ID: <20101019023642.GA11777@void.printf.net> (raw)
In-Reply-To: <20101019022950.GC3485@pengutronix.de>
On Tue, Oct 19, 2010 at 04:29:50AM +0200, Wolfram Sang wrote:
> > Stephen reports a -next build failure after this patch. Presumably this
> > should be sdhci-esdhc.h? It's confusing that no-one else hit this.
>
> Uh, ouch, one brown paper bag, please! Yeah, confusing, that is.
Ah, not that confusing -- sdhci-of-esdhc.c essentially depends on PPC,
and MMC_SDHCI_ESDHC_IMX depends on ARM, and I imagine we've only had
testing on the latter.
> Regarding your patch:
>
> Acked-by: Wolfram Sang <w.sang@pengutronix.de>
Thanks. When it comes time to send to Linus, I'll just roll this into
your original [5/6].
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
WARNING: multiple messages have this Message-ID (diff)
From: cjb@laptop.org (Chris Ball)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] mmc: sdhci-of-esdhc: factor out common stuff
Date: Tue, 19 Oct 2010 03:36:42 +0100 [thread overview]
Message-ID: <20101019023642.GA11777@void.printf.net> (raw)
In-Reply-To: <20101019022950.GC3485@pengutronix.de>
On Tue, Oct 19, 2010 at 04:29:50AM +0200, Wolfram Sang wrote:
> > Stephen reports a -next build failure after this patch. Presumably this
> > should be sdhci-esdhc.h? It's confusing that no-one else hit this.
>
> Uh, ouch, one brown paper bag, please! Yeah, confusing, that is.
Ah, not that confusing -- sdhci-of-esdhc.c essentially depends on PPC,
and MMC_SDHCI_ESDHC_IMX depends on ARM, and I imagine we've only had
testing on the latter.
> Regarding your patch:
>
> Acked-by: Wolfram Sang <w.sang@pengutronix.de>
Thanks. When it comes time to send to Linus, I'll just roll this into
your original [5/6].
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-10-19 2:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 10:20 [PATCH V5 0/6] SD/MMC driver for MX25/35/51 Wolfram Sang
2010-10-15 10:20 ` Wolfram Sang
2010-10-15 10:20 ` [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data Wolfram Sang
2010-10-15 10:20 ` Wolfram Sang
2010-10-15 10:21 ` [PATCH 2/6] mmc: sdhci-pltfm: move .h-file into apropriate subdir Wolfram Sang
2010-10-15 10:21 ` Wolfram Sang
2010-10-15 10:21 ` [PATCH 3/6] mmc: sdhci: introduce private get_ro Wolfram Sang
2010-10-15 10:21 ` Wolfram Sang
2010-10-15 10:21 ` [PATCH 4/6] mmc: sdhci_pltfm: pass more data on custom init-call Wolfram Sang
2010-10-15 10:21 ` Wolfram Sang
2010-10-15 10:21 ` [PATCH 5/6] mmc: sdhci-of-esdhc: factor out common stuff Wolfram Sang
2010-10-15 10:21 ` Wolfram Sang
2010-10-18 16:13 ` Chris Ball
2010-10-18 16:13 ` Chris Ball
2010-10-19 2:29 ` Wolfram Sang
2010-10-19 2:29 ` Wolfram Sang
2010-10-19 2:36 ` Chris Ball [this message]
2010-10-19 2:36 ` Chris Ball
2010-10-15 10:21 ` [PATCH 6/6] mmc: sdhci-pltfm: add pltfm-driver for imx35/51 Wolfram Sang
2010-10-15 10:21 ` Wolfram Sang
2010-10-15 20:18 ` [PATCH V5 0/6] SD/MMC driver for MX25/35/51 Chris Ball
2010-10-15 20:18 ` Chris Ball
-- strict thread matches above, loose matches on Subject: below --
2010-10-11 14:21 [PATCH " Wolfram Sang
2010-10-11 14:21 ` [PATCH 5/6] mmc: sdhci-of-esdhc: factor out common stuff Wolfram Sang
2010-10-11 14:21 ` Wolfram Sang
2010-09-29 20:07 [PATCH V3 0/6] SD/MMC-driver for MX35/51 (and improvements to SDHCI) Wolfram Sang
2010-09-29 20:08 ` [PATCH 5/6] mmc: sdhci-of-esdhc: factor out common stuff Wolfram Sang
2010-09-29 20:08 ` Wolfram Sang
2010-09-28 12:36 [PATCH 0/6] Add driver for mx35/51-esdhc-controller (and update sdhci for that) Wolfram Sang
2010-09-28 12:36 ` [PATCH 5/6] mmc: sdhci-of-esdhc: factor out common stuff Wolfram Sang
2010-09-28 12:58 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019023642.GA11777@void.printf.net \
--to=cjb@laptop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=r65037@freescale.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.