From: Samuel Ortiz <sameo@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "G, Manjunath Kondaiah" <manjugk@ti.com>,
Tony Lindgren <tony@atomide.com>, Nishanth Menon <nm@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] TWL IRQ: Fix fucntion declaration warnings
Date: Tue, 19 Oct 2010 12:33:45 +0200 [thread overview]
Message-ID: <20101019103344.GL2736@sortiz-mobl> (raw)
In-Reply-To: <20101019092816.GD11713@pengutronix.de>
Hi Uwe,
On Tue, Oct 19, 2010 at 11:28:16AM +0200, Uwe Kleine-König wrote:
> On Tue, Oct 19, 2010 at 11:06:14AM +0200, Samuel Ortiz wrote:
> > Hi Manjunath,
> >
> > On Wed, Oct 06, 2010 at 03:26:59AM +0530, G, Manjunath Kondaiah wrote:
> > > Fixes following sparse warnings for twl4030 and twl6030 irq files.
> > >
> > > drivers/mfd/twl4030-irq.c:783:5: warning: symbol 'twl4030_init_irq' was not declared. Should it be static?
> > > drivers/mfd/twl4030-irq.c:863:5: warning: symbol 'twl4030_exit_irq' was not declared. Should it be static?
> > > drivers/mfd/twl4030-irq.c:873:5: warning: symbol 'twl4030_init_chip_irq' was not declared. Should it be static?
> > >
> > > drivers/mfd/twl6030-irq.c:226:5: warning: symbol 'twl6030_init_irq' was not declared. Should it be static?
> > > drivers/mfd/twl6030-irq.c:290:5: warning: symbol 'twl6030_exit_irq' was not declared. Should it be static?
> > >
> > Patch applied, thanks.
> I didn't get the original patch, so I just now noticed the typo in the
> Subject. You might want to do s/fucntion/function/
Yes, I noticed as well and fixed it, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: sameo@linux.intel.com (Samuel Ortiz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] TWL IRQ: Fix fucntion declaration warnings
Date: Tue, 19 Oct 2010 12:33:45 +0200 [thread overview]
Message-ID: <20101019103344.GL2736@sortiz-mobl> (raw)
In-Reply-To: <20101019092816.GD11713@pengutronix.de>
Hi Uwe,
On Tue, Oct 19, 2010 at 11:28:16AM +0200, Uwe Kleine-K?nig wrote:
> On Tue, Oct 19, 2010 at 11:06:14AM +0200, Samuel Ortiz wrote:
> > Hi Manjunath,
> >
> > On Wed, Oct 06, 2010 at 03:26:59AM +0530, G, Manjunath Kondaiah wrote:
> > > Fixes following sparse warnings for twl4030 and twl6030 irq files.
> > >
> > > drivers/mfd/twl4030-irq.c:783:5: warning: symbol 'twl4030_init_irq' was not declared. Should it be static?
> > > drivers/mfd/twl4030-irq.c:863:5: warning: symbol 'twl4030_exit_irq' was not declared. Should it be static?
> > > drivers/mfd/twl4030-irq.c:873:5: warning: symbol 'twl4030_init_chip_irq' was not declared. Should it be static?
> > >
> > > drivers/mfd/twl6030-irq.c:226:5: warning: symbol 'twl6030_init_irq' was not declared. Should it be static?
> > > drivers/mfd/twl6030-irq.c:290:5: warning: symbol 'twl6030_exit_irq' was not declared. Should it be static?
> > >
> > Patch applied, thanks.
> I didn't get the original patch, so I just now noticed the typo in the
> Subject. You might want to do s/fucntion/function/
Yes, I noticed as well and fixed it, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-10-19 10:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 21:56 [PATCH v3] OMAP: NAND: Fix static declaration warning G, Manjunath Kondaiah
2010-10-05 21:56 ` [PATCH v3] OMAP2: onenand: Fix static function warnings G, Manjunath Kondaiah
2010-10-05 21:56 ` [PATCH v3] OMAP2/3: NAND: Convert write/read functions to raw read/write G, Manjunath Kondaiah
2010-10-11 18:59 ` Artem Bityutskiy
2010-10-11 18:59 ` Artem Bityutskiy
2010-10-11 18:59 ` Artem Bityutskiy
2010-10-05 21:56 ` [PATCH v3] TWL IRQ: Fix fucntion declaration warnings G, Manjunath Kondaiah
2010-10-12 5:36 ` G, Manjunath Kondaiah
2010-10-12 5:36 ` G, Manjunath Kondaiah
2010-10-19 9:06 ` Samuel Ortiz
2010-10-19 9:06 ` Samuel Ortiz
2010-10-19 9:28 ` Uwe Kleine-König
2010-10-19 9:28 ` Uwe Kleine-König
2010-10-19 10:33 ` Samuel Ortiz [this message]
2010-10-19 10:33 ` Samuel Ortiz
2010-10-07 17:35 ` [PATCH v3] OMAP: NAND: Fix static declaration warning Vimal Singh
2010-10-07 17:35 ` Vimal Singh
2010-10-07 17:35 ` Vimal Singh
2010-10-11 18:58 ` Artem Bityutskiy
2010-10-11 18:58 ` Artem Bityutskiy
2010-10-11 18:58 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019103344.GL2736@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=nm@ti.com \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.