All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] [PATCH] lm-sensors: Fix error seen with non-sequential
@ 2010-10-19 16:48 Guenter Roeck
  0 siblings, 0 replies; only message in thread
From: Guenter Roeck @ 2010-10-19 16:48 UTC (permalink / raw)
  To: lm-sensors

The following patch fixes an error seen in sensors-detect if i2c bus numbering
is not sequential. Problem is that in this case, $i2c_adapters[] does not exist
for all index values, causing an error message whenever one of the non-existing 
objects is accessed.

The error message is:
	Use of uninitialized value in string eq at ./sensors-detect line 5941.

Index: prog/detect/sensors-detect
=================================--- prog/detect/sensors-detect	(revision 5868)
+++ prog/detect/sensors-detect	(working copy)
@@ -5936,7 +5936,9 @@
 	# If we added any module option to handle aliases, we need to load all
 	# the adapter drivers so that the numbers will be the same. If not, then
 	# we only load the adapter drivers which are useful.
-	foreach $adap (@i2c_adapters) {
+	for (my $dev_nr = 0; $dev_nr < @i2c_adapters; $dev_nr++) {
+		next unless exists $i2c_adapters[$dev_nr];
+		$adap = $i2c_adapters[$dev_nr];
 		next if $adap->{autoload};
 		next if $adap->{driver} eq 'UNKNOWN';
 		next if not defined $configfile and not $adap->{used};

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-10-19 16:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-19 16:48 [lm-sensors] [PATCH] lm-sensors: Fix error seen with non-sequential Guenter Roeck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.