From: Greg KH <greg@kroah.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-usb@vger.kernel.org,
linux-omap <linux-omap@vger.kernel.org>,
linux-main <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@ti.com>, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v2 2/3] usb: trivial Kconfig cleanups
Date: Tue, 19 Oct 2010 10:50:36 -0700 [thread overview]
Message-ID: <20101019175036.GB4618@kroah.com> (raw)
In-Reply-To: <AANLkTi=CzBriAFW2gzG68b=6wENysJZEkaO9jFrXQdnq@mail.gmail.com>
On Tue, Oct 19, 2010 at 08:15:19PM +0300, Felipe Contreras wrote:
> On Tue, Oct 19, 2010 at 6:51 PM, Greg KH <greg@kroah.com> wrote:
> > On Tue, Oct 19, 2010 at 01:03:27PM +0300, Felipe Contreras wrote:
> >> Note: USB_GADGET_MUSB_HDRC is already defined in usb/gadget.
> >>
> >> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> >
> > Please describe _what_ trivial cleanups you did, and why you did them.
> > Care to resend?
>
> How about:
> Shuffle the code a bit so the description is at the top, remove
> duplicated configs (USB_GADGET_MUSB_HDRC), 'default n' is redundant,
> and USB_GADGET_SELECTED should go after USB_GADGET (on the appropriate
> config).
Sounds good, but you need to resend it with this information in it, not
much I can do with it in an independant email.
thanks,
greg k-h
next prev parent reply other threads:[~2010-10-19 17:57 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 10:03 [PATCH v2 0/3] usb: generic Kconfig fixes Felipe Contreras
[not found] ` <1287482608-11320-1-git-send-email-felipe.contreras-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-10-19 10:03 ` [PATCH v2 1/3] usb: fix Kconfig warning Felipe Contreras
2010-10-19 10:03 ` Felipe Contreras
[not found] ` <1287482608-11320-2-git-send-email-felipe.contreras-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-10-19 10:28 ` Felipe Balbi
2010-10-19 10:28 ` Felipe Balbi
2010-10-19 15:50 ` Greg KH
2010-10-20 6:34 ` Felipe Balbi
2010-10-20 6:34 ` Felipe Balbi
2010-10-19 10:03 ` [PATCH v2 2/3] usb: trivial Kconfig cleanups Felipe Contreras
[not found] ` <1287482608-11320-3-git-send-email-felipe.contreras-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-10-19 15:51 ` Greg KH
2010-10-19 15:51 ` Greg KH
2010-10-19 17:15 ` Felipe Contreras
2010-10-19 17:50 ` Greg KH [this message]
2010-10-19 18:15 ` Felipe Contreras
2010-10-19 18:15 ` Felipe Contreras
2010-10-20 18:25 ` Felipe Balbi
2010-10-19 10:03 ` [PATCH v2 3/3] drivers: cleanup Kconfig stuff Felipe Contreras
[not found] ` <1287482608-11320-4-git-send-email-felipe.contreras-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-10-19 10:32 ` Felipe Balbi
2010-10-19 10:32 ` Felipe Balbi
2010-10-19 10:59 ` Felipe Contreras
[not found] ` <AANLkTinXzMQXoyyu+anSCvSuE9w3FWAP5HswDS0kfpzE-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-19 11:16 ` Felipe Balbi
2010-10-19 11:16 ` Felipe Balbi
2010-10-19 11:36 ` Felipe Contreras
2010-10-19 11:52 ` Felipe Balbi
[not found] ` <20101019115236.GL31170-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2010-10-19 14:32 ` Felipe Contreras
2010-10-19 14:32 ` Felipe Contreras
[not found] ` <AANLkTim3NsgjC3Nh8VCCrx4cV1Y+kn38=30=en0KCft6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-19 15:05 ` Felipe Balbi
2010-10-19 15:05 ` Felipe Balbi
2010-10-19 20:52 ` Felipe Contreras
[not found] ` <AANLkTinYM5aavk9_jcTTymff=OY+Yyv8T6C+dmMih0p_-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-19 23:44 ` Tony Lindgren
2010-10-19 23:44 ` Tony Lindgren
2010-10-20 0:13 ` Kevin Hilman
[not found] ` <87fww1u3fw.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2010-10-20 0:31 ` Tony Lindgren
2010-10-20 0:31 ` Tony Lindgren
2010-10-20 6:35 ` Felipe Balbi
2010-10-20 8:47 ` felipe.contreras
2010-10-19 13:40 ` Roger Quadros
2010-10-19 13:40 ` Roger Quadros
[not found] ` <4CBD9FD5.506-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-10-19 14:33 ` Felipe Contreras
2010-10-19 14:33 ` Felipe Contreras
2010-10-20 7:46 ` Roger Quadros
2010-10-20 8:01 ` Felipe Balbi
2010-10-20 8:53 ` felipe.contreras
2010-10-20 8:53 ` felipe.contreras
2010-10-20 9:14 ` Roger Quadros
[not found] ` <4CBEB312.7060400-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-10-20 9:23 ` Felipe Contreras
2010-10-20 9:23 ` Felipe Contreras
2010-10-20 12:33 ` Roger Quadros
2010-10-20 14:38 ` Felipe Contreras
2010-10-20 14:38 ` Felipe Contreras
[not found] ` <AANLkTinULxyUg_vHjk9RsQm4Row7vRC9ApzYXt7ZMQJD-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-21 14:07 ` Roger Quadros
2010-10-21 14:07 ` Roger Quadros
[not found] ` <4CC0493F.1000701-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-10-21 15:41 ` Felipe Balbi
2010-10-21 15:41 ` Felipe Balbi
2010-10-21 15:57 ` Tony Lindgren
2010-10-20 12:33 ` Roger Quadros
2010-10-20 12:54 ` Felipe Balbi
2010-10-20 14:52 ` Felipe Contreras
2010-10-20 15:15 ` Felipe Balbi
2010-10-20 16:22 ` Felipe Contreras
2010-10-20 16:22 ` Felipe Contreras
2010-10-20 17:54 ` Felipe Balbi
2010-10-20 17:54 ` Felipe Balbi
[not found] ` <20101020175420.GC3431-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2010-10-21 9:04 ` Felipe Contreras
2010-10-21 9:04 ` Felipe Contreras
[not found] ` <AANLkTin31dmD5OfR3-nvZSg82i3H=_xgH_isJc+Epttq-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-21 10:24 ` Felipe Balbi
2010-10-21 10:24 ` Felipe Balbi
2010-10-21 10:55 ` Felipe Contreras
2010-10-19 15:52 ` Greg KH
2010-10-19 15:52 ` Greg KH
[not found] ` <20101019155219.GI4589-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2010-10-19 16:12 ` Anand Gadiyar
2010-10-19 16:12 ` Anand Gadiyar
[not found] ` <4CBDC361.70507-l0cyMroinI0@public.gmane.org>
2010-10-19 16:23 ` Greg KH
2010-10-19 16:23 ` Greg KH
2010-10-19 17:06 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019175036.GB4618@kroah.com \
--to=greg@kroah.com \
--cc=balbi@ti.com \
--cc=felipe.contreras@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.