From: Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
To: Felipe Contreras
<felipe.contreras-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap <linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-main <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff
Date: Tue, 19 Oct 2010 08:52:19 -0700 [thread overview]
Message-ID: <20101019155219.GI4589@kroah.com> (raw)
In-Reply-To: <1287482608-11320-4-git-send-email-felipe.contreras-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Tue, Oct 19, 2010 at 01:03:28PM +0300, Felipe Contreras wrote:
> Add missing dependencies, and remove redundant ones, and select sensible
> defaults.
>
> Signed-off-by: Felipe Contreras <felipe.contreras-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/mfd/Kconfig | 3 ++-
> drivers/regulator/Kconfig | 1 +
> drivers/usb/gadget/Kconfig | 3 +--
> drivers/usb/musb/Kconfig | 6 ++----
> drivers/usb/otg/Kconfig | 2 ++
> 5 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index db51ea1..0bbaf01 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -156,6 +156,7 @@ config MENELAUS
> config TWL4030_CORE
> bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support"
> depends on I2C=y && GENERIC_HARDIRQS
> + default y if ARCH_OMAP3 || ARCH_OMAP4
Sorry, but unless the driver is somehow required to keep the board from
going up in a puff of smoke, a default should NEVER be y.
Because of that, I can't take this patch.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-usb@vger.kernel.org,
linux-omap <linux-omap@vger.kernel.org>,
linux-main <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@ti.com>, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff
Date: Tue, 19 Oct 2010 08:52:19 -0700 [thread overview]
Message-ID: <20101019155219.GI4589@kroah.com> (raw)
In-Reply-To: <1287482608-11320-4-git-send-email-felipe.contreras@gmail.com>
On Tue, Oct 19, 2010 at 01:03:28PM +0300, Felipe Contreras wrote:
> Add missing dependencies, and remove redundant ones, and select sensible
> defaults.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> drivers/mfd/Kconfig | 3 ++-
> drivers/regulator/Kconfig | 1 +
> drivers/usb/gadget/Kconfig | 3 +--
> drivers/usb/musb/Kconfig | 6 ++----
> drivers/usb/otg/Kconfig | 2 ++
> 5 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index db51ea1..0bbaf01 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -156,6 +156,7 @@ config MENELAUS
> config TWL4030_CORE
> bool "Texas Instruments TWL4030/TWL5030/TWL6030/TPS659x0 Support"
> depends on I2C=y && GENERIC_HARDIRQS
> + default y if ARCH_OMAP3 || ARCH_OMAP4
Sorry, but unless the driver is somehow required to keep the board from
going up in a puff of smoke, a default should NEVER be y.
Because of that, I can't take this patch.
greg k-h
next prev parent reply other threads:[~2010-10-19 15:52 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 10:03 [PATCH v2 0/3] usb: generic Kconfig fixes Felipe Contreras
[not found] ` <1287482608-11320-1-git-send-email-felipe.contreras-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-10-19 10:03 ` [PATCH v2 1/3] usb: fix Kconfig warning Felipe Contreras
2010-10-19 10:03 ` Felipe Contreras
[not found] ` <1287482608-11320-2-git-send-email-felipe.contreras-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-10-19 10:28 ` Felipe Balbi
2010-10-19 10:28 ` Felipe Balbi
2010-10-19 15:50 ` Greg KH
2010-10-20 6:34 ` Felipe Balbi
2010-10-20 6:34 ` Felipe Balbi
2010-10-19 10:03 ` [PATCH v2 2/3] usb: trivial Kconfig cleanups Felipe Contreras
[not found] ` <1287482608-11320-3-git-send-email-felipe.contreras-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-10-19 15:51 ` Greg KH
2010-10-19 15:51 ` Greg KH
2010-10-19 17:15 ` Felipe Contreras
2010-10-19 17:50 ` Greg KH
2010-10-19 18:15 ` Felipe Contreras
2010-10-19 18:15 ` Felipe Contreras
2010-10-20 18:25 ` Felipe Balbi
2010-10-19 10:03 ` [PATCH v2 3/3] drivers: cleanup Kconfig stuff Felipe Contreras
[not found] ` <1287482608-11320-4-git-send-email-felipe.contreras-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-10-19 10:32 ` Felipe Balbi
2010-10-19 10:32 ` Felipe Balbi
2010-10-19 10:59 ` Felipe Contreras
[not found] ` <AANLkTinXzMQXoyyu+anSCvSuE9w3FWAP5HswDS0kfpzE-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-19 11:16 ` Felipe Balbi
2010-10-19 11:16 ` Felipe Balbi
2010-10-19 11:36 ` Felipe Contreras
2010-10-19 11:52 ` Felipe Balbi
[not found] ` <20101019115236.GL31170-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2010-10-19 14:32 ` Felipe Contreras
2010-10-19 14:32 ` Felipe Contreras
[not found] ` <AANLkTim3NsgjC3Nh8VCCrx4cV1Y+kn38=30=en0KCft6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-19 15:05 ` Felipe Balbi
2010-10-19 15:05 ` Felipe Balbi
2010-10-19 20:52 ` Felipe Contreras
[not found] ` <AANLkTinYM5aavk9_jcTTymff=OY+Yyv8T6C+dmMih0p_-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-19 23:44 ` Tony Lindgren
2010-10-19 23:44 ` Tony Lindgren
2010-10-20 0:13 ` Kevin Hilman
[not found] ` <87fww1u3fw.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2010-10-20 0:31 ` Tony Lindgren
2010-10-20 0:31 ` Tony Lindgren
2010-10-20 6:35 ` Felipe Balbi
2010-10-20 8:47 ` felipe.contreras
2010-10-19 13:40 ` Roger Quadros
2010-10-19 13:40 ` Roger Quadros
[not found] ` <4CBD9FD5.506-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-10-19 14:33 ` Felipe Contreras
2010-10-19 14:33 ` Felipe Contreras
2010-10-20 7:46 ` Roger Quadros
2010-10-20 8:01 ` Felipe Balbi
2010-10-20 8:53 ` felipe.contreras
2010-10-20 8:53 ` felipe.contreras
2010-10-20 9:14 ` Roger Quadros
[not found] ` <4CBEB312.7060400-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-10-20 9:23 ` Felipe Contreras
2010-10-20 9:23 ` Felipe Contreras
2010-10-20 12:33 ` Roger Quadros
2010-10-20 14:38 ` Felipe Contreras
2010-10-20 14:38 ` Felipe Contreras
[not found] ` <AANLkTinULxyUg_vHjk9RsQm4Row7vRC9ApzYXt7ZMQJD-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-21 14:07 ` Roger Quadros
2010-10-21 14:07 ` Roger Quadros
[not found] ` <4CC0493F.1000701-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-10-21 15:41 ` Felipe Balbi
2010-10-21 15:41 ` Felipe Balbi
2010-10-21 15:57 ` Tony Lindgren
2010-10-20 12:33 ` Roger Quadros
2010-10-20 12:54 ` Felipe Balbi
2010-10-20 14:52 ` Felipe Contreras
2010-10-20 15:15 ` Felipe Balbi
2010-10-20 16:22 ` Felipe Contreras
2010-10-20 16:22 ` Felipe Contreras
2010-10-20 17:54 ` Felipe Balbi
2010-10-20 17:54 ` Felipe Balbi
[not found] ` <20101020175420.GC3431-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2010-10-21 9:04 ` Felipe Contreras
2010-10-21 9:04 ` Felipe Contreras
[not found] ` <AANLkTin31dmD5OfR3-nvZSg82i3H=_xgH_isJc+Epttq-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-21 10:24 ` Felipe Balbi
2010-10-21 10:24 ` Felipe Balbi
2010-10-21 10:55 ` Felipe Contreras
2010-10-19 15:52 ` Greg KH [this message]
2010-10-19 15:52 ` Greg KH
[not found] ` <20101019155219.GI4589-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2010-10-19 16:12 ` Anand Gadiyar
2010-10-19 16:12 ` Anand Gadiyar
[not found] ` <4CBDC361.70507-l0cyMroinI0@public.gmane.org>
2010-10-19 16:23 ` Greg KH
2010-10-19 16:23 ` Greg KH
2010-10-19 17:06 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019155219.GI4589@kroah.com \
--to=greg-u8xffu+wg4eavxtiumwx3w@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=felipe.contreras-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.