From: Minchan Kim <minchan.kim@gmail.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Greg Thelen <gthelen@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
containers@lists.osdl.org, Andrea Righi <arighi@develer.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Ciju Rajan K <ciju@linux.vnet.ibm.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v2][memcg+dirtylimit] Fix overwriting global vm dirty limit setting by memcg (Re: [PATCH v3 00/11] memcg: per cgroup dirty page accounting
Date: Wed, 20 Oct 2010 23:35:15 +0900 [thread overview]
Message-ID: <20101020143515.GB5243@barrios-desktop> (raw)
In-Reply-To: <20101020140255.5b8afb63.kamezawa.hiroyu@jp.fujitsu.com>
On Wed, Oct 20, 2010 at 02:02:55PM +0900, KAMEZAWA Hiroyuki wrote:
> Fixed one here.
> ==
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> Now, at calculating dirty limit, vm_dirty_param() is called.
> This function returns dirty-limit related parameters considering
> memory cgroup settings.
>
> Now, assume that vm_dirty_bytes=100M (global dirty limit) and
> memory cgroup has 1G of pages and 40 dirty_ratio, dirtyable memory is
> 500MB.
>
> In this case, global_dirty_limits will consider dirty_limt as
> 500 *0.4 = 200MB. This is bad...memory cgroup is not back door.
>
> This patch limits the return value of vm_dirty_param() considring
> global settings.
>
> Changelog:
> - fixed an argument "mem" int to u64
> - fixed to use global available memory to cap memcg's value.
>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
It should have written this on Documentation.
"memcg dirty limit can't exceed global dirty limit"
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan.kim@gmail.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Greg Thelen <gthelen@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
containers@lists.osdl.org, Andrea Righi <arighi@develer.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Ciju Rajan K <ciju@linux.vnet.ibm.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v2][memcg+dirtylimit] Fix overwriting global vm dirty limit setting by memcg (Re: [PATCH v3 00/11] memcg: per cgroup dirty page accounting
Date: Wed, 20 Oct 2010 23:35:15 +0900 [thread overview]
Message-ID: <20101020143515.GB5243@barrios-desktop> (raw)
In-Reply-To: <20101020140255.5b8afb63.kamezawa.hiroyu@jp.fujitsu.com>
On Wed, Oct 20, 2010 at 02:02:55PM +0900, KAMEZAWA Hiroyuki wrote:
> Fixed one here.
> ==
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> Now, at calculating dirty limit, vm_dirty_param() is called.
> This function returns dirty-limit related parameters considering
> memory cgroup settings.
>
> Now, assume that vm_dirty_bytes=100M (global dirty limit) and
> memory cgroup has 1G of pages and 40 dirty_ratio, dirtyable memory is
> 500MB.
>
> In this case, global_dirty_limits will consider dirty_limt as
> 500 *0.4 = 200MB. This is bad...memory cgroup is not back door.
>
> This patch limits the return value of vm_dirty_param() considring
> global settings.
>
> Changelog:
> - fixed an argument "mem" int to u64
> - fixed to use global available memory to cap memcg's value.
>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
It should have written this on Documentation.
"memcg dirty limit can't exceed global dirty limit"
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2010-10-20 14:35 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 0:39 [PATCH v3 00/11] memcg: per cgroup dirty page accounting Greg Thelen
2010-10-19 0:39 ` Greg Thelen
2010-10-19 0:39 ` [PATCH v3 01/11] memcg: add page_cgroup flags for dirty page tracking Greg Thelen
2010-10-19 0:39 ` Greg Thelen
2010-10-19 4:31 ` Daisuke Nishimura
2010-10-19 4:31 ` Daisuke Nishimura
2010-10-19 0:39 ` [PATCH v3 02/11] memcg: document cgroup dirty memory interfaces Greg Thelen
2010-10-19 0:39 ` Greg Thelen
2010-10-19 0:46 ` KAMEZAWA Hiroyuki
2010-10-19 0:46 ` KAMEZAWA Hiroyuki
2010-10-19 8:27 ` Daisuke Nishimura
2010-10-19 8:27 ` Daisuke Nishimura
2010-10-19 21:00 ` Greg Thelen
2010-10-19 21:00 ` Greg Thelen
2010-10-20 0:11 ` KAMEZAWA Hiroyuki
2010-10-20 0:11 ` KAMEZAWA Hiroyuki
2010-10-20 0:45 ` Greg Thelen
2010-10-20 0:45 ` Greg Thelen
2010-10-20 4:06 ` KAMEZAWA Hiroyuki
2010-10-20 4:06 ` KAMEZAWA Hiroyuki
2010-10-20 4:25 ` Greg Thelen
2010-10-20 4:25 ` Greg Thelen
2010-10-20 4:26 ` KAMEZAWA Hiroyuki
2010-10-20 4:26 ` KAMEZAWA Hiroyuki
2010-10-20 0:48 ` Daisuke Nishimura
2010-10-20 0:48 ` Daisuke Nishimura
2010-10-20 1:14 ` KAMEZAWA Hiroyuki
2010-10-20 1:14 ` KAMEZAWA Hiroyuki
2010-10-20 2:24 ` KAMEZAWA Hiroyuki
2010-10-20 2:24 ` KAMEZAWA Hiroyuki
2010-10-20 3:47 ` Daisuke Nishimura
2010-10-20 3:47 ` Daisuke Nishimura
2010-10-19 0:39 ` [PATCH v3 03/11] memcg: create extensible page stat update routines Greg Thelen
2010-10-19 0:39 ` Greg Thelen
2010-10-19 0:47 ` KAMEZAWA Hiroyuki
2010-10-19 0:47 ` KAMEZAWA Hiroyuki
2010-10-19 4:52 ` Daisuke Nishimura
2010-10-19 4:52 ` Daisuke Nishimura
2010-10-19 0:39 ` [PATCH v3 04/11] memcg: add lock to synchronize page accounting and migration Greg Thelen
2010-10-19 0:39 ` Greg Thelen
2010-10-19 0:45 ` KAMEZAWA Hiroyuki
2010-10-19 0:45 ` KAMEZAWA Hiroyuki
2010-10-19 4:43 ` [RFC][PATCH 1/2] memcg: move_account optimization by reduct put,get page (Re: " KAMEZAWA Hiroyuki
2010-10-19 4:43 ` KAMEZAWA Hiroyuki
2010-10-19 4:45 ` [RFC][PATCH 2/2] memcg: move_account optimization by reduce locks " KAMEZAWA Hiroyuki
2010-10-19 4:45 ` KAMEZAWA Hiroyuki
2010-10-19 1:17 ` Minchan Kim
2010-10-19 1:17 ` Minchan Kim
2010-10-19 5:03 ` Daisuke Nishimura
2010-10-19 5:03 ` Daisuke Nishimura
2010-10-19 0:39 ` [PATCH v3 05/11] memcg: add dirty page accounting infrastructure Greg Thelen
2010-10-19 0:39 ` Greg Thelen
2010-10-19 0:49 ` KAMEZAWA Hiroyuki
2010-10-19 0:49 ` KAMEZAWA Hiroyuki
2010-10-20 0:53 ` Daisuke Nishimura
2010-10-20 0:53 ` Daisuke Nishimura
2010-10-19 0:39 ` [PATCH v3 06/11] memcg: add kernel calls for memcg dirty page stats Greg Thelen
2010-10-19 0:39 ` Greg Thelen
2010-10-19 0:51 ` KAMEZAWA Hiroyuki
2010-10-19 0:51 ` KAMEZAWA Hiroyuki
2010-10-19 7:03 ` Daisuke Nishimura
2010-10-19 7:03 ` Daisuke Nishimura
2010-10-19 0:39 ` [PATCH v3 07/11] memcg: add dirty limits to mem_cgroup Greg Thelen
2010-10-19 0:39 ` Greg Thelen
2010-10-19 0:53 ` KAMEZAWA Hiroyuki
2010-10-19 0:53 ` KAMEZAWA Hiroyuki
2010-10-20 0:50 ` Daisuke Nishimura
2010-10-20 0:50 ` Daisuke Nishimura
2010-10-20 4:08 ` Greg Thelen
2010-10-20 4:08 ` Greg Thelen
2010-10-19 0:39 ` [PATCH v3 08/11] memcg: CPU hotplug lockdep warning fix Greg Thelen
2010-10-19 0:39 ` Greg Thelen
2010-10-19 0:54 ` KAMEZAWA Hiroyuki
2010-10-19 0:54 ` KAMEZAWA Hiroyuki
2010-10-20 3:47 ` Daisuke Nishimura
2010-10-20 3:47 ` Daisuke Nishimura
2010-10-19 0:39 ` [PATCH v3 09/11] memcg: add cgroupfs interface to memcg dirty limits Greg Thelen
2010-10-19 0:39 ` Greg Thelen
2010-10-19 0:56 ` KAMEZAWA Hiroyuki
2010-10-19 0:56 ` KAMEZAWA Hiroyuki
2010-10-20 3:31 ` Daisuke Nishimura
2010-10-20 3:31 ` Daisuke Nishimura
2010-10-20 3:44 ` KAMEZAWA Hiroyuki
2010-10-20 3:44 ` KAMEZAWA Hiroyuki
2010-10-20 3:46 ` Daisuke Nishimura
2010-10-20 3:46 ` Daisuke Nishimura
2010-10-19 0:39 ` [PATCH v3 10/11] writeback: make determine_dirtyable_memory() static Greg Thelen
2010-10-19 0:39 ` Greg Thelen
2010-10-19 0:57 ` KAMEZAWA Hiroyuki
2010-10-19 0:57 ` KAMEZAWA Hiroyuki
2010-10-20 3:47 ` Daisuke Nishimura
2010-10-20 3:47 ` Daisuke Nishimura
2010-10-19 0:39 ` [PATCH v3 11/11] memcg: check memcg dirty limits in page writeback Greg Thelen
2010-10-19 0:39 ` Greg Thelen
2010-10-19 1:00 ` KAMEZAWA Hiroyuki
2010-10-19 1:00 ` KAMEZAWA Hiroyuki
2010-10-20 4:18 ` KAMEZAWA Hiroyuki
2010-10-20 4:18 ` KAMEZAWA Hiroyuki
2010-10-20 4:33 ` Greg Thelen
2010-10-20 4:33 ` Greg Thelen
2010-10-20 4:33 ` KAMEZAWA Hiroyuki
2010-10-20 4:33 ` KAMEZAWA Hiroyuki
2010-10-20 4:34 ` Daisuke Nishimura
2010-10-20 4:34 ` Daisuke Nishimura
2010-10-20 5:25 ` Daisuke Nishimura
2010-10-20 5:25 ` Daisuke Nishimura
2010-10-20 3:21 ` [PATCH][memcg+dirtylimit] Fix overwriting global vm dirty limit setting by memcg (Re: [PATCH v3 00/11] memcg: per cgroup dirty page accounting KAMEZAWA Hiroyuki
2010-10-20 3:21 ` KAMEZAWA Hiroyuki
2010-10-20 4:14 ` KAMEZAWA Hiroyuki
2010-10-20 4:14 ` KAMEZAWA Hiroyuki
2010-10-20 5:02 ` [PATCH v2][memcg+dirtylimit] " KAMEZAWA Hiroyuki
2010-10-20 5:02 ` KAMEZAWA Hiroyuki
2010-10-20 6:09 ` Daisuke Nishimura
2010-10-20 6:09 ` Daisuke Nishimura
2010-10-20 14:35 ` Minchan Kim [this message]
2010-10-20 14:35 ` Minchan Kim
2010-10-21 0:10 ` KAMEZAWA Hiroyuki
2010-10-21 0:10 ` KAMEZAWA Hiroyuki
2010-10-24 18:44 ` Greg Thelen
2010-10-24 18:44 ` Greg Thelen
2010-10-25 0:24 ` KAMEZAWA Hiroyuki
2010-10-25 0:24 ` KAMEZAWA Hiroyuki
2010-10-25 2:00 ` Daisuke Nishimura
2010-10-25 2:00 ` Daisuke Nishimura
2010-10-25 7:03 ` Ciju Rajan K
2010-10-25 7:03 ` Ciju Rajan K
2010-10-25 7:08 ` KAMEZAWA Hiroyuki
2010-10-25 7:08 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020143515.GB5243@barrios-desktop \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arighi@develer.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=ciju@linux.vnet.ibm.com \
--cc=containers@lists.osdl.org \
--cc=gthelen@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.