From: Grant Likely <grant.likely@secretlab.ca>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: David Daney <ddaney@caviumnetworks.com>,
linux-mips@linux-mips.org, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Dezhong Diao <dediao@cisco.com>
Subject: Re: [PATCH] of/mips: Cleanup some include directives/files.
Date: Wed, 20 Oct 2010 12:03:32 -0600 [thread overview]
Message-ID: <20101020180332.GO7285@angua.secretlab.ca> (raw)
In-Reply-To: <20101020065830.GA12565@linux-mips.org>
On Wed, Oct 20, 2010 at 07:58:30AM +0100, Ralf Baechle wrote:
> On Tue, Oct 19, 2010 at 03:50:31PM -0700, David Daney wrote:
>
> > The __init directives should go on the definitions of things, not the
> > declaration, also __init is meaningless for inline functions, so
> > remove it from prom.h. This allows us to get rid of a useless
> > #include, but most of the rest of them are useless too, so kill them
> > as well.
> >
> > If of_i2c.c needs irq definitions, it should include linux/irq.h
> > directly, not assume indirect inclusion via asm/prom.h.
>
> Grant, I assume you're going to merge this one.
>
> Acked-by: Ralf Baechle <ralf@linux-mips.org>
Yes, I'll pick it up. I'm compile testing now.
g.
>
> Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
David Daney
<ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] of/mips: Cleanup some include directives/files.
Date: Wed, 20 Oct 2010 12:03:32 -0600 [thread overview]
Message-ID: <20101020180332.GO7285@angua.secretlab.ca> (raw)
In-Reply-To: <20101020065830.GA12565-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
On Wed, Oct 20, 2010 at 07:58:30AM +0100, Ralf Baechle wrote:
> On Tue, Oct 19, 2010 at 03:50:31PM -0700, David Daney wrote:
>
> > The __init directives should go on the definitions of things, not the
> > declaration, also __init is meaningless for inline functions, so
> > remove it from prom.h. This allows us to get rid of a useless
> > #include, but most of the rest of them are useless too, so kill them
> > as well.
> >
> > If of_i2c.c needs irq definitions, it should include linux/irq.h
> > directly, not assume indirect inclusion via asm/prom.h.
>
> Grant, I assume you're going to merge this one.
>
> Acked-by: Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
Yes, I'll pick it up. I'm compile testing now.
g.
>
> Ralf
next prev parent reply other threads:[~2010-10-20 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 22:50 [PATCH] of/mips: Cleanup some include directives/files David Daney
2010-10-19 22:50 ` David Daney
2010-10-20 6:58 ` Ralf Baechle
2010-10-20 18:03 ` Grant Likely [this message]
2010-10-20 18:03 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020180332.GO7285@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=ddaney@caviumnetworks.com \
--cc=dediao@cisco.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.