From: Jarod Wilson <jarod@redhat.com>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: lirc-list@lists.sourceforge.net,
"Jarod Wilson" <jarod@wilsonet.com>,
"David Härdeman" <david@hardeman.nu>,
mchehab@infradead.org, linux-input@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 0/3] Remaining patches in my queue for IR
Date: Wed, 20 Oct 2010 14:40:47 -0400 [thread overview]
Message-ID: <20101020184047.GC15314@redhat.com> (raw)
In-Reply-To: <1287269790-17605-1-git-send-email-maximlevitsky@gmail.com>
On Sun, Oct 17, 2010 at 12:56:27AM +0200, Maxim Levitsky wrote:
> Hi,
>
> This series is rebased on top of media_tree/staging/v2.6.37 only.
> Really this time, sorry for cheating, last time :-)
>
> The first patch like we agreed extends the raw packets.
> It touches all drivers (except imon as it isn't a raw IR driver).
> Code is compile tested with all drivers,
> and run tested with ENE and all receiver protocols
> (except the streamzap rc5 flavour)
> Since it also moves timeouts to lirc bridge, at least streazap driver
> should have its timeout gap support removed. I am afraid to break the code
> if I do so.
I've tested both mceusb and streamzap with this patchset included, don't
see any ill side-effects. Only issue I really saw was that the raw event
init call was added somewhat superfluously to a number of drivers -- the
rawir struct its initializing was already kzalloc'd, so we're just
needlessly re-zero'ing it out again. Its not bad for clarity's sake, but
does add some unnecessary inefficiency.
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2010-10-20 18:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 22:56 [PATCH 0/3] Remaining patches in my queue for IR Maxim Levitsky
2010-10-16 22:56 ` Maxim Levitsky
[not found] ` <1287269790-17605-1-git-send-email-maximlevitsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-10-16 22:56 ` [PATCH 1/3] IR: extend ir_raw_event and do refactoring Maxim Levitsky
2010-10-16 22:56 ` Maxim Levitsky
2010-10-23 12:13 ` David Härdeman
2010-10-16 22:56 ` [PATCH 2/3] IR: ene_ir: add support for carrier reports Maxim Levitsky
2010-10-16 22:56 ` [PATCH 3/3] IR: ene_ir: don't upload all settings on each TX packet Maxim Levitsky
2010-10-17 0:36 ` [PATCH 0/3] Remaining patches in my queue for IR Andy Walls
2010-10-17 1:07 ` Maxim Levitsky
2010-10-20 18:40 ` Jarod Wilson [this message]
2010-10-22 0:17 ` Maxim Levitsky
2010-10-20 19:43 ` David Härdeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020184047.GC15314@redhat.com \
--to=jarod@redhat.com \
--cc=david@hardeman.nu \
--cc=jarod@wilsonet.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lirc-list@lists.sourceforge.net \
--cc=maximlevitsky@gmail.com \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.