From: "David Härdeman" <david@hardeman.nu>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: lirc-list@lists.sourceforge.net,
Jarod Wilson <jarod@wilsonet.com>,
mchehab@infradead.org, linux-input@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/3] IR: extend ir_raw_event and do refactoring
Date: Sat, 23 Oct 2010 14:13:29 +0200 [thread overview]
Message-ID: <20101023121329.GA21845@hardeman.nu> (raw)
In-Reply-To: <1287269790-17605-2-git-send-email-maximlevitsky@gmail.com>
On Sun, Oct 17, 2010 at 12:56:28AM +0200, Maxim Levitsky wrote:
> Add new event types for timeout & carrier report
> Move timeout handling from ir_raw_event_store_with_filter to
> ir-lirc-codec, where it is really needed.
> Now lirc bridge ensures proper gap handling.
> Extend lirc bridge for carrier & timeout reports
>
> Note: all new ir_raw_event variables now should be initialized
> like that: DEFINE_IR_RAW_EVENT(ev);
>
> To clean an existing event, use init_ir_raw_event(&ev);
>
> Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
> Acked-by: Jarod Wilson <jarod@redhat.com>
I finally had a read-through of this patch. I like it. Note that we're
going to have to change the decoders to also use the timeout event
(since it basically behaves like a long space and e.g. the NEC decoder
waits for the trailing space before sending a keydown). The same problem
already exists for users of ir_raw_event_store_with_filter() though so
the patch should still go in.
Acked-by: David Härdeman <david@hardeman.nu>
next prev parent reply other threads:[~2010-10-23 12:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-16 22:56 [PATCH 0/3] Remaining patches in my queue for IR Maxim Levitsky
2010-10-16 22:56 ` Maxim Levitsky
[not found] ` <1287269790-17605-1-git-send-email-maximlevitsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-10-16 22:56 ` [PATCH 1/3] IR: extend ir_raw_event and do refactoring Maxim Levitsky
2010-10-16 22:56 ` Maxim Levitsky
2010-10-23 12:13 ` David Härdeman [this message]
2010-10-16 22:56 ` [PATCH 2/3] IR: ene_ir: add support for carrier reports Maxim Levitsky
2010-10-16 22:56 ` [PATCH 3/3] IR: ene_ir: don't upload all settings on each TX packet Maxim Levitsky
2010-10-17 0:36 ` [PATCH 0/3] Remaining patches in my queue for IR Andy Walls
2010-10-17 1:07 ` Maxim Levitsky
2010-10-20 18:40 ` Jarod Wilson
2010-10-22 0:17 ` Maxim Levitsky
2010-10-20 19:43 ` David Härdeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101023121329.GA21845@hardeman.nu \
--to=david@hardeman.nu \
--cc=jarod@wilsonet.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lirc-list@lists.sourceforge.net \
--cc=maximlevitsky@gmail.com \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.