From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] Removal of dead code from arch/arm/*
Date: Thu, 21 Oct 2010 08:54:01 +0100 [thread overview]
Message-ID: <20101021075401.GC22100@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4CBF8BDB.7090907@gmail.com>
On Thu, Oct 21, 2010 at 02:39:55AM +0200, N.P.S. wrote:
> diff --git a/arch/arm/kernel/time.c b/arch/arm/kernel/time.c
> index 38c261f..fd30b75 100644
> --- a/arch/arm/kernel/time.c
> +++ b/arch/arm/kernel/time.c
> @@ -37,13 +37,9 @@
> */
> struct sys_timer *system_timer;
>
> -#if defined(CONFIG_RTC_DRV_CMOS) || defined(CONFIG_RTC_DRV_CMOS_MODULE)
> +#if defined(CONFIG_RTC_DRV_CMOS)
> /* this needs a better home */
> DEFINE_SPINLOCK(rtc_lock);
> -
> -#ifdef CONFIG_RTC_DRV_CMOS_MODULE
> -EXPORT_SYMBOL(rtc_lock);
> -#endif
> #endif /* pc-style 'CMOS' RTC support */
>
> /* change this if you have some constant time drift */
This is wrong, and will break the build if rtc-cmos is built as a module.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "N.P.S." <napohybelskurwysynom2010@gmail.com>
Cc: Eric Miao <eric.y.miao@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] Removal of dead code from arch/arm/*
Date: Thu, 21 Oct 2010 08:54:01 +0100 [thread overview]
Message-ID: <20101021075401.GC22100@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4CBF8BDB.7090907@gmail.com>
On Thu, Oct 21, 2010 at 02:39:55AM +0200, N.P.S. wrote:
> diff --git a/arch/arm/kernel/time.c b/arch/arm/kernel/time.c
> index 38c261f..fd30b75 100644
> --- a/arch/arm/kernel/time.c
> +++ b/arch/arm/kernel/time.c
> @@ -37,13 +37,9 @@
> */
> struct sys_timer *system_timer;
>
> -#if defined(CONFIG_RTC_DRV_CMOS) || defined(CONFIG_RTC_DRV_CMOS_MODULE)
> +#if defined(CONFIG_RTC_DRV_CMOS)
> /* this needs a better home */
> DEFINE_SPINLOCK(rtc_lock);
> -
> -#ifdef CONFIG_RTC_DRV_CMOS_MODULE
> -EXPORT_SYMBOL(rtc_lock);
> -#endif
> #endif /* pc-style 'CMOS' RTC support */
>
> /* change this if you have some constant time drift */
This is wrong, and will break the build if rtc-cmos is built as a module.
next prev parent reply other threads:[~2010-10-21 7:54 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 0:23 [RFC] Removal of dead code from arch/arm/* Zimny Lech
2010-10-21 0:23 ` Zimny Lech
2010-10-21 0:32 ` Eric Miao
2010-10-21 0:32 ` Eric Miao
2010-10-21 0:39 ` N.P.S.
2010-10-21 0:39 ` N.P.S.
2010-10-21 0:58 ` Eric Miao
2010-10-21 0:58 ` Eric Miao
2010-10-21 7:54 ` Russell King - ARM Linux [this message]
2010-10-21 7:54 ` Russell King - ARM Linux
2010-10-21 8:19 ` Zimny Lech
2010-10-21 8:19 ` Zimny Lech
2010-10-21 10:00 ` Zimny Lech
2010-10-21 10:00 ` Zimny Lech
2010-10-21 11:11 ` Zimny Lech
2010-10-21 11:11 ` Zimny Lech
2010-10-21 12:16 ` Zimny Lech
2010-10-21 12:16 ` Zimny Lech
2010-10-21 13:07 ` Zimny Lech
2010-10-21 13:07 ` Zimny Lech
2010-10-21 20:52 ` Zimny Lech
2010-10-21 20:52 ` Zimny Lech
2010-10-22 1:13 ` Zimny Lech
2010-10-22 1:13 ` Zimny Lech
2010-10-22 14:19 ` Michał Mirosław
2010-10-22 14:19 ` Michał Mirosław
2010-10-22 14:39 ` Zimny Lech
2010-10-22 14:39 ` Zimny Lech
2010-10-22 15:15 ` Michał Mirosław
2010-10-22 15:15 ` Michał Mirosław
2010-10-25 23:35 ` Zimny Lech
2010-10-25 23:35 ` Zimny Lech
2010-11-07 19:43 ` Russell King - ARM Linux
2010-11-07 19:43 ` Russell King - ARM Linux
2010-10-21 9:27 ` Uwe Kleine-König
2010-10-21 9:27 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021075401.GC22100@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.