All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: add generic GPIO fan driver
Date: Thu, 21 Oct 2010 20:26:38 +0000	[thread overview]
Message-ID: <20101021202638.GA27794@ericsson.com> (raw)
In-Reply-To: <20101021200710.GR29120@kw.sim.vm.gnt>

Hi Simon,

On Thu, Oct 21, 2010 at 04:07:10PM -0400, Simon Guinot wrote:
[ ... ]

> > > @@ -399,6 +399,15 @@ config SENSORS_GL520SM
> > >           This driver can also be built as a module.  If so, the module
> > >           will be called gl520sm.
> > > 
> > > +config SENSORS_GPIO_FAN
> > > +       tristate "GPIO fan"
> > > +       depends on GENERIC_GPIO
> > > +       help
> > > +         If you say yes here you get support for the GPIO connected fan.
> > > +
> > > +         This driver can also be built as a module.  If so, the module
> > > +         will be called gpio-fan.
> > > +
> > 
> > Can you move this up a bit, ahead of SENSORS_FSCHMD ? Trying to stay in sequence.
> 
> Ok. Let's try to figure out where is the right location :)
> After SENSORS_GL520SM or not ?
> 

My brain must have told me that "G" comes before "F". Or so. ABCDEGF, isn't it ?

After SENSORS_GL520SM. Sorry. Or whereever it fits in the alphabet,
if I got that wrong again ;).

Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: guenter.roeck@ericsson.com (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] hwmon: add generic GPIO fan driver
Date: Thu, 21 Oct 2010 13:26:38 -0700	[thread overview]
Message-ID: <20101021202638.GA27794@ericsson.com> (raw)
In-Reply-To: <20101021200710.GR29120@kw.sim.vm.gnt>

Hi Simon,

On Thu, Oct 21, 2010 at 04:07:10PM -0400, Simon Guinot wrote:
[ ... ]

> > > @@ -399,6 +399,15 @@ config SENSORS_GL520SM
> > >           This driver can also be built as a module.  If so, the module
> > >           will be called gl520sm.
> > > 
> > > +config SENSORS_GPIO_FAN
> > > +       tristate "GPIO fan"
> > > +       depends on GENERIC_GPIO
> > > +       help
> > > +         If you say yes here you get support for the GPIO connected fan.
> > > +
> > > +         This driver can also be built as a module.  If so, the module
> > > +         will be called gpio-fan.
> > > +
> > 
> > Can you move this up a bit, ahead of SENSORS_FSCHMD ? Trying to stay in sequence.
> 
> Ok. Let's try to figure out where is the right location :)
> After SENSORS_GL520SM or not ?
> 

My brain must have told me that "G" comes before "F". Or so. ABCDEGF, isn't it ?

After SENSORS_GL520SM. Sorry. Or whereever it fits in the alphabet,
if I got that wrong again ;).

Guenter

  reply	other threads:[~2010-10-21 20:26 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-22 10:54 [lm-sensors] [PATCH 4/5] hwmon: DNS323 rev C1 fan support Benjamin Herrenschmidt
2010-05-22 10:54 ` Benjamin Herrenschmidt
2010-05-22 11:00 ` [lm-sensors] " Benjamin Herrenschmidt
2010-05-22 11:00   ` Benjamin Herrenschmidt
2010-10-13 11:59 ` [lm-sensors] " Simon Guinot
2010-10-13 11:59   ` Simon Guinot
2010-10-13 16:34   ` [lm-sensors] " Guenter Roeck
2010-10-13 16:34     ` Guenter Roeck
2010-10-17 15:40     ` Simon Guinot
2010-10-17 15:40       ` Simon Guinot
2010-10-17 15:50       ` [lm-sensors] [PATCH 1/2] hwmon: add generic GPIO fan driver Simon Guinot
2010-10-17 15:50         ` Simon Guinot
2010-10-17 15:50         ` [lm-sensors] [PATCH 2/2] [ARM] Kirkwood: add fan support for Simon Guinot
2010-10-17 15:50           ` [PATCH 2/2] [ARM] Kirkwood: add fan support for Network Space Max v2 Simon Guinot
2010-10-22  1:53           ` [lm-sensors] [PATCH 2/2] [ARM] Kirkwood: add fan support for Guenter Roeck
2010-10-22  1:53             ` [PATCH 2/2] [ARM] Kirkwood: add fan support for Network Space Max v2 Guenter Roeck
2010-10-22  2:08             ` [lm-sensors] [PATCH 2/2] [ARM] Kirkwood: add fan support for Nicolas Pitre
2010-10-22  2:08               ` [PATCH 2/2] [ARM] Kirkwood: add fan support for Network Space Max v2 Nicolas Pitre
2010-10-22  4:30               ` [lm-sensors] [PATCH 2/2] [ARM] Kirkwood: add fan support for Guenter Roeck
2010-10-22  4:30                 ` [PATCH 2/2] [ARM] Kirkwood: add fan support for Network Space Max v2 Guenter Roeck
2010-10-22  9:29                 ` [lm-sensors] [PATCH] [ARM] Kirkwood: add fan support for Network Simon Guinot
2010-10-22  9:29                   ` [PATCH] [ARM] Kirkwood: add fan support for Network Space Max v2 Simon Guinot
2010-10-22  9:59                   ` [lm-sensors] [PATCH] [ARM] Kirkwood: add fan support for Guenter Roeck
2010-10-22  9:59                     ` [PATCH] [ARM] Kirkwood: add fan support for Network Space Max v2 Guenter Roeck
2010-10-22  8:27               ` [lm-sensors] [PATCH 2/2] [ARM] Kirkwood: add fan support for Simon Guinot
2010-10-22  8:27                 ` [PATCH 2/2] [ARM] Kirkwood: add fan support for Network Space Max v2 Simon Guinot
2010-10-22  9:58                 ` [lm-sensors] [PATCH 2/2] [ARM] Kirkwood: add fan support for Guenter Roeck
2010-10-22  9:58                   ` [PATCH 2/2] [ARM] Kirkwood: add fan support for Network Space Max v2 Guenter Roeck
2010-10-22 18:39                 ` [lm-sensors] [PATCH 2/2] [ARM] Kirkwood: add fan support for Guenter Roeck
2010-10-22 18:39                   ` [PATCH 2/2] [ARM] Kirkwood: add fan support for Network Space Max v2 Guenter Roeck
2010-10-22 18:50                   ` [lm-sensors] [PATCH 2/2] [ARM] Kirkwood: add fan support for Nicolas Pitre
2010-10-22 18:50                     ` [PATCH 2/2] [ARM] Kirkwood: add fan support for Network Space Max v2 Nicolas Pitre
2010-10-18 16:08         ` [lm-sensors] [PATCH 1/2] hwmon: add generic GPIO fan driver Guenter Roeck
2010-10-18 16:08           ` Guenter Roeck
2010-10-18 18:00           ` [lm-sensors] " Chris Moore
2010-10-18 18:00             ` Chris Moore
2010-10-18 18:35             ` [lm-sensors] " Guenter Roeck
2010-10-18 18:35               ` Guenter Roeck
2010-10-18 20:36           ` [lm-sensors] " Simon Guinot
2010-10-18 20:36             ` Simon Guinot
2010-10-18 20:50             ` [lm-sensors] " Guenter Roeck
2010-10-18 20:50               ` Guenter Roeck
2010-10-19 11:46               ` [lm-sensors] " Simon Guinot
2010-10-19 11:46                 ` Simon Guinot
2010-10-19 14:52                 ` [lm-sensors] " Guenter Roeck
2010-10-19 14:52                   ` Guenter Roeck
2010-10-19  6:52             ` [lm-sensors] " Guenter Roeck
2010-10-19  6:52               ` Guenter Roeck
2010-10-19  8:36               ` [lm-sensors] " Simon Guinot
2010-10-19  8:36                 ` Simon Guinot
2010-10-19 15:15                 ` [lm-sensors] " Guenter Roeck
2010-10-19 15:15                   ` Guenter Roeck
2010-10-19 19:30                   ` [lm-sensors] " Simon Guinot
2010-10-19 19:30                     ` Simon Guinot
2010-10-21 20:07           ` [lm-sensors] " Simon Guinot
2010-10-21 20:07             ` Simon Guinot
2010-10-21 20:26             ` Guenter Roeck [this message]
2010-10-21 20:26               ` Guenter Roeck
2010-10-19 22:03         ` [lm-sensors] " Guenter Roeck
2010-10-19 22:03           ` Guenter Roeck
2010-10-20  0:19           ` [lm-sensors] " Simon Guinot
2010-10-20  0:19             ` Simon Guinot
2010-10-20  0:50             ` [lm-sensors] " Guenter Roeck
2010-10-20  0:50               ` Guenter Roeck
2010-10-20  7:59               ` [lm-sensors] " Simon Guinot
2010-10-20  7:59                 ` Simon Guinot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101021202638.GA27794@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.