* [PATCH] ASoC: max98088: Staticise m98088_eq_band
@ 2010-10-21 11:15 Dimitris Papastamos
2010-10-21 20:35 ` Liam Girdwood
2010-10-21 20:48 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Dimitris Papastamos @ 2010-10-21 11:15 UTC (permalink / raw)
To: Peter Hsiang, Mark Brown, Liam Girdwood; +Cc: alsa-devel, patches
This function is not exported and it does not seem to be called from
anywhere else therefore it should be static.
Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
---
sound/soc/codecs/max98088.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c
index 4186b27..e7a40d1 100644
--- a/sound/soc/codecs/max98088.c
+++ b/sound/soc/codecs/max98088.c
@@ -613,7 +613,7 @@ static int max98088_volatile_register(unsigned int reg)
/*
* Load equalizer DSP coefficient configurations registers
*/
-void m98088_eq_band(struct snd_soc_codec *codec, unsigned int dai,
+static void m98088_eq_band(struct snd_soc_codec *codec, unsigned int dai,
unsigned int band, u16 *coefs)
{
unsigned int eq_reg;
--
1.7.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: max98088: Staticise m98088_eq_band
2010-10-21 11:15 [PATCH] ASoC: max98088: Staticise m98088_eq_band Dimitris Papastamos
@ 2010-10-21 20:35 ` Liam Girdwood
2010-10-21 20:48 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-10-21 20:35 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: Peter Hsiang, alsa-devel, Mark Brown, patches
On Thu, 2010-10-21 at 12:15 +0100, Dimitris Papastamos wrote:
> This function is not exported and it does not seem to be called from
> anywhere else therefore it should be static.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
> ---
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: max98088: Staticise m98088_eq_band
2010-10-21 11:15 [PATCH] ASoC: max98088: Staticise m98088_eq_band Dimitris Papastamos
2010-10-21 20:35 ` Liam Girdwood
@ 2010-10-21 20:48 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-10-21 20:48 UTC (permalink / raw)
To: Dimitris Papastamos; +Cc: Peter Hsiang, alsa-devel, patches, Liam Girdwood
On Thu, Oct 21, 2010 at 12:15:56PM +0100, Dimitris Papastamos wrote:
> This function is not exported and it does not seem to be called from
> anywhere else therefore it should be static.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-21 20:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-21 11:15 [PATCH] ASoC: max98088: Staticise m98088_eq_band Dimitris Papastamos
2010-10-21 20:35 ` Liam Girdwood
2010-10-21 20:48 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.