From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Eric Bénard" <eric@eukrea.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] wm1133-ev1: fix init for multimachine kernel
Date: Thu, 21 Oct 2010 18:17:57 -0700 [thread overview]
Message-ID: <20101022011757.GC28350@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4CC0BC73.8070709@eukrea.com>
On Fri, Oct 22, 2010 at 12:19:31AM +0200, Eric Bénard wrote:
> Le 21/10/2010 23:58, Mark Brown a écrit :
> >On Thu, Oct 21, 2010 at 11:35:15PM +0200, Eric Bénard wrote:
> >This is not a sufficient check, we may be running on an mx31ads with a
> >different PMIC module.
> in which case the current code would also fail ;-)
> I don't have such a board but actual code triggers the error log
> when running the kernel on my board so I'm open to your suggestion
> for a better fix.
Without adding machine fit checks it's always going to fail; machine
type isn't quite enough. What we should be doing here is using the
multi-component work to allow us to replace soc-audio devices with
devices named for the machine driver (which is all round better anyway).
I'll try to look at this for .38.
prev parent reply other threads:[~2010-10-22 1:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 21:35 [PATCH] wm1133-ev1: fix init for multimachine kernel Eric Bénard
2010-10-21 21:58 ` Mark Brown
2010-10-21 22:19 ` Eric Bénard
2010-10-22 1:17 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022011757.GC28350@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=eric@eukrea.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.