All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] wm1133-ev1: fix init for multimachine	kernel
Date: Fri, 22 Oct 2010 00:19:31 +0200	[thread overview]
Message-ID: <4CC0BC73.8070709@eukrea.com> (raw)
In-Reply-To: <20101021215840.GF30466@opensource.wolfsonmicro.com>

Hi Mark,

Le 21/10/2010 23:58, Mark Brown a écrit :
> On Thu, Oct 21, 2010 at 11:35:15PM +0200, Eric Bénard wrote:
>
>> +	if (!machine_is_mx31ads())
>> +		/* return happy. We might run on a totally different machine */
>> +		return 0;
>> +
>
> This is not a sufficient check, we may be running on an mx31ads with a
> different PMIC module.

in which case the current code would also fail ;-)

I don't have such a board but actual code triggers the error log when running 
the kernel on my board so I'm open to your suggestion for a better fix.

Thanks,
Eric

  reply	other threads:[~2010-10-21 22:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-21 21:35 [PATCH] wm1133-ev1: fix init for multimachine kernel Eric Bénard
2010-10-21 21:58 ` Mark Brown
2010-10-21 22:19   ` Eric Bénard [this message]
2010-10-22  1:17     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC0BC73.8070709@eukrea.com \
    --to=eric@eukrea.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.