From: "Jörn Engel" <joern@logfs.org>
To: Nicolas Kaiser <nikai@nikai.net>
Cc: linux-mtd@lists.infradead.org,
Joern Engel <joern@lazybastard.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block2mtd: dubious assignment
Date: Fri, 22 Oct 2010 16:34:16 +0200 [thread overview]
Message-ID: <20101022143416.GA12737@logfs.org> (raw)
In-Reply-To: <20101022124724.59eba464@absol.kitzblitz>
On Fri, 22 October 2010 12:47:24 +0200, Nicolas Kaiser wrote:
>
> When block2mtd_erase fails, a duplicated assignment instantly
> changes instr->state from MTD_ERASE_FAILED to MTD_ERASE_DONE.
>
> It looks to me like this might not be intended, or is it?
Definitely not. Just proves how well block device errors are tested.
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Acked-By: Joern Engel <joern@logfs.org>
Artem, can I leave this patch to you as well?
Jörn
--
Eighty percent of success is showing up.
-- Woody Allen
WARNING: multiple messages have this Message-ID (diff)
From: "Jörn Engel" <joern@logfs.org>
To: Nicolas Kaiser <nikai@nikai.net>
Cc: Joern Engel <joern@lazybastard.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block2mtd: dubious assignment
Date: Fri, 22 Oct 2010 16:34:16 +0200 [thread overview]
Message-ID: <20101022143416.GA12737@logfs.org> (raw)
In-Reply-To: <20101022124724.59eba464@absol.kitzblitz>
On Fri, 22 October 2010 12:47:24 +0200, Nicolas Kaiser wrote:
>
> When block2mtd_erase fails, a duplicated assignment instantly
> changes instr->state from MTD_ERASE_FAILED to MTD_ERASE_DONE.
>
> It looks to me like this might not be intended, or is it?
Definitely not. Just proves how well block device errors are tested.
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Acked-By: Joern Engel <joern@logfs.org>
Artem, can I leave this patch to you as well?
Jörn
--
Eighty percent of success is showing up.
-- Woody Allen
next prev parent reply other threads:[~2010-10-22 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 10:47 [PATCH] block2mtd: dubious assignment Nicolas Kaiser
2010-10-22 14:34 ` Jörn Engel [this message]
2010-10-22 14:34 ` Jörn Engel
2010-10-22 16:13 ` Artem Bityutskiy
2010-10-22 16:13 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022143416.GA12737@logfs.org \
--to=joern@logfs.org \
--cc=joern@lazybastard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nikai@nikai.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.